From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A8C4C4338F for ; Mon, 16 Aug 2021 23:03:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6A4E60E09 for ; Mon, 16 Aug 2021 23:03:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D6A4E60E09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U6sxdz5M2xypdCob+2r9R+UjcaZ+ToFvgWO0SCQFOg8=; b=m4M1cFfQoBYsDy 0uFUrWF3uEZJX1LvDPkMWpQILdARxlLnws9oC7omM0gvLPkA2lNkAiyAoXGeEkj7XahusHYPyG4If z6J7u+3wjRYsUXpePq8kTw7X4gO93IhDAtbK7fPaU/YcHfEl3sok3FyOw4ex056x7Yj9+FnqjT6wy F5/ICR4ougoD6c4LXVjns+Ds+HxlLZ6qK6GCdk4Xd7gVrHkNIeNyKBWGTiRPGvF4uAXhPpbuY9UG9 Fj8DmKNpNh5YNS3m+hn+CHWi9UaEbqpL93mBd9InRUaBVvTS0RsQR14Cij1FhGlEd4bwLtiNVj4o3 Kv2huL99wKyLETFk/PkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFlb4-000TA5-3E; Mon, 16 Aug 2021 23:00:46 +0000 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFlaw-000T8g-Tn for linux-arm-kernel@lists.infradead.org; Mon, 16 Aug 2021 23:00:42 +0000 Received: by mail-lj1-x22b.google.com with SMTP id c12so16719610ljr.5 for ; Mon, 16 Aug 2021 16:00:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qCWu86tois4HzDjhxB5sPemRVqiKsSoDbxypDi9Z5+0=; b=z1v7oH+A7DDJ+ZpK2dUBsqz+f3S5ioTGJlgemaOwMO/L1AfOi49FHv8vz2Gyw2Iib1 cOikpkgggD63UmFz1/ychby9CDBTIMxUrHzJcpJr90wnfh64TPArcOReOXV6qvNB/W3j iX2vHy8T/MHeKjU1mY5t6zsezU78E7DcyjiUoJ4bC2dI8EiV0EH6h0LwCQM3Kp1cL+wI cgdJpqHJiHNMSx8jUT0YcbhCDOGCJ18DbQjQC0pTRuHO4Yx3p4k1MTUgVWeIWbGmsTZ3 86XeyMe22JZhDxgOpJeLpCINFeRPUIDOiYjfXU/sKuhlT+/TrYCjtXzL5V7X14ElwzLS k2mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qCWu86tois4HzDjhxB5sPemRVqiKsSoDbxypDi9Z5+0=; b=I5al2PqVbPqk5N4dhTPRSBdkqy1rN8ySACsUW5Lv5jNjNoOkue1kfEdDlEp8tIAO4H NEEOnQcVXCCiSD7uzv1/0vjuA7t2XP7YMCakAInVRUKFLNmcv4XQJbRob9ZGrKjj6SCn wbhwDvcaJ1j8lVes3VjizcyXgQ8XHhFOVZkG4qRV/38ojrwJZI93dDyzQAjAuiT+HLQI cKsXezFeyl91j56SqoY0H+x8vzvNbFAXq5aF8+HFGfGqw8G2iZR64e5ziRTiNN2qg49I GSfS2+mh35nMWQADHRFQYjnxQo6tqN2nQL0suo42D2R9rHegPbA1zWKrAmyutvmFYUYj ESAw== X-Gm-Message-State: AOAM5339TB0Ur/g31u7UOlQOQnC2g7uRBt+E2DoRHBzF696UMoN/MswR jL09ZOWbTxqfrRIYGyhnODzsR+UYr/CyrUOf9qt2UA== X-Google-Smtp-Source: ABdhPJxKcr3tDBh889ZdkpDoJwN0ES9RscVrpyGEFVwDUZlW9BP1duIsjDpHOms2QM93AclfvKwqHgphf+CtZyBXZVA= X-Received: by 2002:a05:651c:1507:: with SMTP id e7mr491801ljf.368.1629154836469; Mon, 16 Aug 2021 16:00:36 -0700 (PDT) MIME-Version: 1.0 References: <20210710081722.1828-1-zhiyong.tao@mediatek.com> <20210710081722.1828-2-zhiyong.tao@mediatek.com> <1626940470.29611.9.camel@mhfsdcap03> <07388dac4e25e0f260725e8f80ba099d5aa80949.camel@mediatek.com> <4fd12d5c53f6492e5fa3ba94a78b9a149f5b6ed9.camel@mediatek.com> In-Reply-To: From: Linus Walleij Date: Tue, 17 Aug 2021 01:00:25 +0200 Message-ID: Subject: Re: [PATCH v10 1/2] dt-bindings: pinctrl: mt8195: add rsel define To: Chen-Yu Tsai Cc: "zhiyong.tao" , Rob Herring , Mark Rutland , Matthias Brugger , Sean Wang , srv_heupstream , hui.liu@mediatek.com, Eddie Huang , Light Hsieh , Biao Huang , Hongzhou Yang , Sean Wang , Seiya Wang , Devicetree List , LKML , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/Mediatek SoC support" , "open list:GPIO SUBSYSTEM" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210816_160039_039668_2B7879EC X-CRM114-Status: GOOD ( 18.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 16, 2021 at 5:38 PM Chen-Yu Tsai wrote: > On Mon, Aug 16, 2021 at 6:48 PM zhiyong.tao wrote: > > > I'll take that as "use SI units whenever possible and reasonable". > > > > ==> so It doesn't need to change the define, is it right? > > we will keep the common define. > > Actually I think it would be possible and reasonable to use SI units > in this case, since you are the vendor and have the resistor values > to implement the support. Having different sets of values for different > chips is nothing out of the ordinary. We already have to account for > different number of pins and different pin functions. That is what > compatible strings are for. I fully agree with Chen-Yu's analysis here. Zhiyong can you make an attempt to use SI units (Ohms) and see what it will look like? I think it will look better for users and it will be less risk to make mistakes. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel