From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A9C3C0650F for ; Mon, 5 Aug 2019 10:15:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4B1F2087B for ; Mon, 5 Aug 2019 10:15:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EXaNvtHy"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h7hSXRNh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4B1F2087B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Js2bz0/Cf2kWkx6E/IQdpGl6XZYLp6gWhPZH+JZ9vGM=; b=EXaNvtHyR3SXWP pdlc3A5EwtLiBom0vVzFXt49MoBGSwudTFqY4uKpasC+tFeKIu4wEEJNEIRV0UPvPgbYZrwlybYlg 6lN2tDIwInYkbyUJ0vE7SD8uu8XkgDL/MM4oODzMOcONHOEk9AK/z01YPZs1q+vVCKhnxu5FZeYQ7 H+3lghFXHH4yCmdAZRt4H4BZbGac3Nq763qugOwGwwY63AZKCJUJPtUFC9Fx2GYHXuYuWS/oJtRGf telqeeEt4YFnPx1ZtPbwBi1zZpvayhKoHqlB4DxKFPEalDR+JOA0UN/WqpiqZA1UzasyZ8m9+yR7L CZ/f7ALychkaRniYxrBQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hua1W-0003WG-4M; Mon, 05 Aug 2019 10:15:26 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hua1S-0003Vh-MY for linux-arm-kernel@lists.infradead.org; Mon, 05 Aug 2019 10:15:23 +0000 Received: by mail-lj1-x244.google.com with SMTP id k18so78782714ljc.11 for ; Mon, 05 Aug 2019 03:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EVUakBz4HVrBvU5WozBP9zRGYaZ2u063yCbTr8IH9wg=; b=h7hSXRNhw+BgWJVjsm3CUTt+gZ14IRMN5LjwbEypK2d6eMw0PVs2ntw/YUTNTo6K5c YvYdlQu43bwvSdSCHbk9ALOWXZGSYh2Z6De9g/Su7n1CVvElbTYf5Sk4V3CWU/t6arn5 QL5v+l4NitaSIZfsmJrgpY7tfjio4lzr/M6up+lXW9V3Ps9ZuOirB94gxrz8x1FG8GQs RttJ3Vra50Bu2sxlntxYoVh4k7IcugIs4VJCZaH9TonMZSuJSrbdbZTXGgz+gcjtPoyh AP/Ox8IvhETub7PSCfZSGGX1tuRPisg0IWmhPaXV0jTRZ/ydreArtzV03pszTkbXybr9 hJFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EVUakBz4HVrBvU5WozBP9zRGYaZ2u063yCbTr8IH9wg=; b=D7xUUMrgsTZrIJyZ6TnXurThAePyU/p0dRwJ+a6y3TON3mSSQnUFP+7yhjNn/fDeVy Mi4cdDZAJ0lgITQ2at9TorvrK2OA9pkDGFq5C9RiWQegBm4wOO5gNWYja/1Vcbc0w3cw 4MMIM2N4cICnRdK5p5UcqOQlOuvh2ZPFZXGZjKvLbIDBko0CIPx5buvxLoT6TLZO0KMl Yl21aR2kBl89TVKvW5VC9WamXF/T0NtxsldslFJ1RWJ4GSh96HVmvmh6z/PsbuUBOZGi 0AqLxzZGH6Tz4wS2D779NkzzMMle14YcE7jA4oPWfQbLYG2sZXHFEXx382lTZbQlwMn+ 3Agg== X-Gm-Message-State: APjAAAVwXKqsOxdGwBhBfYYTcPZrwZiL1gxt7FpOns8YRYx9QsIBFQRX ir+2nmaQ7YgXdN+m2jOKE7yZlraZcFEknpNwDtBdIQ== X-Google-Smtp-Source: APXvYqySHuR6d+bEQrsbTHzEENtYOVUi+8awDm/vDpXZ3zt3zWFIJstQGj1Z5v+QGxwqmgpUNdelEqXuxOip7mnqSPc= X-Received: by 2002:a2e:8195:: with SMTP id e21mr9719149ljg.62.1565000120908; Mon, 05 Aug 2019 03:15:20 -0700 (PDT) MIME-Version: 1.0 References: <1564053416-32192-1-git-send-email-amelie.delaunay@st.com> In-Reply-To: <1564053416-32192-1-git-send-email-amelie.delaunay@st.com> From: Linus Walleij Date: Mon, 5 Aug 2019 12:15:09 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: stmfx: update pinconf settings To: Amelie Delaunay X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190805_031522_743818_5C3B34C4 X-CRM114-Status: GOOD ( 10.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Maxime Coquelin , linux-stm32@st-md-mailman.stormreply.com, Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 25, 2019 at 1:16 PM Amelie Delaunay wrote: > From: Alexandre Torgue > > According to the following tab (coming from STMFX datasheet), updates > have to done in stmfx_pinconf_set function: > > -"type" has to be set when "bias" is configured as "pull-up or pull-down" > -PIN_CONFIG_DRIVE_PUSH_PULL should only be used when gpio is configured as > output. There is so no need to check direction. > > DIR | TYPE | PUPD | MFX GPIO configuration > ----|------|------|--------------------------------------------------- > 1 | 1 | 1 | OUTPUT open drain with internal pull-up resistor > ----|------|------|--------------------------------------------------- > 1 | 1 | 0 | OUTPUT open drain with internal pull-down resistor > ----|------|------|--------------------------------------------------- > 1 | 0 | 0/1 | OUTPUT push pull no pull > ----|------|------|--------------------------------------------------- > 0 | 1 | 1 | INPUT with internal pull-up resistor > ----|------|------|--------------------------------------------------- > 0 | 1 | 0 | INPUT with internal pull-down resistor > ----|------|------|--------------------------------------------------- > 0 | 0 | 1 | INPUT floating > ----|------|------|--------------------------------------------------- > 0 | 0 | 0 | analog (GPIO not used, default setting) > > Signed-off-by: Alexandre Torgue > Signed-off-by: Amelie Delaunay Patch applied. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel