From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 11/18] pinctrl: Add pinctrl driver for STM32 MCUs
Date: Fri, 6 Mar 2015 10:24:25 +0100 [thread overview]
Message-ID: <CACRpkdbuJ5B_GwvRXax2Y4V37ihh5e6H7=2no0fYTMZPXwDdCw@mail.gmail.com> (raw)
In-Reply-To: <1424455277-29983-12-git-send-email-mcoquelin.stm32@gmail.com>
On Fri, Feb 20, 2015 at 7:01 PM, Maxime Coquelin
<mcoquelin.stm32@gmail.com> wrote:
> This driver adds pinctrl and GPIO support to STMicrolectronic's
> STM32 family of MCUs.
>
> Pin muxing and GPIO handling have been tested on STM32F429
> based Discovery board.
>
> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
(...)
> +config PINCTRL_STM32
> + bool "STMicroelectronics STM32 pinctrl driver"
> + depends on OF
> + depends on ARCH_STM32 || COMPILE_TEST
> + select PINMUX
> + select PINCONF
> + select GPIOLIB_IRQCHIP
> + help
> + This selects the device tree based generic pinctrl driver for STM32.
Good start! Especially that you use GPIOLIB_IRQCHIP.
But this (as discussed earlier) should select GENERIC_PINCONF
Stopping review here so you can reengineer it a bit using GENERIC_PINCONF
for next submission.
Also think about pinmux in single registers, whether you want to do this
with a single value for a register or using strings to identify groups
and functions.
Yours,
Linus Walleij
next prev parent reply other threads:[~2015-03-06 9:24 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 18:00 [PATCH v2 00/18] Add support to STMicroelectronics STM32 family Maxime Coquelin
2015-02-20 18:01 ` [PATCH v2 01/18] scripts: link-vmlinux: Don't pass page offset to kallsyms if XIP Kernel Maxime Coquelin
2015-02-20 18:01 ` [PATCH v2 02/18] ARM: ARMv7M: Enlarge vector table to 256 entries Maxime Coquelin
2015-02-20 19:47 ` Uwe Kleine-König
2015-02-23 10:33 ` Maxime Coquelin
2015-02-26 10:29 ` Maxime Coquelin
2015-02-26 10:43 ` Uwe Kleine-König
2015-03-09 0:29 ` Stefan Agner
2015-03-09 17:12 ` Maxime Coquelin
2015-02-20 18:01 ` [PATCH v2 03/18] dt-bindings: Document the ARM System timer bindings Maxime Coquelin
2015-02-20 18:01 ` [PATCH v2 04/18] clocksource: Add ARM System timer driver Maxime Coquelin
2015-02-20 19:54 ` Uwe Kleine-König
2015-02-20 21:48 ` Paul Bolle
2015-03-02 16:53 ` Maxime Coquelin
2015-03-03 19:43 ` Paul Bolle
2015-03-04 12:08 ` Maxime Coquelin
2015-03-09 21:12 ` Paul Bolle
2015-03-09 22:17 ` Uwe Kleine-König
2015-03-09 15:50 ` Linus Walleij
2015-03-09 17:00 ` Maxime Coquelin
2015-02-20 18:01 ` [PATCH v2 05/18] reset: Add reset_controller_of_init() function Maxime Coquelin
2015-03-10 15:00 ` Arnd Bergmann
2015-03-10 15:28 ` Maxime Coquelin
2015-03-10 20:19 ` Arnd Bergmann
2015-03-10 21:30 ` Rob Herring
2015-03-12 21:08 ` Maxime Coquelin
2015-02-20 18:01 ` [PATCH v2 06/18] dt-bindings: Document the STM32 reset bindings Maxime Coquelin
2015-02-20 18:01 ` [PATCH v2 07/18] drivers: reset: Add STM32 reset driver Maxime Coquelin
2015-03-10 15:02 ` Arnd Bergmann
2015-03-10 15:41 ` Maxime Coquelin
2015-03-10 15:44 ` Maxime Coquelin
2015-03-10 20:21 ` Arnd Bergmann
2015-03-10 21:20 ` Maxime Coquelin
2015-03-11 13:08 ` Philipp Zabel
2015-03-12 21:05 ` Maxime Coquelin
2015-02-20 18:01 ` [PATCH v2 08/18] dt-bindings: Document the STM32 timer bindings Maxime Coquelin
2015-02-20 18:01 ` [PATCH v2 09/18] clockevent: Add STM32 Timer driver Maxime Coquelin
2015-02-20 18:01 ` [PATCH v2 10/18] dt-bindings: Document the STM32 pin controller Maxime Coquelin
2015-03-06 9:12 ` Linus Walleij
2015-03-06 9:35 ` Linus Walleij
2015-02-20 18:01 ` [PATCH v2 11/18] pinctrl: Add pinctrl driver for STM32 MCUs Maxime Coquelin
2015-03-06 9:24 ` Linus Walleij [this message]
2015-03-06 9:57 ` Maxime Coquelin
2015-03-10 15:08 ` Arnd Bergmann
2015-03-18 1:08 ` Linus Walleij
2015-02-20 18:01 ` [PATCH v2 12/18] dt-bindings: Document the STM32 USART bindings Maxime Coquelin
2015-03-10 15:08 ` Arnd Bergmann
2015-03-10 15:45 ` Maxime Coquelin
2015-02-20 18:01 ` [PATCH v2 13/18] serial: stm32-usart: Add STM32 USART Driver Maxime Coquelin
2015-02-20 18:01 ` [PATCH v2 14/18] ARM: Add STM32 family machine Maxime Coquelin
2015-02-20 18:33 ` Peter Meerwald
2015-02-25 11:52 ` Maxime Coquelin
2015-02-20 20:00 ` Uwe Kleine-König
2015-02-20 21:37 ` Paul Bolle
2015-02-25 12:04 ` Maxime Coquelin
2015-02-25 12:03 ` Maxime Coquelin
2015-03-10 15:10 ` Arnd Bergmann
2015-02-20 18:01 ` [PATCH v2 15/18] ARM: dts: Add ARM System timer as clockevent in armv7m Maxime Coquelin
2015-02-20 18:01 ` [PATCH v2 16/18] ARM: dts: Introduce STM32F429 MCU Maxime Coquelin
2015-03-02 17:42 ` Andreas Färber
2015-03-03 17:59 ` Maxime Coquelin
2015-03-09 14:39 ` Linus Walleij
2015-03-09 16:51 ` Maxime Coquelin
2015-02-20 18:01 ` [PATCH v2 17/18] ARM: configs: Add STM32 defconfig Maxime Coquelin
2015-02-20 18:01 ` [PATCH v2 18/18] MAINTAINERS: Add entry for STM32 MCUs Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbuJ5B_GwvRXax2Y4V37ihh5e6H7=2no0fYTMZPXwDdCw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).