From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA179C00A89 for ; Thu, 5 Nov 2020 09:22:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19A2F20825 for ; Thu, 5 Nov 2020 09:22:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wCU9bpc3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Jgn4flcD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19A2F20825 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2ucg2yw6I7bVciy20rtUBVmzlAZTPNV45njfc3LwZC4=; b=wCU9bpc3vMoFHAwQzA99w4066 RCnm7rNax4P7QXntQpiZShuYwve3pxZEsTmC4wItSBDw4uxlNMcdxRvmM0HRy0Wky7hNtqv3MG16n 4MtdaqA3hgedwIl0Sh/+gxUToI0m6Ib/RGy9hr5NDNUz574L/v+iHo6dwp1XDgQHlI/nc3y4UnP+w 5kbVg3iY22UB2/uyYliPlKh+ERgMWx0GcAJQmoabYfmNvEOr7FWxZ6txXZ/HiCQ9ZwwZiczuBt96z Ovvj8sROSp5FoWThrAF6+uRHrrDO3xQJo7hqkEbnpxkNsxihRDyf0lldVZDo6ig0661QLvPJCtR39 BkWk8+fUg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kabSj-0001vX-52; Thu, 05 Nov 2020 09:21:45 +0000 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kabSf-0001uI-Df for linux-arm-kernel@lists.infradead.org; Thu, 05 Nov 2020 09:21:42 +0000 Received: by mail-lf1-x141.google.com with SMTP id e27so1259777lfn.7 for ; Thu, 05 Nov 2020 01:21:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MLqSXCNezt+6aLqOTtVwOIFeRl7Xe1AvGFzo3fYe1IY=; b=Jgn4flcDwaM4mzljPuY4s4pB7iP2cuTWB5VKgui315qkRuy92cPfVJ/shvssIW9x54 ot3qVvePuzmxXvqWwA9M1JCEWi58AHdtLSTwHA8QV/5i1MmA27VBu9rus5CeT/CaOZV8 6A+F8/YOOm+6m2YzWCu5jnOZWbHIj7S46XpDNGyQYH5CxLEiu2+M9jmw3lnBcs8hnmwV /yYVTHgHb6O2DZIQxxp12BQZLIG2M9n00OKf3BYP+g+tj+PbS4wHlOsaF/ocmoCThCJb z9m5vcykgPY2noV1am3wjgeLAJJOYclMBzpvO6QAlprivTLPtOaK24UYWrrJ2FIFol32 0JuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MLqSXCNezt+6aLqOTtVwOIFeRl7Xe1AvGFzo3fYe1IY=; b=kX507PnYBNkYEv43CBEyd3QYLZJA3dR3EzjhAgXRH7XVe6qUKCjXVKUYLXbpK0ez6S j2nDAFxjp/F7N69/8xkDfFYZbMy3CnPUY6mfHVpxG2qW2OPGDRW5NK/89w2x/sa0z0L2 tMbdmG8Hzm9TM/5rnVEEaAmbmVafLwdWFtPXIK1rOlOe7epLzmv17GIcYldMxmK9IKKO 7pqC/ZvCcrW7uIVyhx9BWcBALIIfWOS2c/IzSuHo671XYTwNENIjsJYvEHN3wKbMr48N 5nJquzcn2ymbrd5QMtVD1j/WW5xQTUuaRydTSYOY6RVjKHfUd+6fEKPmJosO0+QhQV6F FiNQ== X-Gm-Message-State: AOAM530pj2NW7Td1dErhkxhBkR7m3ew21wzkuMT33dqruE9Vlcnjvyiu +XCZdhWg636SkErZ3xYJnDFTeqwQ+sXOYf9ibcl/cw== X-Google-Smtp-Source: ABdhPJyIx15IqdB1NPA4Sazq74uSIewpcq3AMgBd0y4Lv2GKOeKDnGro5f8DkvKwJhJ7plUKGIKFbEhFk80IWVCFJr8= X-Received: by 2002:a05:6512:322d:: with SMTP id f13mr567603lfe.571.1604568098468; Thu, 05 Nov 2020 01:21:38 -0800 (PST) MIME-Version: 1.0 References: <20201011024831.3868571-1-daniel@0x0f.com> <20201011024831.3868571-4-daniel@0x0f.com> In-Reply-To: From: Linus Walleij Date: Thu, 5 Nov 2020 10:21:27 +0100 Message-ID: Subject: Re: [PATCH 3/5] gpio: msc313: MStar MSC313 GPIO driver To: Daniel Palmer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201105_042141_533580_382AFFE1 X-CRM114-Status: GOOD ( 16.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , Linux ARM , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 21, 2020 at 1:07 PM Daniel Palmer wrote: > Sorry to pester you again... Don't worry. I'm more worried that my replies are slow. > Before I do that I have a question that maybe you could help me with: > Andy noted a few times that I have this driver as a built in driver > and not a module. > The gpio-ixp4xx.c driver is also a built in driver. Is there a reason > why it's ok there but not this driver? Not that I know of. There is a lot of push for modularization right now because Android (and other distributions) likes it, so if your SoC could be used by Android or Fedora or Debian etc it is generally a good idea to modularize. These distributions use the generic ARM (etc) kernel and try to load as many drivers as possible as modules. It is not always possible because some GPIOs might be needed very early, such as on-chip GPIO. So you better make sure that the platform can get to userspace also without this driver compiled in, otherwise it *MUST* be bool so people don't get ammunition to shoot themselves in the foot and configure a non-bootable kernel just because they could modularize this driver. If your SoC is only used by OpenWrt (like ixp4xx) then it is fine to just use bool because that distribution is always built with an image for a specific hardware, whereas distributions are generic. So it actually depends a bit on the usecase of the SoC. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel