From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 122C6C4363A for ; Wed, 28 Oct 2020 10:57:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 573A024691 for ; Wed, 28 Oct 2020 10:57:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tk+lgRSY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="EchNxfjW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 573A024691 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=O92fcs59kNi0xYRKyyMU3elfexA6TAY7NtsuyI6i5tg=; b=tk+lgRSY4O6lASjvn3lca3QrU bC0tx7nLdxwfpsxapJKBGGzpihRx9/csSIVMGDlnnWWvqTUkf00cOYWFPdODAmnpLz7jJe+1gobJK WDGQ1lqot5e14AjejlnB1jnGeTmLFaVxtDQs9kUyxxnCzjzQn3qIvXdiqM24xQ4jaMsEoWNPopdNp bd7/YjYvJRRn5mF7ub6oWfcI2uemhfbDooD1AkiQTy+3snsQpnIwXjjOa7SP8J9j0rDhsIoCG00gD x/mWGC8QrRpSwdOZZ7N2C5wHL1PV1gOswtc9HbNLcHperrYXAcWeyWvmCjLCChnZ5eH3lQ5JnEAvu +s0iJxlpg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXj7k-0002fn-Qv; Wed, 28 Oct 2020 10:56:12 +0000 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXj7i-0002eo-Ai for linux-arm-kernel@lists.infradead.org; Wed, 28 Oct 2020 10:56:11 +0000 Received: by mail-qt1-x841.google.com with SMTP id h19so3161441qtq.4 for ; Wed, 28 Oct 2020 03:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hsdkNzdMfWbXcZddXcT8aNBIhrkn1PkorkEU1qPCnjs=; b=EchNxfjWzAUq7C9Ti1qSHxWy2ojph/urHy60IprjNwVnnSHv7akwPxW+W2Gw79lVrr LBbC8gDgPCvGF57RQQ7Dilxntcq9QqyIP0hw2I5p0AViyp/dUDzvzA5xOrfpTbIi8+Qs 8Pv9zi0mH6SAJpljfdLeMgoLkyH3mGsakv8Kcc5zmt0yfZS1SpaQeUwLVrsH5fzsd3lK iYnLuOdfZavOXph0Z9SmP8/S8UV6MpNMXLcVwfU4LL/RUeKjJ9nav4TIpS8wHWRitI4c PUHVbQ/ww+WTSzqXxmoctill4YXA+t3xUpvV5z1XlFCEzqqmEpb3ZFVcqJbJBMMB3X83 nFTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hsdkNzdMfWbXcZddXcT8aNBIhrkn1PkorkEU1qPCnjs=; b=S5ZFa/Ym0InOz1d/IfhZT5NCJ6tjOj9qOy5/VEi0g+zM5B0uhDY85f9MiyiZVJwwFi uX6aVilhB6sV9UAR4gbxp9OoQxDz389dCLzSpHFpFd3Iq0+kotr17prP7pSSYAe+jKdC Wl2m+dlwsCzUsjiy3u2Kfnu35B8PVObG8rXTmgIteV3OG9gGPlh77X+jp82IsJO6W2uC 5g/dXKIGKBH67j/pQoeM9wruUiKzTvlkCyOGREjtNhZPFQVWRtZpSSvm6h/8k/d5Ka25 +cMZsk32JHwQVh+blQbkStLsxOy6orqeQnq1dgEmbeVxxweNF+7C7bI0m37aThgcX15R fl4g== X-Gm-Message-State: AOAM531ntlh1DZ5SbLst/uGtiBHVOOxmqyF7YkB+Vtnn0xfc9Nlpsc2C QuUtNoObvVxC94GYothXSodab9mEPTUqfwM34JdlDA== X-Google-Smtp-Source: ABdhPJydQ3JF4RJPCBrrrnsibfOQNjmnkH8RvdYTDaT4t9agLmajW2JLdDceJKZXK/JBoej4wJGe7HarOCof+hiFJhU= X-Received: by 2002:ac8:6c54:: with SMTP id z20mr6093592qtu.337.1603882568390; Wed, 28 Oct 2020 03:56:08 -0700 (PDT) MIME-Version: 1.0 References: <1d87f0d5a282d9e8d14d408ac6d63462129f524c.1603372719.git.andreyknvl@google.com> In-Reply-To: <1d87f0d5a282d9e8d14d408ac6d63462129f524c.1603372719.git.andreyknvl@google.com> From: Dmitry Vyukov Date: Wed, 28 Oct 2020 11:55:57 +0100 Message-ID: Subject: Re: [PATCH RFC v2 07/21] kasan, arm64: move initialization message To: Andrey Konovalov X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201028_065610_401974_E75E348A X-CRM114-Status: GOOD ( 19.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marco Elver , Elena Petrova , Linux-MM , Catalin Marinas , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev , LKML , Kostya Serebryany , Alexander Potapenko , Linux ARM , Serban Constantinescu , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Peter Collingbourne , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 22, 2020 at 3:19 PM Andrey Konovalov wrote: > > Tag-based KASAN modes are fully initialized with kasan_init_tags(), > while the generic mode only requireds kasan_init(). Move the > initialization message for tag-based modes into kasan_init_tags(). > > Also fix pr_fmt() usage for KASAN code: generic mode doesn't need it, Why doesn't it need it? What's the difference with tag modes? > tag-based modes should use "kasan:" instead of KBUILD_MODNAME. With generic KASAN I currently see: [ 0.571473][ T0] kasan: KernelAddressSanitizer initialized So KBUILD_MODNAME somehow works. Is there some difference between files? > Signed-off-by: Andrey Konovalov > Link: https://linux-review.googlesource.com/id/Idfd1e50625ffdf42dfc3dbf7455b11bd200a0a49 > --- > arch/arm64/mm/kasan_init.c | 3 +++ > mm/kasan/generic.c | 2 -- > mm/kasan/hw_tags.c | 4 ++++ > mm/kasan/sw_tags.c | 4 +++- > 4 files changed, 10 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c > index b6b9d55bb72e..8f17fa834b62 100644 > --- a/arch/arm64/mm/kasan_init.c > +++ b/arch/arm64/mm/kasan_init.c > @@ -290,5 +290,8 @@ void __init kasan_init(void) > { > kasan_init_shadow(); > kasan_init_depth(); > +#if defined(CONFIG_KASAN_GENERIC) > + /* CONFIG_KASAN_SW/HW_TAGS also requires kasan_init_tags(). */ A bit cleaner way may be to introduce kasan_init_early() and kasan_init_late(). Late() will do tag init and always print the message. > pr_info("KernelAddressSanitizer initialized\n"); > +#endif > } > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > index de6b3f03a023..d259e4c3aefd 100644 > --- a/mm/kasan/generic.c > +++ b/mm/kasan/generic.c > @@ -9,8 +9,6 @@ > * Andrey Konovalov > */ > > -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > - > #include > #include > #include > diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c > index 0128062320d5..b372421258c8 100644 > --- a/mm/kasan/hw_tags.c > +++ b/mm/kasan/hw_tags.c > @@ -6,6 +6,8 @@ > * Author: Andrey Konovalov > */ > > +#define pr_fmt(fmt) "kasan: " fmt > + > #include > #include > #include > @@ -18,6 +20,8 @@ > void __init kasan_init_tags(void) > { > init_tags(KASAN_TAG_MAX); > + > + pr_info("KernelAddressSanitizer initialized\n"); > } > > void *kasan_reset_tag(const void *addr) > diff --git a/mm/kasan/sw_tags.c b/mm/kasan/sw_tags.c > index bf1422282bb5..099af6dc8f7e 100644 > --- a/mm/kasan/sw_tags.c > +++ b/mm/kasan/sw_tags.c > @@ -6,7 +6,7 @@ > * Author: Andrey Konovalov > */ > > -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > +#define pr_fmt(fmt) "kasan: " fmt > > #include > #include > @@ -41,6 +41,8 @@ void __init kasan_init_tags(void) > > for_each_possible_cpu(cpu) > per_cpu(prng_state, cpu) = (u32)get_cycles(); > + > + pr_info("KernelAddressSanitizer initialized\n"); > } > > /* > -- > 2.29.0.rc1.297.gfa9743e501-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel