From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BDC7C433DB for ; Tue, 16 Feb 2021 18:17:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23BFB614A7 for ; Tue, 16 Feb 2021 18:17:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23BFB614A7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AKoMphZxwJhwNoI+gLF7+Q0wR+Zc26PdHqGCt1pueWo=; b=WqLg5SuCOOMD67c084RhpgpJh P0urCkYXOaePCWPTeId2b3a0mxCba9tMmr652FF1SS6IWUdrteCqtoy2fJbDLvGCQWfAhEXyw/2mn IDYSVMLICWWvUnQQQh5YBQYh7viHCi14oGjETD80bdP3BjSYUQCqgW9DBFVZDSPv28KrgUj5WnVgt cVD+Q/d2+HIWktzSoafpr9A84KpdugEXsfpc6jzeVpaCIM0f9a9LAIlpMrQ43rVX9FFKqexwwIKVG TYp+YDuI0elwkgtZHZ3Ez/Y8G/5PYr1KHguv9etIDivN44ZTgsWg8Yx/0hhLJ5KxzvNsMQWoUl1kN cwzXRiv9g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lC4sd-0005KQ-84; Tue, 16 Feb 2021 18:15:23 +0000 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lC4sZ-0005Jl-WB for linux-arm-kernel@lists.infradead.org; Tue, 16 Feb 2021 18:15:21 +0000 Received: by mail-qk1-x72f.google.com with SMTP id f17so10313478qkl.5 for ; Tue, 16 Feb 2021 10:15:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TIaOcjadSpBzzJCMnARKl1ZXAgu2yuZpBTm/4wzkXqs=; b=bUK55NBg5Uh81hVcSU2sx1CX7JZR04xf76FPXqIDHyXehqyY+Zi1t+aliIoc/R5e9n 1joKE4tLAiSsbda18uhNJUsQXDlVmCaDe5LQSoBHbUyMpg77caNQ5W1ra4dKhaDZBktx VPJxl8d9MSR5AiuIsbMihyOpi7z1uhO7E5X1FlIYnQEyqGxuwfODwFoLCYY0wiHDv0tZ BjGXEOU9v4skzIhJX/4FwlXpHP9O0gJaA1Nk1bip/oEhnJPqaCYK9wTYhui/kwJ2gMnB L3yPj7cgrwYoZzgVPIY8k4QeZN0B6q8nVoYwZMFUyo1dOlfxRk5zhJf9+y1OIl75SS9u 6Wmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TIaOcjadSpBzzJCMnARKl1ZXAgu2yuZpBTm/4wzkXqs=; b=rXOOs3eKvDS16JhSO0aVV6fwjeBrn6xL4+09aSe7XCoXqg0QOqdEXQ5rpKDeKwgjSk A8lnIOiAMk9iit2MJT7d5U43dmGQmaMs7iCKtEkveBa5ZHkNMccxrhFp20ioJRG1aTtc lKOduu7de7is/vcIos8qEa4Jn0d/d0x0Gz2HCX3tC/MONyB9F71su09M4Kd0FewDtYE8 nOcwWt24fN7DtxR1AJN+V6r9rQFeW9lUtEj7wjf2BS0+ZCANVcPbDQTPpL+B4D79Gc8X PvSDVm+LUZ+UDMHK8D6ZZnPhAE9Xb+qLJYiSBELUSOh9wqhixu1SLI8YcDdnGzyiXpR/ fLDw== X-Gm-Message-State: AOAM533wxx1ma09NA9o3QRdOyVzXG7OT9OJ/pL87uZJG/ZgDbRX4ppId Q8FLSb9EvwECcOr1fXGzHeEwLo2WG1QKKh3ujs6OWQ== X-Google-Smtp-Source: ABdhPJx9CBWtac4HspbzcTYOQ1TnC76W0LcibcCfR7hsLxW0NwuUWBBzvVZcKgqQObAoTPTG+lZGt0bHLSm2KXN0I7Q= X-Received: by 2002:a05:620a:1351:: with SMTP id c17mr21197159qkl.350.1613499315616; Tue, 16 Feb 2021 10:15:15 -0800 (PST) MIME-Version: 1.0 References: <0000000000000be4d705bb68dfa7@google.com> <20210216172817.GA14978@arm.com> <20210216180143.GB14978@arm.com> In-Reply-To: <20210216180143.GB14978@arm.com> From: Dmitry Vyukov Date: Tue, 16 Feb 2021 19:15:04 +0100 Message-ID: Subject: Re: KASAN: invalid-access Write in enqueue_timer To: Catalin Marinas , Eric Dumazet X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210216_131520_109715_C073A165 X-CRM114-Status: GOOD ( 21.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "Jason A. Donenfeld" , Kees Cook , Netdev , syzkaller-bugs , LKML , Mark Brown , syzbot , mbenes@suse.cz, Will Deacon , Ard Biesheuvel , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 16, 2021 at 7:01 PM Catalin Marinas wrote: > > On Tue, Feb 16, 2021 at 06:50:20PM +0100, Jason A. Donenfeld wrote: > > On Tue, Feb 16, 2021 at 6:46 PM Jason A. Donenfeld wrote: > > > On Tue, Feb 16, 2021 at 6:28 PM Catalin Marinas wrote: > > > > > hlist_add_head include/linux/list.h:883 [inline] > > > > > enqueue_timer+0x18/0xc0 kernel/time/timer.c:581 > > > > > mod_timer+0x14/0x20 kernel/time/timer.c:1106 > > > > > mod_peer_timer drivers/net/wireguard/timers.c:37 [inline] > > > > > wg_timers_any_authenticated_packet_traversal+0x68/0x90 drivers/net/wireguard/timers.c:215 > > > > > > The line of hlist_add_head that it's hitting is: > > > > > > static inline void hlist_add_head(struct hlist_node *n, struct hlist_head *h) > > > { > > > struct hlist_node *first = h->first; > > > WRITE_ONCE(n->next, first); > > > if (first) > > > > > > So that means it's the dereferencing of h that's a problem. That comes from: > > > > > > static void enqueue_timer(struct timer_base *base, struct timer_list *timer, > > > unsigned int idx, unsigned long bucket_expiry) > > > { > > > > > > hlist_add_head(&timer->entry, base->vectors + idx); > > > > > > That means it concerns base->vectors + idx, not the timer_list object > > > that wireguard manages. That's confusing. Could that imply that the > > > bug is in freeing a previous timer without removing it from the timer > > > lists, so that it winds up being in base->vectors? > > Good point, it's indeed likely that the timer list is messed up already, > just an unlucky encounter in the wireguard code. > > > Digging around on syzkaller, it looks like there's a similar bug on > > jbd2, concerning iptunnels's allocation: > > > > https://syzkaller.appspot.com/text?tag=CrashReport&x=13afb19cd00000 > [...] > > It might not actually be a wireguard bug? > > I wonder whether syzbot reported similar issues with > CONFIG_KASAN_SW_TAGS. It shouldn't be that different from the HW_TAGS > but at least we can rule out qemu bugs with the MTE emulation. +Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel