From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6877AC433DB for ; Thu, 11 Mar 2021 17:27:20 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE9CB64DEC for ; Thu, 11 Mar 2021 17:27:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE9CB64DEC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5qPf7uv3JvTSs0dc3kYQC0jMi15vDCfzWjOcHaIZKCE=; b=Y0MuJBLZxzTN7Jlz73Hi6G8zL cVlbj1sTkjHOVVBMIM7pWnTOUBe1RNj4DiY4f2lbm4VzRH5pl++8IGMJGKXzhooOtHxJM40+dxa58 VSnHDXHUFgRyVfxSrU5S7Rz0GTImWwogihGBEOHmBAJMhSNIaFsbIXTTEhKOTEvcyrsz2HVlu1/X0 I9E1NZq1IjEn2WaCVX8aTbqDoucZBBU+qX8TnmL7C06oTmZYCOVRb6P+2qwux/tWY4T93ZHo4okF9 zowBbYGtZpVfOmpvXsakpTYrHOlYQOX5n8Ex4mTo0KUH8XNyJGO7PHDHePbddl8HQZ8+XmHt4SxsM sxoCWJxDg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKP4E-009id3-R7; Thu, 11 Mar 2021 17:25:46 +0000 Received: from mail-qv1-xf33.google.com ([2607:f8b0:4864:20::f33]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKP48-009ibh-H8 for linux-arm-kernel@lists.infradead.org; Thu, 11 Mar 2021 17:25:43 +0000 Received: by mail-qv1-xf33.google.com with SMTP id h13so2908296qvu.6 for ; Thu, 11 Mar 2021 09:25:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tP/tKiRNygeIpzt+sV7itRbtILpJcSCyB6twSViOA+A=; b=R/ae6g94KiIc1VaUlUYIsfgPSfpNMge4KqOnAo7ay5Glz8UakGrRaXnUsvGrbkHLjF 4O787Oga/UaaFlpFglyH0h1/L3Sqhd6YjA/4DrRerj8Tz8KynrNcE3Lgj0Zk24lbjwH8 0r2L5Rxzn2GyCcJh4EEtblT9GGUbIXmz3/1mIElecJpcrzzkHPgbrSeSkOa57Lc1Yzv7 EV/PBE4F5d7KF2SXqneJ1CBXxSGhWtPgkfpGGsMLLVMIPSrZKue+FEWRJWYC25vqSv9k 22rs9IuWkYRqoOOliTM5K/F6CwAVzxaDufvC15hc9tBKq1ClT5wAhSmKfPzdqzLyW4NK jmhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tP/tKiRNygeIpzt+sV7itRbtILpJcSCyB6twSViOA+A=; b=KbwlACKA4ifRNa5GxGN8l+5aw1RhZePNC/TR0oRhqD6wruJUkieuoFNdDEse79kM8B 5v+ZjYdNeQiahl2ekpNDFHEO20ARzddLQavlN/BsxlOZ2X5l4t/hVm2M7zN28y5/gW8k OgJi8touuz4iX68tXqMk/fQDyDxSBT5TCzUMLra1bxkLj269JORB0OZ3RAsmUgOTmeN8 YHsAqjysYvyRf0ftoZmBE7fWoBcxPd+FVpuiDukuBJkWwMmxQeiOLxux4RaEhmNrcsrR a1pI0qKHuTDlXPLE9/q/F4g3NU5S1EcmckfE8stT0g1M+LmsfTvmodhbVXIRqTpWn48g nFfA== X-Gm-Message-State: AOAM532P/qGrnrbSCbWOOghq9xMK4MeiOK0jZzhqA73blHdj2IvjkHuY 01IUeIozaDyR2UBnJx+Yf+XGwJNeHcBnz7irsUmWgw== X-Google-Smtp-Source: ABdhPJzZYvLF863xU5IO1BcearQqPvN74V47caCVN6R8NwmwrDX9JnyA8PSsZPtPI2FX1hdLI1UHh0mrgSRr/Vqy4JM= X-Received: by 2002:a05:6214:1870:: with SMTP id eh16mr8491532qvb.23.1615483537555; Thu, 11 Mar 2021 09:25:37 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dmitry Vyukov Date: Thu, 11 Mar 2021 18:25:26 +0100 Message-ID: Subject: Re: arm64 syzbot instances To: Arnd Bergmann Cc: Mark Rutland , Marc Zyngier , Will Deacon , Ard Biesheuvel , Linux ARM , syzkaller , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210311_172541_336652_D7266133 X-CRM114-Status: GOOD ( 20.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 11, 2021 at 2:30 PM Arnd Bergmann wrote: > > On Thu, Mar 11, 2021 at 12:38 PM Dmitry Vyukov wrote: > > > > The instances found few arm64-specific issues that we have not > > observed on other instances: > > I've had a brief look at these: > > > https://syzkaller.appspot.com/bug?id=1d22a2cc3521d5cf6b41bd6b825793c2015f861f > > This one doesn't seem arm64 specific at all. While the KASAN report has shown > up on arm64, the link to > https://syzkaller.appspot.com/bug?id=aa8808729c0a3540e6a29f0d45394665caf79dca > seems to be for x86 machines running into the same problem. You are right. It's probably a consequence of some configs being enabled. I think we need to enable CONFIG_FW_LOADER_USER_HELPER on x86_64 upstream instances as well. > Looking deeper into the log, I see that fw_load_sysfs_fallback() finds > an existing > list entry on the global "pending_fw_head" list, which seems to have been freed > earlier (the allocation listed here is not for a firmware load, so presumably it > was recycled in the meantime). The log shows that this is the second time that > loading the regulatory database failed in that run, so my guess is that it was > the first failed load that left the freed firmware private data on the > list, but I > don't see how that happened. Can it be as simple as: fw_load_sysfs_fallback adds fw to the pending list, but then returns with an error w/o removing it from the list? There are some errors checks after that: https://elixir.bootlin.com/linux/v5.12-rc2/source/drivers/base/firmware_loader/fallback.c#L536 and it seems that the caller deletes fw in this case: https://elixir.bootlin.com/linux/v5.12-rc2/source/drivers/base/firmware_loader/main.c#L839 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel