From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9775C4363A for ; Mon, 5 Oct 2020 17:44:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 491E3207BC for ; Mon, 5 Oct 2020 17:44:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NBtu5LH6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bcrPOG5W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 491E3207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NnVjlCQcE4D/1kvfXonKKepXPoUKCFRI+6QYAH4ufmQ=; b=NBtu5LH6BeKV7adWyw9s0a3SF 10sqa+y76cSea67d4O94R3jS4kDYNRxqL8mNS26sDtsDViBuTdA6Yx+Nmj6OteOIhtcqpzhxSkqeP nwnyozt7MPsMrhkSlmRRBjZFJaGrC8oik88SqUXdaHcLel85GAnHkRCZDUXhrE9LzBwSZplZMYGNW q3+wBIy19hXDRAHei4HGp1uliQ7rnPTJ/J5Ikr1rVI5QPzsSt+9vHRpNqu8pnlaZOMZUXyg2ihcLs 8oWAe+S9luZb5zrX+gPbT7w0unyir0bhMXngF4BpTX2dKzrNfW43YJfNV9v4CSCuyA4rIEtxbENnY TomoKy0HQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPUVZ-0001tJ-Uf; Mon, 05 Oct 2020 17:42:46 +0000 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPUVH-0001lM-0k for linux-arm-kernel@lists.infradead.org; Mon, 05 Oct 2020 17:42:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601919744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lTv8qVn50BVMe41mnHOhz5zFgfNAnMlsJzHtN4tUUYY=; b=bcrPOG5WzxlRbADGHmq3n7/I3sPoquZde/Zzy49TBoknUVzSSwVcLbuodKJKGU4IcairOE gRdMjICMonAVMPzeCQZcV09KiDueo64vaDvvFuMbC2WN+/y6JciB8q88q1yZK3IE7qzuDR EyLdN1K0VHn8PWvbul42RZ1ng8QG8tU= Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-416-xfseRzvKNV-VBqEDGusbjQ-1; Mon, 05 Oct 2020 13:42:23 -0400 X-MC-Unique: xfseRzvKNV-VBqEDGusbjQ-1 Received: by mail-ot1-f70.google.com with SMTP id t19so2763475otc.17 for ; Mon, 05 Oct 2020 10:42:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lTv8qVn50BVMe41mnHOhz5zFgfNAnMlsJzHtN4tUUYY=; b=Lqp/Ul9FT1M/oLWTuLHXYQvPncgF7l4sL2iWJzDGeZUsem/qEnHbZlDJyTxbRT/i+L laMU1qrFztTkuwfSNrN6bTYDkmmi9cm4SP1k1oRZEmS4EtdrB84LOgdfaLi8IVsb52Bk vyLGvKuWT/8shJJ73o+nd8srsNc8TaYIScLgSMNRaH71gwJxS6d2dk0npvbiANTdv4qK 51Nucwe6UPcSKllXJJdU/JeErkbuPl1zU8GCB52gC1nzLR65mZkxHPGecJD9HF8RaEne YhgDR7Uyna3dWI4QYuDNNw6mxWxIryPvBTbZ4ZVzIN8lrPPCheNzRgpLhlMMia19NYgY wXHQ== X-Gm-Message-State: AOAM531pwALat2pACAPFFZtG1Tw5omZs6yGZ1rp+mFN0XiNH8fuO+54Y z2or9O8pmq8r02MnYOeZhc9b6Ms02vqCZCSqugSHm5hC2xEOCxqtBiLVCV/+l4W3fgH7k39eZon NUlfhGYUhFw5Jn0sYsi6S7RUoLologir4m4kEhcJP2HFC19mMOEI= X-Received: by 2002:a9d:a24:: with SMTP id 33mr255757otg.305.1601919741901; Mon, 05 Oct 2020 10:42:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyUwdJyVHIEtrpCyi9x3L1lyrhCd75vZ9+/aBnXjciOlpkIe+CX5Y4ESH+Vq6Rhy3CxhWne8HCSfmc8OJPjzQc= X-Received: by 2002:a9d:a24:: with SMTP id 33mr255732otg.305.1601919741596; Mon, 05 Oct 2020 10:42:21 -0700 (PDT) MIME-Version: 1.0 References: <20200907134745.25732-1-chenzhou10@huawei.com> <20201005170937.GA14576@gaia> In-Reply-To: <20201005170937.GA14576@gaia> From: Bhupesh Sharma Date: Mon, 5 Oct 2020 23:12:10 +0530 Message-ID: Subject: Re: [PATCH v12 0/9] support reserving crashkernel above 4G on arm64 kdump To: Catalin Marinas Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=bhsharma@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201005_134227_127262_10A01630 X-CRM114-Status: GOOD ( 24.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wangkefeng.wang@huawei.com, Linux Doc Mailing List , Chen Zhou , huawei.libin@huawei.com, guohanjun@huawei.com, Will Deacon , Baoquan He , Jonathan Corbet , Ingo Molnar , RuiRui Yang , John Donnelly , Arnd Bergmann , xiexiuqi@huawei.com, Simon Horman , Thomas Gleixner , linux-arm-kernel , kexec mailing list , Linux Kernel Mailing List , Rob Herring , James Morse , Prabhakar Kushwaha , nsaenzjulienne@suse.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Catalin, Chen, On Mon, Oct 5, 2020 at 10:39 PM Catalin Marinas wrote: > > On Sat, Sep 12, 2020 at 06:44:29AM -0500, John Donnelly wrote: > > On 9/7/20 8:47 AM, Chen Zhou wrote: > > > Chen Zhou (9): > > > x86: kdump: move CRASH_ALIGN to 2M > > > x86: kdump: make the lower bound of crash kernel reservation > > > consistent > > > x86: kdump: use macro CRASH_ADDR_LOW_MAX in functions > > > reserve_crashkernel[_low]() > > > x86: kdump: move reserve_crashkernel[_low]() into crash_core.c > > > arm64: kdump: introduce some macroes for crash kernel reservation > > > arm64: kdump: reimplement crashkernel=X > > > kdump: add threshold for the required memory > > > arm64: kdump: add memory for devices by DT property > > > linux,usable-memory-range > > > kdump: update Documentation about crashkernel > [...] > > I did a brief unit-test on 5.9-rc4. > > > > Please add: > > > > Tested-by: John Donnelly > > Thanks for testing. > > > This activity is over a year old. It needs accepted. > > It's getting there, hopefully in 5.11. There are some minor tweaks to > address. I think my earlier email with the test results on this series bounced off the mailing list server (for some weird reason), but I still see several issues with this patchset. I will add specific issues in the review comments for each patch again, but overall, with a crashkernel size of say 786M, I see the following issue: # cat /proc/cmdline BOOT_IMAGE=(hd7,gpt2)/vmlinuz-5.9.0-rc7+ root=<..snip..> rd.lvm.lv=<..snip..> crashkernel=786M I see two regions of size 786M and 256M reserved in low and high regions respectively, So we reserve a total of 1042M of memory, which is an incorrect behaviour: # dmesg | grep -i crash [ 0.000000] Reserving 256MB of low memory at 2816MB for crashkernel (System low RAM: 768MB) [ 0.000000] Reserving 786MB of memory at 654158MB for crashkernel (System RAM: 130816MB) [ 0.000000] Kernel command line: BOOT_IMAGE=(hd2,gpt2)/vmlinuz-5.9.0-rc7+ root=/dev/mapper/rhel_ampere--hr330a--03-root ro rd.lvm.lv=rhel_ampere-hr330a-03/root rd.lvm.lv=rhel_ampere-hr330a-03/swap crashkernel=786M cma=1024M # cat /proc/iomem | grep -i crash b0000000-bfffffff : Crash kernel (low) bfcbe00000-bffcffffff : Crash kernel IMO, we should test this feature more before including this in 5.11 Thanks, Bhupesh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel