From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9170C433EF for ; Thu, 11 Nov 2021 23:50:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6781E61267 for ; Thu, 11 Nov 2021 23:50:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6781E61267 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7jXzxhgAqwuUazLoeDTbvagCKQKg0+BiPXJhBJPO8oU=; b=RE8Qsj6KbLP9Zd FgJttiB0H+ZXZ6LPH54E9WnUp3vIXYCSeFG84seFFI9+pG5Fey3MG8Pc+yFVAN/y8XyHl4MMNf8D9 ZSISFUFpB2xPtzWlc2md+kWyGYM8z0ruGZLDoFuKnpm3pSYBsOEJWDIh2gXX/+NCgYMd1llw/YLTD oavrzxBFv8innB1tiCDcT5UWm0ulzzC6Rb7lOpEK2L5+MoaEOwO5+PADDE8rSaxvrnEkcqW2UqT/0 mgbvSrbBFrfWNyMRevEYq43KDU/MVV0bnHsL7lRKdBkHKgibkS4QScR/J+R9f7bWZDCKFYcwlubcS 2m3lbMdVYIrfB6uN+GEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlJo3-008yXg-31; Thu, 11 Nov 2021 23:48:35 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlJnz-008yXK-KH for linux-arm-kernel@lists.infradead.org; Thu, 11 Nov 2021 23:48:33 +0000 Received: by mail-pj1-x1032.google.com with SMTP id fv9-20020a17090b0e8900b001a6a5ab1392so6086713pjb.1 for ; Thu, 11 Nov 2021 15:48:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0JJWVJalP8CdFuuTjj01mh7dvetDFFkhbScBxvOmImE=; b=eSPxiY6MEyQX62rXAkb0w5NNZxOWa7d9ff+SnhlWhS0oTPRJBa2CcaipLWPc0J0gKP l053mItULP8bYA7RJDTqKIuh/aUAXRYJq7/ITIAGvRYRnTF+9kbGLe7DBD/rhP/0a1Em gAQFu3Lzm+26xVXYz2R/xCLPJIf1sko7Ns7Jc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0JJWVJalP8CdFuuTjj01mh7dvetDFFkhbScBxvOmImE=; b=lvmqejJn6cW9opu+0jDU6iiQuDCbWxy2bt33DNJr2g1LsXuorEoPtmA/GT3PRwuUHh 9229M64DkBSe+Sb7Xmc2n0HivX+4gbwTwi5Qlyev8XuO+v65B9W8bbqjR+mNMlBPa824 8LsU96NZ2SoiODKtzBooFVOOYY0kCsbpozAZ6wrKw45am0RQyxeWvjMyc4YIJWHSLKxb gA/wKsVWRhYn7k1/K+e4tC6PDyJyojt6FSuqjHlbeq3R/+uselTA9X8gCDsLYj0V5njh ewcASG9FaaHSuRX9067s0OmvuF+sKbEe8GV5BwdFMLyGatSBMz7+YGn17pSCvcEScOlK hyyg== X-Gm-Message-State: AOAM533EdxjDkWFxUBNCumlm0e0XWJj8aoYpNI8OUBLK7t/MM6ubx5oy YmrAHE6hIfCqlnf7+yXVrWySZDIGj+oY8Q== X-Google-Smtp-Source: ABdhPJxMnOMhZcE3dCQqg3MDg6PEROoZrTFFCiSkiDzchBxTIkzRhCG7Z3/XylpcFzUJZVJhM5GRuw== X-Received: by 2002:a17:902:e548:b0:141:f4ae:d2bd with SMTP id n8-20020a170902e54800b00141f4aed2bdmr3392675plf.41.1636674509157; Thu, 11 Nov 2021 15:48:29 -0800 (PST) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com. [209.85.210.176]) by smtp.gmail.com with ESMTPSA id d2sm4354838pfj.42.2021.11.11.15.48.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Nov 2021 15:48:29 -0800 (PST) Received: by mail-pf1-f176.google.com with SMTP id n85so6887207pfd.10 for ; Thu, 11 Nov 2021 15:48:28 -0800 (PST) X-Received: by 2002:a05:6e02:1a67:: with SMTP id w7mr6255484ilv.165.1636674497968; Thu, 11 Nov 2021 15:48:17 -0800 (PST) MIME-Version: 1.0 References: <20210813195228.2003500-1-mka@chromium.org> <20210813125146.v16.5.If248f05613bbb06a44eb0b0909be5d97218f417b@changeid> In-Reply-To: <20210813125146.v16.5.If248f05613bbb06a44eb0b0909be5d97218f417b@changeid> From: Doug Anderson Date: Thu, 11 Nov 2021 15:48:06 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v16 5/7] usb: Specify dependencies on USB_XHCI_PLATFORM with 'depends on' To: Matthias Kaehlcke Cc: Greg Kroah-Hartman , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , Felipe Balbi , devicetree@vger.kernel.org, Peter Chen , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Bastien Nocera , Ravi Chandra Sadineni , Michal Simek , Roger Quadros , Krzysztof Kozlowski , Stephen Boyd , Andrew Lunn , Aswath Govindraju , Dmitry Osipenko , Fabio Estevam , Gregory Clement , Krzysztof Kozlowski , Pawel Laszczak , Sebastian Hesselbarth , Tony Lindgren , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211111_154831_718009_62639354 X-CRM114-Status: GOOD ( 10.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Fri, Aug 13, 2021 at 12:52 PM Matthias Kaehlcke wrote: > > config USB_DWC3 > tristate "DesignWare USB3 DRD Core Support" > - depends on (USB || USB_GADGET) && HAS_DMA > - select USB_XHCI_PLATFORM if USB_XHCI_HCD > + depends on ((USB && USB_XHCI_PLATFORM) || USB_GADGET) && HAS_DMA Technically you don't need the "USB &&", right? Since USB_XHCI_PLATFORM is defined in 'usb/host/Kconfig' and that's only even included if USB is defined. So it can be just: depends on (USB_XHCI_PLATFORM || USB_GADGET) && HAS_DMA That's not terribly important, though, so: Reviewed-by: Douglas Anderson _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel