From: dianders@chromium.org (Doug Anderson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: enable init rate for clock
Date: Tue, 7 Oct 2014 10:03:19 -0700 [thread overview]
Message-ID: <CAD=FV=UNXUuJbRpECV0Ay0hR02Dg=rBw+XScvMdfngzWfCqp4w@mail.gmail.com> (raw)
In-Reply-To: <1412674438-26160-3-git-send-email-kever.yang@rock-chips.com>
Kever,
On Tue, Oct 7, 2014 at 2:33 AM, Kever Yang <kever.yang@rock-chips.com> wrote:
> We need to initialize PLL rate and some of bus clock rate while
> kernel init, for there is no other module will do that.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> arch/arm/boot/dts/rk3288.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 874e66d..2f4519b 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -455,6 +455,16 @@
> rockchip,grf = <&grf>;
> #clock-cells = <1>;
> #reset-cells = <1>;
> + assigned-clocks = <&cru PLL_GPLL>, <&cru PLL_CPLL>,
> + <&cru PLL_NPLL>, <&cru ACLK_CPU>,
> + <&cru HCLK_CPU>, <&cru PCLK_CPU>,
> + <&cru ACLK_PERI>, <&cru HCLK_PERI>,
> + <&cru PCLK_PERI>;
> + assigned-clock-rates = <594000000>, <400000000>,
> + <500000000>, <300000000>,
When I boot up, I see that ACLK_CPU was 297000000. You specified
300000000. Did you expect to get 300? If you expected 297, I think
you should put 297. If you expected 300 then we have some debugging
to do. Note: I'm not quite sure how you'd expect to get 300 given
that none of the PLLs divide evenly to 300...
> + <150000000>, <75000000>,
Similarly, I see 148500000, 74250000
> + <300000000>, <150000000>,
297000000, 148500000
> + <75000000>;
74250000
> };
>
> grf: syscon at ff770000 {
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-10-07 17:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 9:33 [PATCH 0/2] init some clock rate from dts for rk3288 Kever Yang
2014-10-07 9:33 ` [PATCH 1/2] clk: rockchip: add 400MHz and 500MHz for rk3288 clock rate Kever Yang
2014-10-07 16:56 ` Doug Anderson
2014-10-07 9:33 ` [PATCH 2/2] ARM: dts: enable init rate for clock Kever Yang
2014-10-07 17:03 ` Doug Anderson [this message]
2014-10-07 18:27 ` Heiko Stübner
2014-10-07 19:20 ` Doug Anderson
2014-10-07 19:37 ` Heiko Stübner
2014-10-07 21:10 ` Doug Anderson
2014-10-07 17:11 ` [PATCH 0/2] init some clock rate from dts for rk3288 Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=UNXUuJbRpECV0Ay0hR02Dg=rBw+XScvMdfngzWfCqp4w@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).