From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B8FDC433DB for ; Wed, 6 Jan 2021 01:38:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47BBF207AB for ; Wed, 6 Jan 2021 01:38:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47BBF207AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XmIY2sVW9FzRYYigTaPffwSam6ZPkqj9VHoLnXeZcpM=; b=rM9dYrpDJVEv9fdnX7BafQJ3l +JXQY0vrJI0mtYYTYPMtHkK2xcFIDOXNfn6lMSasFgkG6P0XifT1xitTPGl+oYpbqw25X4vcvDnMY 6tJ9zEXsW8kT++NiIwlMyDtJzu55hELdv5oBSCSs66ZfNyl+sqYSrBQatRtVgyzSl1xC99Oul4jva yj6E/gBy+GO+ltCjxtR1MUb8CHExsZRS2oWsUEuaCoCcP4f+oCu55W/1H8ZJamNKbUNQD3YPt5DSb wYm3iZffOkbXgID9hy7EkYyo4ggwlrdDA9ozGA/v6Ad3BzPyOl+5dazsSTRplcBcXUAhz3o15QMWT MJy5oa8TQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwxju-0002OU-GY; Wed, 06 Jan 2021 01:35:54 +0000 Received: from mail-qt1-x82d.google.com ([2607:f8b0:4864:20::82d]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwxjr-0002Nu-Iy for linux-arm-kernel@lists.infradead.org; Wed, 06 Jan 2021 01:35:52 +0000 Received: by mail-qt1-x82d.google.com with SMTP id z3so1177258qtw.9 for ; Tue, 05 Jan 2021 17:35:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8190Rw9nFurXvpyVpr5H2heqLA3Td/3zauNq8uzsNzM=; b=MKfJ7zGxTH1maYa7wKycTAhSCe7iU3Dy08HvTas4FA/zUjsnZ6Hjc05jcStbPpGZ/B g7TV1HRXxJ+RX79sAOjh9NV09M2ekhu2NPTSuTTHO9ncVhG+jBvzCjpGxG+wKMSgiOtu ZdPYyd4Chi2Xa6auJVV/rnzWGMTaQgVoK9zy0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8190Rw9nFurXvpyVpr5H2heqLA3Td/3zauNq8uzsNzM=; b=LZjcfkYI/gpB2xpKJghYv1LZPUI7PGWYiGorYegZ6mve5+Y04umrnjazGcrBwlG6ln HctjWaEGDXzNKGoXwrwi5NTDQQtvmG4erTdcXkmlqgStBNvB0B3zMIwojStYAQt/TlV/ 1cinV1n1sk28VeCmGCEaoTbiaHFu+u6J8lmacaKMeRX5xiSJWjThoVPDTh/1789ZVOy9 vFHTEo/L9a/d4bUQpbBQtf3UDgxnWWXdTBOM4tEpl56JsicKv7Dtbx9BGuuAO3Gdi6NP UPLsc5chAocZOmo/HBZAWDhCNqAoTH1s+RkvsAwRu5BDY+4azaA2NMxx15On8xZABB69 bSCg== X-Gm-Message-State: AOAM532R1wvbVthTYeOILsNxxm5T9C3n6GIIunOAJLP7baLDUHTRIbH2 fq3dGlKsUMKJ8tn/clw8R6zbxP1ZKqAtEA== X-Google-Smtp-Source: ABdhPJy4AmiRv7cSP8bCiPmJqxP0HctqyoRFUgCm+d0qH/jUA5C4sQpUvWvLnP7uFVyKgCGe0Lmw/g== X-Received: by 2002:ac8:488e:: with SMTP id i14mr2200831qtq.372.1609896947721; Tue, 05 Jan 2021 17:35:47 -0800 (PST) Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com. [209.85.219.182]) by smtp.gmail.com with ESMTPSA id a21sm642234qkb.124.2021.01.05.17.35.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jan 2021 17:35:47 -0800 (PST) Received: by mail-yb1-f182.google.com with SMTP id k4so1367800ybp.6 for ; Tue, 05 Jan 2021 17:35:46 -0800 (PST) X-Received: by 2002:ab0:2e99:: with SMTP id f25mr1914472uaa.104.1609896944481; Tue, 05 Jan 2021 17:35:44 -0800 (PST) MIME-Version: 1.0 References: <20201211222448.2115188-1-dianders@chromium.org> In-Reply-To: <20201211222448.2115188-1-dianders@chromium.org> From: Doug Anderson Date: Tue, 5 Jan 2021 17:35:33 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 0/4] HID: i2c-hid: Reorganize to allow supporting goodix, gt7375p To: Jiri Kosina , Benjamin Tissoires , Greg Kroah-Hartman , Dmitry Torokhov X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210105_203551_704816_F41B0422 X-CRM114-Status: GOOD ( 25.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geert Uytterhoeven , Catalin Marinas , =?UTF-8?Q?Guido_G=C3=BCnther?= , Bjorn Andersson , Kai-Heng Feng , Will Deacon , Anson Huang , Masahiro Yamada , Michael Walle , Linux ARM , "open list:HID CORE LAYER" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jiri Kosina , Stephen Boyd , Hans de Goede , Xiaofei Tan , Daniel Playfair Cal , Andrea Borgia , Max Krummenacher , LKML , Li Yang , Vinod Koul , Rob Herring , Shawn Guo , Pavel Balan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Benjamin, On Fri, Dec 11, 2020 at 2:24 PM Douglas Anderson wrote: > > The goal of this series is to support the Goodix GT7375P touchscreen. > This touchscreen is special because it has power sequencing > requirements that necessitate driving a reset GPIO. > > To do this, we totally rejigger the way i2c-hid is organized so that > it's easier to jam the Goodix support in there. > > This series was: > - Tested on a device that uses normal i2c-hid. > - Tested on a device that has a Goodix i2c-hid device. > - Tested on an ACPI device, but an earlier version of the series. > > I believe the plan is for Benjamin to land the whole series. Will > said this about the arm64 defconfig change (and provided his Ack): > > ...there are a few things I really care about > > in defconfig (e.g. things like page size!), generally speaking we don't > > need to Ack everything that changes in there. > > > > That said, might be worth checking whether arm-soc have any defconfig > > changes queued in -next so you don't end up with conflicts. > > Changes in v8: > - Mark suspend/resume as static as per patches robot. > > Changes in v7: > - Rebase atop commit afdd34c5fa40 ("HID: i2c-hid: show the error ...") > > Changes in v6: > - ACPI probe function should have been "static" > - Don't export suspend/resume, just export dev_pm_ops from core. > - Fixed crash in ACPI module (missing init of "client") > - No need for regulator include in the core. > - Removed i2c_device_id table from ACPI module. > - Suspend/resume are no longer exported from the core. > > Changes in v5: > - Add shutdown_tail op and use it in ACPI. > - Added mention of i2c-hid in the yaml itself as per Rob. > - Adjusted subject as per Rob. > - i2chid_subclass_data => i2chid_ops. > - power_up_device => power_up (same with power_down). > - subclass => ops. > > Changes in v4: > - ("arm64: defconfig: Update config names for i2c-hid rejigger") new for v4. > - Fully rejigger so ACPI and OF are full subclasses. > - Totally redid based on the new subclass system. > > Changes in v3: > - Fixed compatible in example. > - Removed Benjamin as a maintainer. > - Rework to use subclassing. > - Updated description. > > Changes in v2: > - ("dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P") new in v2. > - Get timings based on the compatible string. > - Use a separate compatible string for this new touchscreen. > > Douglas Anderson (4): > HID: i2c-hid: Reorganize so ACPI and OF are separate modules > arm64: defconfig: Update config names for i2c-hid rejigger > dt-bindings: input: HID: i2c-hid: Introduce bindings for the Goodix > GT7375P > HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core I think this series is ready to land. The "defconfig" has a trivial conflict with commit 74b87103b3d0 ("arm64: defconfig: Enable HID multitouch") against linuxnext, but it's so simple that hopefully folks will be OK with that when it lands. Please let me know if there's anything else you need me to do. :-) -Doug _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel