From: dianders@chromium.org (Doug Anderson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: fix PWM clock found on RK3288 Socs
Date: Tue, 18 Nov 2014 21:14:46 -0800 [thread overview]
Message-ID: <CAD=FV=W+WU3j7OWKTxtGUv1Jt7qPesGXSOsoM=bsD5C15jttvA@mail.gmail.com> (raw)
In-Reply-To: <1416367554-15185-1-git-send-email-caesar.wang@rock-chips.com>
Caesar,
On Tue, Nov 18, 2014 at 7:25 PM, Caesar Wang <caesar.wang@rock-chips.com> wrote:
> We use the new PWM IP on RK3288,but the PWM's clock indeed incorrect.
>
> Signed-off-by: Caesar Wang <caesar.wang@rock-chips.com>
> ---
> arch/arm/boot/dts/rk3288.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Right, I reported this when Kever was doing his "unused clocks" patch.
That's why this clock is currently "ignore unused".
...but though your change is right, I'd rather your change doesn't
land quite yet. It totally wrecks havoc with the PWM regulator used
on many rk3288 boards and will glitch the main "logic" voltage at
bootup. I have some patches that are MASSIVELY WIP:
https://chromium-review.googlesource.com/230640
WIP: regulator: pwm: Tell regulator framework that we can't turn off
https://chromium-review.googlesource.com/230641
WIP: PWM: handle the fact that firmware might have left us enabled
https://chromium-review.googlesource.com/230642
WIP: pwm-regulator stuff
I think that last one might blow up into several patches. We need to
solve the problems from those patches before yours can really land.
It's pretty high on my list to finish the above patches, but right now
suspend/resume issues are higher priority so it's a bit stalled... If
someone wants to hijack any of the above patches please let me know--I
won't be offended.
-Doug
next prev parent reply other threads:[~2014-11-19 5:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 3:25 [PATCH] ARM: dts: fix PWM clock found on RK3288 Socs Caesar Wang
2014-11-19 5:14 ` Doug Anderson [this message]
2014-11-19 10:27 ` Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=W+WU3j7OWKTxtGUv1Jt7qPesGXSOsoM=bsD5C15jttvA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).