linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dianders@chromium.org (Doug Anderson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: Add ddc i2c reference to veyron
Date: Thu, 3 Sep 2015 08:55:24 -0700	[thread overview]
Message-ID: <CAD=FV=WsLTQEpoUXyQ4D_F5Uhwg1j0+4=M-VO1niqEipZKAu1Q@mail.gmail.com> (raw)
In-Reply-To: <20150903151854.GA21084@n2100.arm.linux.org.uk>

Hi,

On Thu, Sep 3, 2015 at 8:18 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Thu, Sep 03, 2015 at 09:46:38AM -0500, Rob Herring wrote:
>> Yes, that is fairly common (ADV75xx is same), and we would not
>> describe an I2C bus in DT in that case. Same with HPD directly handled
>> vs. a GPIO line. That is no different than what Doug has said:
>> ddc-i2c-bus is present if using the SOC's I2C host and absent if using
>> the HDMI block's DDC functionality. I'm only questioning the location
>> of the property.
>
> No, I don't think that's what Doug wants.  Doug wants the bridge's
> internal I2C host to be exposed, so he can number it through a DT
> alias.

Actually, my primary concern is that it _doesn't_ conflict with the DT
aliases for busses I care about.  If I didn't provide it with a number
the i2c subsystem was assigning 0 which was conflicting with the real
i2c bus 0.  If the bus was simply not exposed that would have solved
my problem just fine.  ...but if it is being exposed, we need a way to
give it a number.

That being said, my (uninformed) opinion is that if the hardware does
provide enough functionality to expose an i2c bus it's convenient to
expose it, even if it's under a DEBUG config option.  That allows you
to use standard i2c tools during bringup or to debug strange problems.

Obviously since there is hardware that doesn't expose a full i2c bus
then the abstraction should handle that and let a driver just provide
the data directly.

-Doug

  parent reply	other threads:[~2015-09-03 15:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-02 21:25 [PATCH] ARM: dts: Add ddc i2c reference to veyron Douglas Anderson
2015-09-03  0:13 ` Rob Herring
2015-09-03  0:22   ` Doug Anderson
2015-09-03  8:22   ` Russell King - ARM Linux
2015-09-03 14:46     ` Rob Herring
2015-09-03 15:18       ` Russell King - ARM Linux
2015-09-03 15:46         ` Rob Herring
2015-09-03 16:04           ` Doug Anderson
2015-09-03 16:13             ` Lucas Stach
2015-09-03 16:28               ` Doug Anderson
2015-09-03 15:55         ` Doug Anderson [this message]
2015-09-03 21:00 ` Doug Anderson
2015-09-03 22:01   ` Heiko Stuebner
2015-09-03 22:56   ` Brian Norris
2015-09-13 12:23 ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=WsLTQEpoUXyQ4D_F5Uhwg1j0+4=M-VO1niqEipZKAu1Q@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).