[V8 PATCH 01/16] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

[xiechao.mail@gmail.com (Chao Xie)]

On Thu, Mar 7, 2013 at 12:48 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Wed, Mar 06, 2013 at 04:24:58PM +0800, Chao Xie wrote:
>> The clock numbers and names are depent of SOCes,
>
> No they aren't.  The clock names used to describe them in your documentation
> may vary, but their _purpose_ for the sake of the device will be fixed -
> and you should name them appropriately from the _device_ point of view.
>
> Not the SoC point of view.  That way leads to total madness.  We've
> proven this over the years that we've had the clk API and people have
> come up with trash implementations that do that crap.  After many
> years of struggling, they've seen the light and fixed their shite up
> to work the way I originally intended, and... instantly benefited from
> it.
Yes, you are right, and you explained it very clearly.. I understand
what you said.
Our SOC document is lack of this kind of inoformation. I will talk
with the desgin engneer to make clear it, and make a new version of
patches.
Thanks for your review and comments.