From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60873C433DF for ; Wed, 1 Jul 2020 14:10:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32E36207BB for ; Wed, 1 Jul 2020 14:10:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wRQwiKvs"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IBG+Yvvb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32E36207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8bHPTCaUQvMnpzyMY6oQr6BUchC/xWoCqYLNEGZKMK4=; b=wRQwiKvsUpY6FFGkTHxO9fSFC xrW8a0Hlaoc/nOBHMgKOWAxmu0pE4kcxH+dbT/5fRkbtzViaKVQC3k36cPEGjrzC7lR3xkN/mg+sw o0nAV6E41pfWWyTFnI75hQLgMjLJZyl5sutQg3A4tItSAyoPdqu5j3w6aqIZx7HD7nn3rnrOYCXns cTpbZxb23Qj3CGbfIA8DEcIjfyrHhMhlajhPOYFAr4lofvTrHBM3GlcqXLxcEKIaGIp8jsfxK6Kd/ Lnf4+nUqfSC2iUys4QsIT6QD/rYmWJXqgSj7YhJa0U9juQ1eyRM7k42jSaRLjOC9GScOh+wKZ9Pff a61ePqJWg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqdQC-0006po-L4; Wed, 01 Jul 2020 14:09:08 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqdQA-0006p3-J8 for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 14:09:07 +0000 Received: by mail-lj1-x241.google.com with SMTP id q7so13900693ljm.1 for ; Wed, 01 Jul 2020 07:09:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P/P3F3XEPXIiHBtprCyJGmIkmTTIjneNamDkMb/+IKY=; b=IBG+YvvbuNPKZx2AedrFTn56DnNjAVZWf6WQa+RjBf1mdVwCqjoRe0EOWxf2ZsoKNQ b3hN7uxRdo5X8H/WxKRrWNv4IyQKZwMoGr//UG1BFvD4G80WjJOuxFI0S8bxutB3aBRl 0/x5mSLjtl4ALH8xL/qo+ZuHm23MTE7a2MYUMiRAg/rYpwUXAIxp59VbVjZJG/Hg96Sn hEzhJrOi4WgvPeIsoPcSEAEswQ7oN1c+jfCtzg2mmXxV5FSYwIaFA8bEm8UDPlzSbyMJ aadoEpZuQ0drFWEe4DVzI5jCEAc/lkkdTwT+Hos/7mwpPZM6Hkqr1Z1EvfYJ5dWXx569 LKBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P/P3F3XEPXIiHBtprCyJGmIkmTTIjneNamDkMb/+IKY=; b=nHwE4N4IMzWS+lJ6DX0j8hhZIRsmANbTrRI3eg3wAVCYhmCE3e5BL1TnSK7350qdXn K4kfsnp1I96JvF+3VoI8Zl2VNzTYXnr94xDzcFdG+ysxJD/HQ3Dqlm32QlcUTQf9T2Ug tB0aFFyqxb5J7+nu15vJ9sSFJ+ggc48lUZs/y3hy+I78CpkFQr2/8rj0XazRa6H6KVQE 0bD/ptURZts5H6ICY9HgUANHB0VPMKLKkRO0kr6SZy3yeOqUZ6pYFur4+abMRJ3BsDRV l6/8cwDWyAxjTwBWvR0hfjWlaCnIbE5CbYuGoSv1WNItvveJKNJCiHzhp1LOkb21/kVo tnZg== X-Gm-Message-State: AOAM533i+gvXHv7aebjmMtWvp9LJ2NZFm6iH30RHDrK21n3HMc64L7eH PuV5NJTlz5AsOYW5EXI1GViYXnS4SbPTrquqJ+w= X-Google-Smtp-Source: ABdhPJwcM1s4ggfKptzs/9JApOUZ0JUdrDWPQACOb1X4/rZXWo3OKR82bDwC6Vo02IG5t16TWFBovu0WWwtuG2WL0yA= X-Received: by 2002:a2e:82c8:: with SMTP id n8mr13197066ljh.123.1593612545107; Wed, 01 Jul 2020 07:09:05 -0700 (PDT) MIME-Version: 1.0 References: <20200629123215.1014747-1-lee.jones@linaro.org> <20200629123215.1014747-5-lee.jones@linaro.org> <20200701091518.GW1179328@dell> In-Reply-To: <20200701091518.GW1179328@dell> From: Baolin Wang Date: Wed, 1 Jul 2020 22:10:19 +0800 Message-ID: Subject: Re: [PATCH] mfd: sprd-sc27xx-spi: Fix-up bogus IRQ register offset and mask setting To: Lee Jones X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_100906_662419_DC2F5318 X-CRM114-Status: GOOD ( 15.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Orson Zhai , Johan Hovold , LKML , linux-arm-kernel@lists.infradead.org, Chunyan Zhang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 1, 2020 at 5:15 PM Lee Jones wrote: > > 'i / pdata->num_irqs' always equates to 0 and 'BIT(i % pdata->num_irqs)' > always ends up being BIT(i) here, so make that clearer in the code. If > the code base needs to support more than 32 IRQs in the future, this will > have to be reworked, but lets just keep it simple for as long as we can. > > This fixes the following W=1 warning: > > drivers/mfd/sprd-sc27xx-spi.c:255 sprd_pmic_probe() debug: sval_binop_unsigned: divide by zero > > Cc: Orson Zhai > Cc: Chunyan Zhang > Cc: Johan Hovold > Suggested-by: Baolin Wang > Signed-off-by: Lee Jones Thanks. Reviewed-by: Baolin Wang > > diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c > index c305e941e435c..4a1a61e1a86ea 100644 > --- a/drivers/mfd/sprd-sc27xx-spi.c > +++ b/drivers/mfd/sprd-sc27xx-spi.c > @@ -251,10 +251,8 @@ static int sprd_pmic_probe(struct spi_device *spi) > return -ENOMEM; > > ddata->irq_chip.irqs = ddata->irqs; > - for (i = 0; i < pdata->num_irqs; i++) { > - ddata->irqs[i].reg_offset = i / pdata->num_irqs; > - ddata->irqs[i].mask = BIT(i % pdata->num_irqs); > - } > + for (i = 0; i < pdata->num_irqs; i++) > + ddata->irqs[i].mask = BIT(i); > > ret = devm_regmap_add_irq_chip(&spi->dev, ddata->regmap, ddata->irq, > IRQF_ONESHOT | IRQF_NO_SUSPEND, 0, -- Baolin Wang _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel