From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF16BC432C2 for ; Wed, 25 Sep 2019 14:07:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A265821D7C for ; Wed, 25 Sep 2019 14:07:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tw5VtoHY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A265821D7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZL/30k4+TZB7RZ9UkSokA4LlIIebDLR618mc1/6M9gs=; b=tw5VtoHY5rTvWO pZ8LYTeGwv/ImuNfJ0Hn5aQCZpKuiQoly00gweOWf0DxmfIEsZfhVylZn/KhuCRu9rwLA5nzRRCLm UCD1FrGVhLV9hEgbFj+02rkk1tTd/aC3IMwX/B0GfBBFTW43SIMOv2ef4SmuvwnsPVrqxvCOABlDU ao0a5UA3IQtVVRCc+QkTxc9+1v8v65wIFloSDR7opYC3Z88LbWmYn3IDdf+KrvxpP70mjmGGqMl9C iAHJYZeDAdfN7nvUBJ68iktxnfel+ooigiy81ZWVgVPfROlMv56mP+UxNrffAwkTks0GUNJdxnziu A3IJUZfHI0Z3nBvkZt3g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iD7x6-00066U-Ie; Wed, 25 Sep 2019 14:07:32 +0000 Received: from mail-oi1-f196.google.com ([209.85.167.196]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iD7x1-00065X-63 for linux-arm-kernel@lists.infradead.org; Wed, 25 Sep 2019 14:07:29 +0000 Received: by mail-oi1-f196.google.com with SMTP id e18so5003181oii.0 for ; Wed, 25 Sep 2019 07:07:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gNzfLxyphufZW7oX+loBgrNcosGjw89AhG0FkoAT9T0=; b=ZVJf4hHWlumfrad2fpobpnADP09g2sQ3XMYyja5SluMdPGCJ2Q6m3S1AXSYWlgW5t6 HaHL7IO3qPO6io4GUSDrFtEHQROhHQKYlVzJ1um19Dl9/FNb1khhly7XYUZfTP/WoKqw 7rMWUEuiF9Ds89NbpxlpaHN8bkc5CdZGXYZQJdyVRpZ9MXWMJ39GlMHMhLGI4AzBr18R 0un2X57mxEY3Y1G/3ApcXpOtTRPh7H3WQPawm/H+m9R6IKBZM2RCk9S7aFn7zcS+KZLB nFOeF6pRw9oYfM0kICAhQgAKguDaX7Gi5st+rmRojxlH50/tlG++If+0N18qLA1jOb5k XVtA== X-Gm-Message-State: APjAAAWd075k+8ojXikh+ir+STJ2HRYN5BQ3tfB+SjCbx1AS9iacrWjZ evx+WMFaZP9AuH9VqBc8a+HTEcm6 X-Google-Smtp-Source: APXvYqyXUJiLdx/29bxedTiE+6H7/KJdZGHTDAQlwUZL5bOkSbqvIYRaOHFMNr0lVAE3AC3doV1fJQ== X-Received: by 2002:aca:b286:: with SMTP id b128mr4757609oif.100.1569420443932; Wed, 25 Sep 2019 07:07:23 -0700 (PDT) Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com. [209.85.167.175]) by smtp.gmail.com with ESMTPSA id y11sm1533983oih.18.2019.09.25.07.07.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Sep 2019 07:07:23 -0700 (PDT) Received: by mail-oi1-f175.google.com with SMTP id x3so5008308oig.2 for ; Wed, 25 Sep 2019 07:07:23 -0700 (PDT) X-Received: by 2002:aca:d988:: with SMTP id q130mr4486320oig.13.1569420442960; Wed, 25 Sep 2019 07:07:22 -0700 (PDT) MIME-Version: 1.0 References: <20190924024548.4356-1-biwen.li@nxp.com> <20190924024548.4356-3-biwen.li@nxp.com> In-Reply-To: From: Li Yang Date: Wed, 25 Sep 2019 09:07:12 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v3, 3/3] Documentation: dt: binding: fsl: Add 'fsl, ippdexpcr-alt-addr' property To: Biwen Li X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190925_070727_365042_47053BEE X-CRM114-Status: GOOD ( 33.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , Ran Wang , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 24, 2019 at 11:27 PM Biwen Li wrote: > > > > > > > > > > > > > > > > > > > > > > > > > The 'fsl,ippdexpcr-alt-addr' property is used to handle > > > > > > > > > > an errata > > > > > > > > > > A-008646 on LS1021A > > > > > > > > > > > > > > > > > > > > Signed-off-by: Biwen Li > > > > > > > > > > --- > > > > > > > > > > Change in v3: > > > > > > > > > > - rename property name > > > > > > > > > > fsl,rcpm-scfg -> fsl,ippdexpcr-alt-addr > > > > > > > > > > > > > > > > > > > > Change in v2: > > > > > > > > > > - update desc of the property 'fsl,rcpm-scfg' > > > > > > > > > > > > > > > > > > > > Documentation/devicetree/bindings/soc/fsl/rcpm.txt | 14 > > > > > > > > > > ++++++++++++++ > > > > > > > > > > 1 file changed, 14 insertions(+) > > > > > > > > > > > > > > > > > > > > diff --git > > > > > > > > > > a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt > > > > > > > > > > b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt > > > > > > > > > > index 5a33619d881d..157dcf6da17c 100644 > > > > > > > > > > --- a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt > > > > > > > > > > +++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt > > > > > > > > > > @@ -34,6 +34,11 @@ Chassis Version Example > > > > Chips > > > > > > > > > > Optional properties: > > > > > > > > > > - little-endian : RCPM register block is Little Endian. > > > > > > > > > > Without it > > > > > RCPM > > > > > > > > > > will be Big Endian (default case). > > > > > > > > > > + - fsl,ippdexpcr-alt-addr : Must add the property for > > > > > > > > > > + SoC LS1021A, > > > > > > > > > > > > > > > > > > You probably should mention this is related to a hardware > > > > > > > > > issue on LS1021a and only needed on LS1021a. > > > > > > > > Okay, got it, thanks, I will add this in v4. > > > > > > > > > > > > > > > > > > > + Must include n + 1 entries (n = > > > > > > > > > > + #fsl,rcpm-wakeup-cells, such > > > as: > > > > > > > > > > + #fsl,rcpm-wakeup-cells equal to 2, then must include > > > > > > > > > > + 2 > > > > > > > > > > + + > > > > > > > > > > + 1 > > > > > entries). > > > > > > > > > > > > > > > > > > #fsl,rcpm-wakeup-cells is the number of IPPDEXPCR > > > > > > > > > registers on an > > > > > SoC. > > > > > > > > > However you are defining an offset to scfg registers here. > > > > > > > > > Why these two are related? The length here should > > > > > > > > > actually be related to the #address-cells of the soc/. > > > > > > > > > But since this is only needed for LS1021, you can > > > > > > > > just make it 3. > > > > > > > > I need set the value of IPPDEXPCR resgiters from ftm_alarm0 > > > > > > > > device node(fsl,rcpm-wakeup = <&rcpm 0x0 0x20000000>; > > > > > > > > 0x0 is a value for IPPDEXPCR0, 0x20000000 is a value for > > > > > IPPDEXPCR1). > > > > > > > > But because of the hardware issue on LS1021A, I need store > > > > > > > > the value of IPPDEXPCR registers to an alt address. So I > > > > > > > > defining an offset to scfg registers, then RCPM driver get > > > > > > > > an abosolute address from offset, RCPM driver write the > > > > > > > > value of IPPDEXPCR registers to these abosolute > > > > > > > > addresses(backup the value of IPPDEXPCR > > > > > registers). > > > > > > > > > > > > > > I understand what you are trying to do. The problem is that > > > > > > > the new fsl,ippdexpcr-alt-addr property contains a phandle and an > > offset. > > > > > > > The size of it shouldn't be related to #fsl,rcpm-wakeup-cells. > > > > > > You maybe like this: fsl,ippdexpcr-alt-addr = <&scfg 0x51c>;/* > > > > > > SCFG_SPARECR8 */ > > > > > > > > > > No. The #address-cell for the soc/ is 2, so the offset to scfg > > > > > should be 0x0 0x51c. The total size should be 3, but it shouldn't > > > > > be coming from #fsl,rcpm-wakeup-cells like you mentioned in the > > binding. > > > > Oh, I got it. You want that fsl,ippdexpcr-alt-add is relative with > > > > #address-cells instead of #fsl,rcpm-wakeup-cells. > > > > > > Yes. > > I got an example from drivers/pci/controller/dwc/pci-layerscape.c > > and arch/arm/boot/dts/ls1021a.dtsi as follows: > > fsl,pcie-scfg = <&scfg 0>, 0 is an index > > > > In my fsl,ippdexpcr-alt-addr = <&scfg 0x0 0x51c>, It means that 0x0 is an alt > > offset address for IPPDEXPCR0, 0x51c is an alt offset address For > > IPPDEXPCR1 instead of 0x0 and 0x51c compose to an alt address of > > SCFG_SPARECR8. > Maybe I need write it as: > fsl,ippdexpcr-alt-addr = <&scfg 0x0 0x0 0x0 0x51c>; > first two 0x0 compose an alt offset address for IPPDEXPCR0, > last 0x0 and 0x51c compose an alt address for IPPDEXPCR1, I remember the hardware issue is only is only related to IPPDEXPCR1 register, no idea why you need to define IPPDEXPCR0 in the binding. > > Best Regards, > Biwen Li > > > > > > Regards, > > > Leo > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > + The first entry must be a link to the SCFG device node. > > > > > > > > > > + The non-first entry must be offset of registers of SCFG. > > > > > > > > > > > > > > > > > > > > Example: > > > > > > > > > > The RCPM node for T4240: > > > > > > > > > > @@ -43,6 +48,15 @@ The RCPM node for T4240: > > > > > > > > > > #fsl,rcpm-wakeup-cells = <2>; > > > > > > > > > > }; > > > > > > > > > > > > > > > > > > > > +The RCPM node for LS1021A: > > > > > > > > > > + rcpm: rcpm@1ee2140 { > > > > > > > > > > + compatible = "fsl,ls1021a-rcpm", "fsl,qoriq-rcpm- > > > > > > 2.1+"; > > > > > > > > > > + reg = <0x0 0x1ee2140 0x0 0x8>; > > > > > > > > > > + #fsl,rcpm-wakeup-cells = <2>; > > > > > > > > > > + fsl,ippdexpcr-alt-addr = <&scfg 0x0 0x51c>; /* > > > > > > > > > > SCFG_SPARECR8 */ > > > > > > > > > > + }; > > > > > > > > > > + > > > > > > > > > > + > > > > > > > > > > * Freescale RCPM Wakeup Source Device Tree Bindings > > > > > > > > > > ------------------------------------------- > > > > > > > > > > Required fsl,rcpm-wakeup property should be added to a > > > > > > > > > > device node if the device > > > > > > > > > > -- > > > > > > > > > > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel