From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C538FC433C1 for ; Mon, 22 Mar 2021 23:14:20 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F782619AA for ; Mon, 22 Mar 2021 23:14:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F782619AA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rgE2tAIU2LLZH/6AQwu787CMWSf+BZVXiyzM1MCi2gM=; b=j4Fqg8gt4qHuR1YAVwJvradyY dj/85+CTnDtLHZ9D5G+8rg/vU0U0v780vNrGTjB9Wl1SxCLF1jwFb+PxX4zCN94B822NSk/ce2bHS Sg1+gOuxt14mH/4Sg9/NwlwnQQWMtL+HU0id3FJ3peWCnJ+2xGuQAI67/E5ohth5rkSaTYJZAOeLz l5TGVCiToCTAriYq6ZLCluWivc6pgCTprFjAXWTVtCk0bZX7yjq90weE72+YiOgDpqpEwHx79NW+u nYw78e+NqWLD5mlXQjG8irckx/s/kmiYTC1ljoV7ZEqAhDswRu0jb8mF/8DxzwED1hp0jzZYz4/XQ 00vHImQtQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOTil-00Covk-Rq; Mon, 22 Mar 2021 23:12:28 +0000 Received: from mail-ot1-f45.google.com ([209.85.210.45]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lOTii-00Cou6-E1 for linux-arm-kernel@lists.infradead.org; Mon, 22 Mar 2021 23:12:26 +0000 Received: by mail-ot1-f45.google.com with SMTP id h6-20020a0568300346b02901b71a850ab4so17680814ote.6 for ; Mon, 22 Mar 2021 16:12:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=McQT4s4j4Lcn3Ti7MbeKUQbdrUGlmk29d7hOHsI/ts0=; b=XDh43nnAhbqg7KDm9HOUeyMCwg3fb7DtvGfWunkiX7Xqi6OutpNxV7GFW+TWOk5ueN 9NWXxQ4ADlme7zrUJ0NbGHXlk/B30JOpX3tdPo5MHhjWusDEYFQ/U2tCbbyGjUStQK45 SksGr2lLeVAxURSR4HayaKJCC6l8l2ni56B42XO2xoJJng2OTvl5sqCZGOaCZm4YzXO9 cWOa7iO0iIhsI2/Nc3zNQ0SJhkkr79nHLQfefiWteS4aYXGdWVhrgmnHDorqt9ujZNp4 yrBMo38kNPm7608j3XZT1HDEyNl07Fe1VLNt1yv4glp31S4ZGpS1fjcFaGy3o1Lce7u8 YtHw== X-Gm-Message-State: AOAM5300/BlehCzJPYlFffbDsKd+VqmKKg1KR5XZWLqI/HtWnTGI67h6 Oyl2QfJ68utNVxGxZGp7jicWLSlm3VA= X-Google-Smtp-Source: ABdhPJzkwTkzYDCuStCzJm90LXa+lLRBD8thzZhDg+QEpim6elES/LBt3sQWy77rZcrqkiOqAXXzTQ== X-Received: by 2002:a9d:6390:: with SMTP id w16mr1834071otk.178.1616454739571; Mon, 22 Mar 2021 16:12:19 -0700 (PDT) Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com. [209.85.210.42]) by smtp.gmail.com with ESMTPSA id h17sm3668678otj.38.2021.03.22.16.12.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 16:12:18 -0700 (PDT) Received: by mail-ot1-f42.google.com with SMTP id m21-20020a9d7ad50000b02901b83efc84a0so17665934otn.10 for ; Mon, 22 Mar 2021 16:12:18 -0700 (PDT) X-Received: by 2002:a05:6830:2043:: with SMTP id f3mr1853763otp.63.1616454738360; Mon, 22 Mar 2021 16:12:18 -0700 (PDT) MIME-Version: 1.0 References: <20210318083438.26536-1-michael@walle.cc> In-Reply-To: <20210318083438.26536-1-michael@walle.cc> From: Li Yang Date: Mon, 22 Mar 2021 18:12:06 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: dts: ls1028a: fix optee node To: Michael Walle Cc: "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , lkml , Shawn Guo , Rob Herring , Sahil Malhotra , Guillaume Tucker , "kernelci.org bot" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210322_231224_714295_9498F4D7 X-CRM114-Status: GOOD ( 21.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 18, 2021 at 3:36 AM Michael Walle wrote: > > Don't enable the optee node in the SoC include. It is an optional > component and actually, if enabled, breaks boards which doesn't have it. Hi Shawn, Shall we make this a general rule? I see quite a few SoC dtsi files are having the optee node enabled by default. Regards, Leo > > This reverts commit 48787485f8de ("arm64: dts: ls1028a: enable optee > node") and enables the node per board, assuming the intend of the > original author was to enable OPTEE for the LS1028A-RDB and the > LS1028A-QDS. > > Fixes: 48787485f8de ("arm64: dts: ls1028a: enable optee node") > Reported-by: Guillaume Tucker > Reported-by: "kernelci.org bot" > Tested-by: Michael Walle > Signed-off-by: Michael Walle > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 4 ++++ > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 4 ++++ > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 3 ++- > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > index fbcba9cb8503..060d3c79244d 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > @@ -327,6 +327,10 @@ > status = "okay"; > }; > > +&optee { > + status = "okay"; > +}; > + > &sai1 { > status = "okay"; > }; > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > index 41ae6e7675ba..1bdf0104d492 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > @@ -274,6 +274,10 @@ > status = "okay"; > }; > > +&optee { > + status = "okay"; > +}; > + > &sai4 { > status = "okay"; > }; > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 50d277eb2a54..e2007ebacd69 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -92,9 +92,10 @@ > }; > > firmware { > - optee { > + optee: optee { > compatible = "linaro,optee-tz"; > method = "smc"; > + status = "disabled"; > }; > }; > > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel