From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEC60C433EF for ; Fri, 1 Oct 2021 20:10:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7313061A8D for ; Fri, 1 Oct 2021 20:10:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7313061A8D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dtGaWH/KxCvGwAyt1p/pyXB59XRFjZGsqNIXRgh7avo=; b=URiOhfslOXqvpw TbGmxRmtcEaF7j5Wyi8mWLwWnZUUGSXzutxP9H3BXy3tJE8q6P48u6WeLeMRmax0tjZLeVFRo3+jS /2SdhLFVK3YGf+QQ7SN7PsuemvxUnjZk7UCWvSHZsd5eKhEa46L4xEudPcthvvR2HAJpZyDA++Irc Xu+83ZlF8cX6QQcD0xxyb92RJTUC0WOSfXKr7xSOcpv3Ev5CYgxIRFN7UKgB43KhdtLDD5xsTQ2JU cASeSS2wlIs+UUJgsCsrklMGICRS8Ht1mYvL0+2NfrkCOrUGDA/ynuAQLGVMAezBuJ6IIC0FbH9l4 /Ws0VkiowyVl7BGj183A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWOpX-001Eqk-Ci; Fri, 01 Oct 2021 20:08:27 +0000 Received: from mail-qk1-f169.google.com ([209.85.222.169]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWOpU-001Eq3-Dg for linux-arm-kernel@lists.infradead.org; Fri, 01 Oct 2021 20:08:25 +0000 Received: by mail-qk1-f169.google.com with SMTP id i132so10377941qke.1 for ; Fri, 01 Oct 2021 13:08:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KQlSEZZ+M9EHNYuoq+CO7QYaIkckaY1yCBN43D3/TuI=; b=Hpm5xWGw6xsDDBKKi9mtx+Nlw+iv80rSBKMo3lUt2OjIlExSUEVFxD1FBD9iAACuGw RyO9BmSYF2J/w2hRZKyQYONyuHyQFcZGdaEiZNgvCpTCEWNeXOREHfmtpSyHZH0YP5Jv qEB/MgN69t1y8zwbiKKgq9yQ8U5d6CX08t1CqtrxkXRoRid2LxLjWXlFRAzwekk3qADu RWOAaYhSpxkoZLx8rYgFEWGno3ZZYux5hQc5oFmYGOBFww6eWDUgGRq8JUIvDK/4BTyW 7iJ3z5DeqaZ7/8JHHwQwK+4UZURJtqEs6NXgI4AffsFBDeEIX/otcHypQED8lUTWvyaB ovFQ== X-Gm-Message-State: AOAM530BTdWGStaZj++ZbVO9rVdmJVC32TQPCR9OxDehWkBZdExXevc6 6leXC8/AWqMXmT2IVDSO/23KffsFTkY= X-Google-Smtp-Source: ABdhPJw62VskUQfohoO0Q8Tk6xEhcwKDy/QpU2ntitd4afTpxyaTNk8mbZxpsu1dqNL35hb9zW4DoA== X-Received: by 2002:a37:a4cc:: with SMTP id n195mr10991842qke.86.1633118898781; Fri, 01 Oct 2021 13:08:18 -0700 (PDT) Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com. [209.85.219.49]) by smtp.gmail.com with ESMTPSA id u21sm3474737qkk.82.2021.10.01.13.08.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Oct 2021 13:08:18 -0700 (PDT) Received: by mail-qv1-f49.google.com with SMTP id v14so4931486qvl.9 for ; Fri, 01 Oct 2021 13:08:17 -0700 (PDT) X-Received: by 2002:a05:6214:36d:: with SMTP id t13mr11022398qvu.50.1633118897756; Fri, 01 Oct 2021 13:08:17 -0700 (PDT) MIME-Version: 1.0 References: <20211001000417.15334-1-leoyang.li@nxp.com> <20211001000417.15334-5-leoyang.li@nxp.com> In-Reply-To: From: Li Yang Date: Fri, 1 Oct 2021 15:08:05 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [EXT] [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for QSPI flash To: Kuldeep Singh Cc: Shawn Guo , Rob Herring , "devicetree@vger.kernel.org" , Oleksij Rempel , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211001_130824_491305_36CBDD6C X-CRM114-Status: GOOD ( 26.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 1, 2021 at 12:30 AM Kuldeep Singh wrote: > > Hi Leo, > > > -----Original Message----- > > From: Li Yang > > Sent: Friday, October 1, 2021 5:34 AM > > To: Shawn Guo ; Rob Herring > > ; devicetree@vger.kernel.org; Oleksij Rempel > > ; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org > > Cc: Leo Li > > Subject: [EXT] [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for QSPI > > flash > > > > Caution: EXT Email > > > > Add the missing node for qspi flash. > > > > Signed-off-by: Li Yang > > --- > > arch/arm/boot/dts/ls1021a-qds.dts | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm/boot/dts/ls1021a-qds.dts > > b/arch/arm/boot/dts/ls1021a-qds.dts > > index e2aa569ff404..522e1dc51059 100644 > > --- a/arch/arm/boot/dts/ls1021a-qds.dts > > +++ b/arch/arm/boot/dts/ls1021a-qds.dts > > @@ -286,6 +286,21 @@ tbi0: tbi-phy@8 { > > }; > > }; > > > > +&qspi { > > + num-cs = <2>; > > Please drop "num-cs" property as it is not used by qspi driver. > > > + status = "okay"; > > + > > + qflash0: flash@0 { > > Can we have flash chip name instead of qflash? > There is no hard requirement, it will help in aligning node properties with other board properties such as LX2160A-RDB, LS1046A-RDB etc. Thanks for the review. I find that there is no reference to the label at all. I don't know why we added it in the first place. Probably we can just remove it? > > With above fixed, > Reviewed-by: Kuldeep Singh > > > + compatible = "jedec,spi-nor"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + spi-max-frequency = <20000000>; > > + reg = <0>; > > + spi-rx-bus-width = <4>; > > + spi-tx-bus-width = <4>; > > + }; > > +}; > > + > > &sai2 { > > status = "okay"; > > }; > > -- > > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel