From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65733C2D0E8 for ; Fri, 27 Mar 2020 07:19:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EB1A20663 for ; Fri, 27 Mar 2020 07:19:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Dqlx26pA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cdU3jT5o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EB1A20663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jhwOeGL0ERaNMmg9pG+6JK26feaC1lE9A0ZyDHqwbJY=; b=Dqlx26pAHafz8R EVpwiQgDnZGEctdTd5FGoKXubS5AsrvDoDJcqItO9c9ExpBlXWNwPtv3wN2FPlh3x84ZN5w9k1rya rJH563AwrRlFlkWApcWgvMlWhmeI7sOtGbgXGLrnAXe7zJ/IvviUN0Usu2KOjPaCnh1LNEv+fP4r6 pYZCz7pUWvEEw/G4p977e1HooLYbnv3q+pmUIVWnQhop+N1JdFB2IWW+8rZpFg1stqdd1tng/IaCu kwClT4QmFaSMjlIwOXETlFtQejRpVJYmVhRrMjAl5mZ6LGz9tN3vahSw256Ylhq/B62mGLzZFm4+q YwwTOKkBOebkHL4rSSMw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jHjH2-00052E-ET; Fri, 27 Mar 2020 07:19:24 +0000 Received: from mail-lf1-x142.google.com ([2a00:1450:4864:20::142]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jHjGy-00051T-Js for linux-arm-kernel@lists.infradead.org; Fri, 27 Mar 2020 07:19:22 +0000 Received: by mail-lf1-x142.google.com with SMTP id v4so6972111lfo.12 for ; Fri, 27 Mar 2020 00:19:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8yD3/mZAPx4NyJAYvyAM42UOXEcrRRB02HlarcvJcpY=; b=cdU3jT5oe/H7QKTBQOhKMp9drgTOsgZe5NhZH3AgSZm3iIiqG7Mpdb7eiSi/aoXspU adDnKmgjnNQOPOlbHzzO67tuGNnmIIXVdvnZjQLsWvhaxncdd/E9LNTu0B8xituEt11S im4peLookDERzMUR0/fJILym8NflyDU2H23CU1F2sEboZO0GzyBnSX7Sw58NmW1eoFRz QmjqAIIJ9eQ8gHc/xFj9sQsbaUodlZeNkmUP/NtCyr8IOePkWyk2t1k8IYPAE5lUA9Un TRQsPtLWtJUdSDAhud+rUIempEHW9rwXfg91DpI/kpwYm00hGRzm7ZMusZ+CVcF3VjUC zW8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8yD3/mZAPx4NyJAYvyAM42UOXEcrRRB02HlarcvJcpY=; b=kqaB8t280sO67YxiN0YKtxzlVzBaTtrn+uY6xMviUxKux4chVSFtbr3nzg1NJENQIp H1KPHwzDpatXTjR6QQYaX5yUNSWZxMOSoO5VH+uoqqsRuayckQIMZQCp42olrwM8i/P+ 0nmJBzZQJ4/LsE1+WaSJq3qAbq6kvpprskkn2cmxkq5ay33SFOuGGZsREhh+K3JW2z1s EiPELMIuZgST80Zm5/AEOu5QfolBjGItZxXjhy60Z35Fo4ZS+TPUlTj6QM+Ou0OwNUgV Yj8Au0ZMKQCIaHulQ3d5UJdGw48y8vZHfMBo6lFDqte91N12QlV9iGmLpIQpwPdRoD9M 53Kg== X-Gm-Message-State: ANhLgQ2RaZydt8oEjkC/Umo3KM9bwI+/acPlyTkTPZKUe0nbKzIWb3bw 18MH0Vxxei3yFupIusP1cKopZmsdWiC4PcVIuHTGEg== X-Google-Smtp-Source: ADFU+vsVleHzR2OlQgFnip8JwdTpgtyxbozUTC6A2rWBZO45SHy2RsvKY2E8cSZkDmSqmkfRqCMidvfUsGCh9kDJWeQ= X-Received: by 2002:ac2:53b2:: with SMTP id j18mr8178328lfh.206.1585293557144; Fri, 27 Mar 2020 00:19:17 -0700 (PDT) MIME-Version: 1.0 References: <20200326182742.487026-1-enric.balletbo@collabora.com> In-Reply-To: <20200326182742.487026-1-enric.balletbo@collabora.com> From: Anders Roxell Date: Fri, 27 Mar 2020 08:19:06 +0100 Message-ID: Subject: Re: [PATCH] soc: mediatek: mtk-mmsys: Export ddp_dis/connect symbols To: Enric Balletbo i Serra X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200327_001920_794725_C6A67D57 X-CRM114-Status: GOOD ( 12.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, Linux Kernel Mailing List , linux-mediatek@lists.infradead.org, hsinyi@chromium.org, Matthias Brugger , Collabora Kernel ML , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 26 Mar 2020 at 19:27, Enric Balletbo i Serra wrote: > > When building on arm64 with allmodconfig or CONFIG_DRM_MEDIATEK=m we see > the following error. > > ERROR: modpost: "mtk_mmsys_ddp_disconnect" > [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined! > ERROR: modpost: "mtk_mmsys_ddp_connect" > [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined! > > Export mtk_mmsys_ddp_connect and mtk_mmsys_ddp_disconnect symbols to be > able to be used for other modules. > > Fixes: 396c3fccaf03 ("soc / drm: mediatek: Move routing control to mmsys device") > Reported-by: Anders Roxell > Signed-off-by: Enric Balletbo i Serra Tested-by: Anders Roxell Cheers, Anders > --- > > drivers/soc/mediatek/mtk-mmsys.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c > index 32a92ec447c5..05e322c9c301 100644 > --- a/drivers/soc/mediatek/mtk-mmsys.c > +++ b/drivers/soc/mediatek/mtk-mmsys.c > @@ -259,6 +259,7 @@ void mtk_mmsys_ddp_connect(struct device *dev, > writel_relaxed(reg, config_regs + addr); > } > } > +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_connect); > > void mtk_mmsys_ddp_disconnect(struct device *dev, > enum mtk_ddp_comp_id cur, > @@ -279,6 +280,7 @@ void mtk_mmsys_ddp_disconnect(struct device *dev, > writel_relaxed(reg, config_regs + addr); > } > } > +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_disconnect); > > static int mtk_mmsys_probe(struct platform_device *pdev) > { > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel