From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E81B3C433E0 for ; Tue, 7 Jul 2020 16:50:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A99612064C for ; Tue, 7 Jul 2020 16:50:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rPQ+5ToC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=anholt-net.20150623.gappssmtp.com header.i=@anholt-net.20150623.gappssmtp.com header.b="zVxRNPDq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A99612064C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=anholt.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AjtuGozRX0tgMpuBX5bU5K/d6TImdBl8ttncdMUcyYE=; b=rPQ+5ToCdxvX44dC/8fAH02FW wJhy35wGQKfzjjEtb5O5DwBQfLri2Bu/hbs2InyHZT/5/ygFveul8imr4GALoq7B0FTafRTGwOBq0 6468tnniFCmK9wvwcv4ASdjki8nyEoM/uYYxHAAsllTbIin7rh9X3oMpsY5bg+BFyUxDpLLYbuio6 wWirj8P6oZjNMBRX739TKPgfaFHEsy3tftdzISLFU2vkxEJOZxoyedAgRtyEECJGyX5Xwm6NSLIbz xRzv3gXKcXZKRZw9fEfgojbCYq7zrUSKdqOOfahtSdrf0HKMGus1HP634KiWTWf4A0Tl2pe7eWdvR eatp+zPGg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsqmF-0004vd-Vg; Tue, 07 Jul 2020 16:49:04 +0000 Received: from mail-ej1-x642.google.com ([2a00:1450:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsqmB-0004tf-Mz for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 16:49:01 +0000 Received: by mail-ej1-x642.google.com with SMTP id f12so21091614eja.9 for ; Tue, 07 Jul 2020 09:48:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anholt-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zgVTJRvD9bwxe5h5OvimEh3WdUQa6jrydlK+z8ViyTs=; b=zVxRNPDq7ABzlflkDXevx/FhRX3DMHNv1OPOprmzo5mnbqWnTdiXr3GZ9aWg1o3S99 kfIbw7eX93DpOe60uBJ1MCq69J4i2kwjsfBHFiQSBpFsRGqoP+Xw8vUEiubYxSvh9eKd rEEvMukKP+CiCbPiwrg0eVAIXy72RK2BZF7IzlOHb6akoBOrVrqBd5R97Iyn4yOI1Jzm qtGuOV8VdVYNsp3CYFNGqby+BbC4t7/DVn4OiKv3nXhRZBqmDU0D/c8gD/aWojzgoKMy Cp99EZZjV60Ui9aeL7L8GegBgX5P36pggwvzayFn3QiBf8do4mMHVD29Sxm2ZcwkmTI5 GJ0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zgVTJRvD9bwxe5h5OvimEh3WdUQa6jrydlK+z8ViyTs=; b=pBMsZMVr0pilTF+nsYf3wKzXPqyvwa70FjH5pr7sGwWk7S6Ft3lP7C5QrW/zKs8bDa jR2/l9HupKdMeKBNxp+JpbzjYKHsJeLjMCO+maI7QZgR/WlhFLabCYVfKZ+ShftcLKTf TK/QqrMyI95kUqrLe+XoWz8pkcrVMcrX+V6zz6R588puZ7gIy7cRrWlW3CdDHCWAwqLn xAVxMEKpgLsxEVp55kAEgJZCtfo67qUmVXDrOvRaFaDsqsp0qxq/zgZJvjY3Z4rCDy5i 6/9LIfThhK0t5WDtN9NSzrFelZrmx4n1UPZnoOWA43VoY1XGX5MaXtZd+wcnfzTFVkkz iGDA== X-Gm-Message-State: AOAM53127tILUgaXMppj75QS1Lkwk6fKQi8EAoEceAtcemBLfpNwF7nb jM/q/qgueY30nafpEXOgJVr0CGMaz+f9u+t3SWoMAQ== X-Google-Smtp-Source: ABdhPJwN4AiRPoJPptQHSEO5cXd/B0knty7XexXAcHi41D+rEc2uWRwzjRdqzHuHAga/dgYkl+FQ3tSx4nDRlmqpLQA= X-Received: by 2002:a17:906:1986:: with SMTP id g6mr37299161ejd.404.1594140536621; Tue, 07 Jul 2020 09:48:56 -0700 (PDT) MIME-Version: 1.0 References: <20200707101912.571531-1-maxime@cerno.tech> In-Reply-To: <20200707101912.571531-1-maxime@cerno.tech> From: Eric Anholt Date: Tue, 7 Jul 2020 09:48:45 -0700 Message-ID: Subject: Re: [PATCH] drm/vc4: dsi: Only register our component once a DSI device is attached To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_124900_459126_2613823F X-CRM114-Status: GOOD ( 17.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , Dave Stevenson , LKML , DRI Development , Andrzej Hajda , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Phil Elwell , Linux ARM , linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 7, 2020 at 3:26 AM Maxime Ripard wrote: > > If the DSI driver is the last to probe, component_add will try to run all > the bind callbacks straight away and return the error code. > > However, since we depend on a power domain, we're pretty much guaranteed to > be in that case on the BCM2711, and are just lucky on the previous SoCs > since the v3d also depends on that power domain and is further in the probe > order. > > In that case, the DSI host will not stick around in the system: the DSI > bind callback will be executed, will not find any DSI device attached and > will return EPROBE_DEFER, and we will then remove the DSI host and ask to > be probed later on. > > But since that host doesn't stick around, DSI devices like the RaspberryPi > touchscreen whose probe is not linked to the DSI host (unlike the usual DSI > devices that will be probed through the call to mipi_dsi_host_register) > cannot attach to the DSI host, and we thus end up in a situation where the > DSI host cannot probe because the panel hasn't probed yet, and the panel > cannot probe because the DSI host hasn't yet. > > In order to break this cycle, let's wait until there's a DSI device that > attaches to the DSI host to register the component and allow to progress > further. > > Suggested-by: Andrzej Hajda > Signed-off-by: Maxime Ripard I feel like I've written this patch before, but I've thankfully forgotten most of my battle with DSI probing. As long as this still lets vc4 probe in the absence of a DSI panel in the DT as well, then this is enthusiastically acked. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel