From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51F4CC61D90 for ; Tue, 21 Nov 2023 17:16:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mn8t7/eqoqo91TjV1VB7A/8Fy7O3rjtEUTbTU3aIP3M=; b=e0aO/u5dRtdh/F s92TYzrIpSj9E1wET+hte4sT2UES8LWqxKP6w1Ra/daNXxWsLTUcyL47kOQA5tW/bNzo2/RryR0jh 5vfZFsx2vi0oc6INQ2kjbLMYZ9hU42nHpNRVTf8UErtuGeKomgr5ckMrhFG74CRy40Qr0txhcmGXz 13/zlXeBhBT4ly7P3lAOWFRYhbjnlIamSSaa6S6xEPF+w4zXuIY8TfkRV7yNzTDGfX6LedliGlX9a qFcx3SNFCSUn4Wn7L5/CBPKc3R1J9LXKXhk9cpcK6LtG+5KbxT7byHOQ4DTTuRItvkZpbx4JHjjCy cbcQjyKN785w6bq8CmEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r5ULu-00HNBq-2a; Tue, 21 Nov 2023 17:15:58 +0000 Received: from mail-ot1-x336.google.com ([2607:f8b0:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r5ULs-00HNB8-1N for linux-arm-kernel@lists.infradead.org; Tue, 21 Nov 2023 17:15:57 +0000 Received: by mail-ot1-x336.google.com with SMTP id 46e09a7af769-6d648679605so3108095a34.1 for ; Tue, 21 Nov 2023 09:15:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700586954; x=1701191754; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wYvL1f6qyMgF9ZLkQm7l0/EVu68jtasrXI+WCiFQL18=; b=H5+ZPhNBuqLm+9ZS43VvfwREy9ZVqcdF/Wh9WpPrkT4Qrdsoy9cySoRiWmMXc6jnhY W/thTz8DOgVNtzb4SKT+xM0x1fozdttVnSxd7Ny8TdFvYDvecFkCVmA39/i3r59zAjN5 Gd2nY+e+okbOHiSsTf5AKlFbAc646NaUD0QsQy6dm5A3l6dCCF+1dDweZEZoO+Ev4OD3 Y36qx3EHsXkU74rK5o3qTpHbOQJiOEGRHOG8GDH/CoD0DUbRF6q4VPdapWTpSxeVxQxh zc4wfw+PHs5BprNgO+6cAf+FvVCsQCf7S1CtEu5BQaJTwFahfmPpUna7jXISGElZ0Qcm Z8LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700586954; x=1701191754; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wYvL1f6qyMgF9ZLkQm7l0/EVu68jtasrXI+WCiFQL18=; b=Lb2pJFPU4pdOYYqiufb+qLYMxJa12IHGZBzxzJ1aFrU+GnPjgAguWoTAczwf8H3Z71 TC8lCbtK7VhAI219v9mCq8myY7si8t6abYxb/MKrATTI1USFBJIUZj1yYaq6wat/4JxH VSHpE8yb9LCawFmRK2JoDSPvWpHKSRLZudGy2ID33DSzzVONUxD/AcGTtTjq9ZmVxX2w 5ycQ2GWqjmtkRASnO+z7mQcFKRuzWXXRsCI0M4LwvWr3rfcuWhjC98FhWxG3CptPCJDb veE6osCX5i8GDpJCsZZDqYIIHVq8B5MxAf4dlgpMRPRC0jKAigQEI30AH/o1KAEX7Y9l zTEQ== X-Gm-Message-State: AOJu0Yw0bDW5GQ1QUpm4bI2JllVVom6ApjD1bVRvvRAvjTUYtTcxyE90 CUn2USwImQwpHSzmYNYSHwtp4PxjCxB++IVjwRs4eQ== X-Google-Smtp-Source: AGHT+IE1Yjlr5gsSZr73YBwrAm/JguEA+8gBotneRznXIDcM0Spz8+slB43K4KERP5aFOuw7iXwJdfOtIrJBVa4sOBQ= X-Received: by 2002:a05:6830:1da4:b0:6b8:807b:b50 with SMTP id z4-20020a0568301da400b006b8807b0b50mr13016366oti.22.1700586954278; Tue, 21 Nov 2023 09:15:54 -0800 (PST) MIME-Version: 1.0 References: <20231120212037.911774-1-peter.griffin@linaro.org> <20231120212037.911774-10-peter.griffin@linaro.org> <20231121151630.GA1692178-robh@kernel.org> In-Reply-To: <20231121151630.GA1692178-robh@kernel.org> From: Peter Griffin Date: Tue, 21 Nov 2023 17:15:42 +0000 Message-ID: Subject: Re: [PATCH v4 09/19] dt-bindings: serial: samsung: Make samsung,uart-fifosize required property To: Rob Herring Cc: krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, cw00.choi@samsung.com, alim.akhtar@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231121_091556_473230_9FA31188 X-CRM114-Status: GOOD ( 31.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, Thanks for your review. On Tue, 21 Nov 2023 at 15:16, Rob Herring wrote: > > On Mon, Nov 20, 2023 at 09:20:27PM +0000, Peter Griffin wrote: > > Specifying samsung,uart-fifosize in both DT and driver static data is error > > prone and relies on driver probe order and dt aliases to be correct. > > > > Additionally on many Exynos platforms these are (USI) universal serial > > interfaces which can be uart, spi or i2c, so it can change per board. > > > > For google,gs101-uart and exynosautov9-uart make samsung,uart-fifosize a > > required property. For these platforms fifosize now *only* comes from DT. > > > > It is hoped other Exynos platforms will also switch over time. > > Then allow the property on them. Not sure I fully understand your comment. Can you elaborate? Do you mean leave the 'samsung,uart-fifosize' as an optional property like it is currently even for the platforms that now require it to be present to function correctly? I deliberately restricted the yaml change to only require this property for the SoCs that already set the 'samsung,uart-fifosize' dt property. As setting the property and having the driver use what is specified in DT also requires a corresponding driver update (otherwise fifosize gets overwritten by the driver static data, and then becomes dependent on probe order, dt aliases etc). The rationale was drivers 'opt in' and add themselves to the compatibles in this patch as they migrate away from obtaining fifo size from driver static data to obtaining it from DT. > > > > > Signed-off-by: Peter Griffin > > --- > > .../bindings/serial/samsung_uart.yaml | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml > > index ccc3626779d9..22a1edadc4fe 100644 > > --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml > > +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml > > @@ -133,6 +133,23 @@ allOf: > > - const: uart > > - const: clk_uart_baud0 > > > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - google,gs101-uart > > + - samsung,exynosautov9-uart > > + then: > > + properties: > > + samsung,uart-fifosize: > > + description: The fifo size supported by the UART channel. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [16, 64, 256] > > We already have 'fifo-size' in several drivers. Use that. Please move > its type/description definitions to serial.yaml and make drivers just do > 'fifo-size: true' if they use it. What do you suggest we do for the samsung,uart-fifosize property that is being used upstream? > > > + > > + required: > > + - samsung,uart-fifosize > > A new required property is an ABI break. Please explain why that is okay > in the commit message. > I can update the commit message to make clear there is an ABI break. As mentioned above the platforms where this is now required are either already setting the property or are new in this series. Is that sufficient justification? regards, Peter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel