From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01F9AC61D92 for ; Wed, 22 Nov 2023 08:21:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nQS6yd03XNq4inYxG+/xBUnZXIO7HTeqWMhYd+IJEJA=; b=BfhwUGSVjm956K 4SmYCgOjAbMUWHXA0H6nJYczCWUYmA/PdI9MPJVuQrmLTDMiMo+p15MBYkTCi5QiGublNjxO/DYic ECOCouUIU6D6lAcHEQBaCvNXHf/awxoVKNN5qrHG+S5BEN4e0X2H76vUH/MSbS1ppbP2LK2NoDUPz 1BPJ+TsxMBrMu8l8Wm4kxxWUfHyF2KJdD0sSdWaOWMNtzblUXGoDVOXDpMn0qr2ipXXbkkZqFE1LY rRiSc2kzKSb0TKyRp/GmHsnGh2oyeZUonG9DTyuebJ6QbUpHiwU6qfSTvK7IHHm0uUU2gDB4cKVVD OBp+5Ygb7zezQgIYazLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r5iTl-0012Jw-1U; Wed, 22 Nov 2023 08:21:01 +0000 Received: from mail-vs1-xe2b.google.com ([2607:f8b0:4864:20::e2b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r5iTi-0012J9-2u for linux-arm-kernel@lists.infradead.org; Wed, 22 Nov 2023 08:21:00 +0000 Received: by mail-vs1-xe2b.google.com with SMTP id ada2fe7eead31-46283d552e9so1295317137.1 for ; Wed, 22 Nov 2023 00:20:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700641257; x=1701246057; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4I8dRODFUwv8GNo/5lVqWf42DaYrEmmY1wMx98kbsuI=; b=e+8neZXmFtOPidtS8q2lWEAQuK7tdsP0YiSzixlgSA/DesU7w6Pe0rNLceuLEixV/Y rQWE7UopWkK/93FlFtG7r/7RLR2ySQriYnc/dnZ8+F+02MSDObcjJWLgccZGPpRaQ0rc OkzOXj56bUGYiC2i42H0lHy05gJMzM6hx808hJgHESltOufqH0jViWmFXE80XJKgPNu4 /8xIQIec3BOB2GC4e10ovFxYMs/n4KSebeDRMWpVVXAj9ra8upL5fbpmKss2/zQDurll fnjz1Hx4uF93punmRKWmtTa74KgFdZF5xFblGUxY2Pxx0JkoGbBusRM/fj4fuCJR9ddn exTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700641257; x=1701246057; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4I8dRODFUwv8GNo/5lVqWf42DaYrEmmY1wMx98kbsuI=; b=w+z+SlnDtb9mMQqeAN0Dn/pzf5NMIWw8LWaxKCRtCaLUeFPE8HUr/95D5t1wjntsuV ppEWke09bmjyd6ZydEsWen7SjUMKLCZwuyNZs/8SZ8+Jg3OlpMIMcaq1cSsTUslvoKEi S84Lh7zF9STHsnGPCJyXH+PCK1M4S7Q8cmh/aU9ULXSF8Jm7+m9/b1PJQce0NipDlx4A vUfCQ0BL+WfiaB7Q0TMA7TuPWNvUZlryV55nrgjs6H4t19/kPtidcx/6pLDZNRmqVB4Z rfNmc11gwE3swE2eQrLv4w9CC6ZvgxqNQ8tg9jv0Bab0zImPCphsZgQiaoEs0tmQa0iS +Sqw== X-Gm-Message-State: AOJu0YwKYNIsBzxyMSkN8gabwvujFAvo6ZypurZKeC8zZ+Q0EQ8XLNLG y1HU8Tnv/8owaO6UY03jCSIoVTx7Mi37Mk5oa9Y+HA== X-Google-Smtp-Source: AGHT+IH6MXRD7recCukd9ZPlXrdn9+l+K/d0U/kF9HaOQ28/JOjYehYeGW3YeHAn90fSzCuc3t+BUm1b6U6nd0pNRfU= X-Received: by 2002:a05:6102:108a:b0:462:7f9d:d263 with SMTP id s10-20020a056102108a00b004627f9dd263mr1596382vsr.8.1700641256954; Wed, 22 Nov 2023 00:20:56 -0800 (PST) MIME-Version: 1.0 References: <20231120212037.911774-1-peter.griffin@linaro.org> <20231120212037.911774-16-peter.griffin@linaro.org> <8d838a0b-6a13-4538-8dd6-e044ebfabca7@roeck-us.net> <82df32ea-9ca9-44ac-b1ca-719f68d4f58b@linaro.org> In-Reply-To: <82df32ea-9ca9-44ac-b1ca-719f68d4f58b@linaro.org> From: Peter Griffin Date: Wed, 22 Nov 2023 08:20:43 +0000 Message-ID: Subject: Re: [PATCH v4 15/19] watchdog: s3c2410_wdt: Add support for WTCON register DBGACK_MASK bit To: Krzysztof Kozlowski Cc: Guenter Roeck , Sam Protsenko , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, cw00.choi@samsung.com, alim.akhtar@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231122_002058_938590_0D7F0B1F X-CRM114-Status: GOOD ( 22.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof / Guenter / Sam, On Wed, 22 Nov 2023 at 07:53, Krzysztof Kozlowski wrote: > > On 21/11/2023 19:10, Guenter Roeck wrote: > > >>> static const struct s3c2410_wdt_variant drv_data_gs101_cl1 = { > >>> @@ -291,7 +296,7 @@ static const struct s3c2410_wdt_variant drv_data_gs101_cl1 = { > >>> .cnt_en_reg = GS_CLUSTER1_NONCPU_OUT, > >>> .cnt_en_bit = 7, > >>> .quirks = QUIRK_HAS_PMU_RST_STAT | QUIRK_HAS_PMU_MASK_RESET | QUIRK_HAS_PMU_CNT_EN | > >>> - QUIRK_HAS_WTCLRINT_REG, > >>> + QUIRK_HAS_WTCLRINT_REG | QUIRK_HAS_DBGACK_BIT, > >>> }; > >>> > >> > >> This patch states it's adding the feature, but in fact it's also > >> enabling this feature for gs101. Suggest moving this patch before the > >> one enabling gs101 wdt. This way, one patch will only add the feature, > >> and another patch will enable gs101 entirely (with this feature used). > >> At least it seems like more atomic approach to me. > >> > > > > Both approaches have their merits and their downsides. I for my part am not > > even sure if DBGACK_MASK should be enabled unconditionally if supported. > > With your approach, it would be impossible (or at least more difficult) to > > revert if it turns out to be broken and/or have unexpected side effects. > > That seems less desirable to me than the current approach. > > Reversing the patches does not change this. It is enabled > unconditionally in current order as well. > > Sam's idea is correct here - first you add support for new quirk, then > you add new SoC which will use this quirk. Doing the other way - first > SoC and then new quirk - looks like SoC was added incomplete. Sure I can swap the order around if that's what you prefer. I ordered it this way so it was clear who the user of the new debug feature was. Peter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel