From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54020C4332F for ; Tue, 18 Oct 2022 08:46:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QJ6yFmMElBdRk1bLm/uK1xCavcJxIwFmMc4L95s9f+Y=; b=kSlJFDQ4PIilZp a/WDtrJNY9jbW4/qngdR+enulXyhzJwMImJesVov9A0Fg8nbuSR9Gn+DMyjnbNIKeRkDjSUELWsHt KS1ERBQQcZ1ZIILw5zZbeV3l2MbL6MUBOtk8FyMwEaT0oK7f6hFIaqLZuAuiSnlMJGwfYRTy2Knh/ WlYttJBUr+5Xc4XmCYLDS2CTAclWNMBno0rEyTlxg1t+h8kEIt5vf7fIuCMgTTw5ZlPzwBNwQn5+i ER+1xNmaiWiALUZPXXvOqT0K1LW1U2B/kfBqFbMUPN2WE0B5/xHY/By5Re3bH/mMRSaSua3SLD76v lsv6T1ZnEDJ0SXfn9jHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1okiE9-004Rih-OC; Tue, 18 Oct 2022 08:45:33 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1okiE6-004Rh4-IZ for linux-arm-kernel@lists.infradead.org; Tue, 18 Oct 2022 08:45:31 +0000 Received: by mail-ed1-x534.google.com with SMTP id t16so199106edd.2 for ; Tue, 18 Oct 2022 01:45:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0/8NmRmqGedxeycJ3OB7oM9G22Yz7F5BIQQt6w2lrLI=; b=ZiKrKi0V1pV6ESxIjFxlS0xnTj7mg0J+NYoLpR6OSRtJCxVpqlzGTfplN9sgliOIkj No5dEcD2TvtjurquM6dAVveFJd6wJbTI6liKvD4S0TZpMvuQUZytqqN2tuSLmn8ybrAv L8CP8L2lAY5LDFEkddBLQXNcpSQ/d3ZCCmsMG9sNZiD4GlVjvjY6nb64w3So7SrAVOdR mZmXvvmexVMprLKl+PU1ob029c7ZMdTKWFU4ObH8ApKwqTPqYZp9/dGEwJpw+gy2kJTg lxw/q6KmdJjaClZoV1fPlb/pKvCsXc2QIw2uQLmFMjXdsLusmXuzhc0nNP8bmQHQXQX4 uXqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0/8NmRmqGedxeycJ3OB7oM9G22Yz7F5BIQQt6w2lrLI=; b=RpSi3m7SCUnjWAhRyHFiVIRXvRV12XxOzODK0ifptO34Ic6LmObfqYY3/DRzAckhu0 t4hT6FH5nZb7vdSbt/mGGu34UOE46bdnn8N1x3D3eL96p4Kad0smhHLekoquTQ2rR/uL SXWvgB5PQGqWhGhtJRXK+Zc/VL3dYokN+W8fFyHynfevWa9m1SpQG98FcAnhF3JT+jmi Blx/6IXyAV3w4jzTRU/IsO2UMevPhFWWlBE+JGh+o1vM6a6F2XtOjyYcNUk915t7RIdE ODBXAI6thdfhN5ZCKNxxqJaEfPFxEQ118aFKUNAp9K7obdCulQVXLMGK6jO3T0lf/wTf budA== X-Gm-Message-State: ACrzQf0JJ1PaKhnTgRRIqw0JgT3sEraNP5yNKGEZw9kr3AD8CAKXNkqe 0qwC0NcmqmJfLj7lE65nsOID3JqFOYU4gMJPCehVNjzbz8M= X-Google-Smtp-Source: AMsMyM78Ns5tyMZ7MerCWFuAKME6j6Him7zNR2GHM/CujzZLWMxEH7QwV2tFGWZNKPpCMMGt+lRiCdHcq6N0IfL4zpw= X-Received: by 2002:a05:6402:42c6:b0:45c:fc58:bd0f with SMTP id i6-20020a05640242c600b0045cfc58bd0fmr1647683edc.19.1666082728449; Tue, 18 Oct 2022 01:45:28 -0700 (PDT) MIME-Version: 1.0 References: <20221011082924.884123-1-s.hauer@pengutronix.de> <20221011082924.884123-2-s.hauer@pengutronix.de> In-Reply-To: <20221011082924.884123-2-s.hauer@pengutronix.de> From: Xu Yang Date: Tue, 18 Oct 2022 16:45:16 +0800 Message-ID: Subject: Re: [PATCH 1/6] usb: chipidea: usbmisc_imx: Fix i.MX53 clock sel masks To: Sascha Hauer Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peter Chen , Peng Fan , Pengutronix Kernel Team , devicetree@vger.kernel.org, Xu Yang , jun.li@nxp.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221018_014530_632057_B6D453E4 X-CRM114-Status: GOOD ( 15.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 11, 2022 at 4:50 PM Sascha Hauer wrote: > > According to the reference manual the masks for the > MX53_USB_CTRL_1_H*_XCVR_CLK_SEL bits are 0x3, not 0x11 (which were > probably meant as 0b11). > > Signed-off-by: Sascha Hauer Reviewed-by: Xu Yang Thanks, Xu Yang > --- > drivers/usb/chipidea/usbmisc_imx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c > index bac0f5458cab9..8f805aa9c383c 100644 > --- a/drivers/usb/chipidea/usbmisc_imx.c > +++ b/drivers/usb/chipidea/usbmisc_imx.c > @@ -42,9 +42,9 @@ > #define MX53_USB_OTG_PHY_CTRL_0_OFFSET 0x08 > #define MX53_USB_OTG_PHY_CTRL_1_OFFSET 0x0c > #define MX53_USB_CTRL_1_OFFSET 0x10 > -#define MX53_USB_CTRL_1_H2_XCVR_CLK_SEL_MASK (0x11 << 2) > +#define MX53_USB_CTRL_1_H2_XCVR_CLK_SEL_MASK (0x3 << 2) > #define MX53_USB_CTRL_1_H2_XCVR_CLK_SEL_ULPI BIT(2) > -#define MX53_USB_CTRL_1_H3_XCVR_CLK_SEL_MASK (0x11 << 6) > +#define MX53_USB_CTRL_1_H3_XCVR_CLK_SEL_MASK (0x3 << 6) > #define MX53_USB_CTRL_1_H3_XCVR_CLK_SEL_ULPI BIT(6) > #define MX53_USB_UH2_CTRL_OFFSET 0x14 > #define MX53_USB_UH3_CTRL_OFFSET 0x18 > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel