From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 381BEC43381 for ; Tue, 5 Mar 2019 19:10:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04A90205F4 for ; Tue, 5 Mar 2019 19:10:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GmvMYsUl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="HkL4i1Mk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04A90205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=59OEjKxI55e+eYTRlHnGdFW+UAgegOI34eS7KcO2jqg=; b=GmvMYsUl1SQEYq yWxelml9Lm4fUBDGqFxdPz2HJb1gi3lATIC+kcsktjKqrBeAl5r9iqgp/19TSl8tOB29yn0f9BOq2 4FWZNnvhQqTdAQOmpXnnmOilAcEqPbVM2aHqo7vk+YSzIQhvh4Mb3KnbygDwBklkzO6qgi6e6wEop wpaxBdaw4trYQhx3iDh2lHbUXQGB3XnV69OmbuWLM+BTOcqj7LmafH3fFF5bblZ91vnVZ09NEoC0G CYOQdQQqjlYh9ATSgeG5O5YdKfwDHto8Ili8itfUHGJKtZbbOUCPMsa9hny6/S3ZdltMSiCN6V9Ym g4sHApX+gG66QYpCx7uA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1FSd-0000Aw-MP; Tue, 05 Mar 2019 19:10:43 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1FSZ-0000AJ-QI for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2019 19:10:41 +0000 Received: by mail-lj1-x243.google.com with SMTP id g80so8575746ljg.6 for ; Tue, 05 Mar 2019 11:10:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9eV+w1rVq47KEm/c+5FT1lKhow3a5EjOUVBdcY7lcDw=; b=HkL4i1MkL55mfllBwyKBifkM7QxVHKETERcfYHMqrhCEB9Vkjtn5cF4QhK20H03m/w NB89+Fz9hnc4+SoUycQdBxlFbClHwxiIZ9T2JUgXFiZCtCkNvcwVvi93WQ/c0l5IW+nG Vtp6MGDQWfdBTOmcWzmRxp9k4deVneQyxckXs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9eV+w1rVq47KEm/c+5FT1lKhow3a5EjOUVBdcY7lcDw=; b=G0fM5d6b2uXAk3RW5EI3Hz15gXXDxoiD8P63vyQQ8cLsw5cgy8jo4IlS4tiC0lkNIW cimoWOofSaQkdCcWdloiHequxEdcTsgor7U3AVixoHA8klUfcVWoYA7kDHNANieilk9u kBPFeTsoE59bzGvaamUcs22cFNlOj8ImPCTX/iugB6occLBu6gA5Zd75RWoc8xZvg3p7 FFCWeerLs1+4FPSqhiliBWrWP4BWU4DvvxCatQM2ARhIvdMKFKQsEzvCAfHaJsG1QftC +HBeQA7LmLy7cUWSTWtvwMlzm3UdaexPDVvHGabfG2vFNfwJS+kt3VfucyBJbAH2IbaC QNKg== X-Gm-Message-State: APjAAAVN73BKhs+rhVi+zEnVLhxb23uKo9mdDp7H/zqgwp/1HoL2FdXK b+BAj4jenMvbT9tyCaNmTr/e5vtYi4k= X-Google-Smtp-Source: APXvYqy7osYOQkBBzUIKqTU/XkIYghpnTvXLpkBnnbudSVePfiG+af67qABJs0VX9LY229CXRBoJ5A== X-Received: by 2002:a2e:9a58:: with SMTP id k24mr122766ljj.136.1551813038024; Tue, 05 Mar 2019 11:10:38 -0800 (PST) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com. [209.85.208.174]) by smtp.gmail.com with ESMTPSA id e18sm2259781ljb.2.2019.03.05.11.10.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Mar 2019 11:10:37 -0800 (PST) Received: by mail-lj1-f174.google.com with SMTP id 199so8585180ljj.5 for ; Tue, 05 Mar 2019 11:10:37 -0800 (PST) X-Received: by 2002:a2e:9ad1:: with SMTP id p17mr118058ljj.30.1551812614556; Tue, 05 Mar 2019 11:03:34 -0800 (PST) MIME-Version: 1.0 References: <1546318276-18993-1-git-send-email-yong.wu@mediatek.com> <1546318276-18993-6-git-send-email-yong.wu@mediatek.com> <1551277985.17917.48.camel@mhfsdcap03> In-Reply-To: <1551277985.17917.48.camel@mhfsdcap03> From: Evan Green Date: Tue, 5 Mar 2019 11:02:58 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 05/13] memory: mtk-smi: Add device-link between smi-larb and smi-common To: Yong Wu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_111039_862561_40424A80 X-CRM114-Status: GOOD ( 27.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Nicolas Boichat , Arnd Bergmann , srv_heupstream@mediatek.com, Greg Kroah-Hartman , Joerg Roedel , Will Deacon , LKML , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , yingjoe.chen@mediatek.com, Robin Murphy , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 27, 2019 at 6:33 AM Yong Wu wrote: > > On Mon, 2019-02-25 at 15:54 -0800, Evan Green wrote: > > On Mon, Dec 31, 2018 at 8:52 PM Yong Wu wrote: > > > > > > Normally, If the smi-larb HW need work, we should enable the smi-common > > > HW power and clock firstly. > > > This patch adds device-link between the smi-larb dev and the smi-common > > > dev. then If pm_runtime_get_sync(smi-larb-dev), the pm_runtime_get_sync > > > (smi-common-dev) will be called automatically. > > > > > > Since smi is built-in driver like IOMMU and never unbound, > > > DL_FLAG_AUTOREMOVE_* is not needed. > > > > > > CC: Matthias Brugger > > > Suggested-by: Tomasz Figa > > > Signed-off-by: Yong Wu > > > --- > > > drivers/memory/mtk-smi.c | 16 +++++++--------- > > > 1 file changed, 7 insertions(+), 9 deletions(-) > > > > > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > > > index 9688341..30930e4 100644 > > > --- a/drivers/memory/mtk-smi.c > > > +++ b/drivers/memory/mtk-smi.c > > > @@ -271,6 +271,7 @@ static int mtk_smi_larb_probe(struct platform_device *pdev) > > > struct device *dev = &pdev->dev; > > > struct device_node *smi_node; > > > struct platform_device *smi_pdev; > > > + struct device_link *link; > > > > > > larb = devm_kzalloc(dev, sizeof(*larb), GFP_KERNEL); > > > if (!larb) > > > @@ -310,6 +311,12 @@ static int mtk_smi_larb_probe(struct platform_device *pdev) > > > if (!platform_get_drvdata(smi_pdev)) > > > return -EPROBE_DEFER; > > > larb->smi_common_dev = &smi_pdev->dev; > > > + link = device_link_add(dev, larb->smi_common_dev, > > > + DL_FLAG_PM_RUNTIME); > > > > Doesn't this need to be torn down in remove()? You mention that it's > > built-in and never removed, but it does seem to have a remove() > > The MTK IOMMU driver need depend on this SMI driver. the IOMMU is a > builtin driver, thus the SMI also should be a builtin driver. > > Technically, If the driver is builtin, then the "remove" function can be > removed? If yes, I could use a new patch do it. Yeah, I guess so. It's always sad to see cleanup code getting removed, but it makes sense to me. > > It looks the MACRO(builtin_platform_driver) only support one driver, but > we have two driver(smi-common and smi-larb) here. > > > function that tears down everything else, so it seemed a shame to > > start leaking now. Maybe the AUTOREMOVE flag would do it. > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel