From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64A31C282CE for ; Tue, 9 Apr 2019 17:34:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37EBE20883 for ; Tue, 9 Apr 2019 17:34:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GcVicVP3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V4cPP5Z1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37EBE20883 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1i0YdA7oRxoufBWxAIfnB2HTkfdWBAhqP+HckHO9MsA=; b=GcVicVP39i54RB RF5qFIQ2gJknDakVl9RzVZqO1eOP4KiJQl+w95fIGiKV6dm/QUvi2CfGzSo66L0I3rVOvYlM+N1g0 a8+aYJEJpEuzaSuJZaJj3v5XLbd7wjo+DRY+VP/o9PFg03W4zPpUp+JmplblggcCM/HQL+rM32Pvq ityZSR4S+uOMY4v4iU3zizGofR7eB5aRm/4YNL3ohSQN3pl/MKmskNEc/7o0pv4VegQXIBNnj15Xz topMdwkNfSFbpZ5x2X/b7YbHSI9ZWmM0qZbWozW+YE7f+pJIWMhM0UZvWNWpMXPFRvGsuVZQbJMrx ka3tcrptZ6tZgiWvvpCw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDue7-000831-CI; Tue, 09 Apr 2019 17:34:55 +0000 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDue4-00082d-2D for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2019 17:34:53 +0000 Received: by mail-io1-xd42.google.com with SMTP id v10so15016529iom.8 for ; Tue, 09 Apr 2019 10:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rz0aDV9OpL7jI4BvLfVtUPXYDaxQQtRxUY20Zf2oyXA=; b=V4cPP5Z1XaSRh22nIlFhsmpyRfDYa8UWb1HsXVs8OZuswciCnnEcVSISsEZJiHnk1V qYKFyr/Yll8t4jblcabWIHrJRF7tJuOAchbdMxdGNNFpRXYFG3pun03jrHdWHE8ifKBA PiXodOqEpex9gAeIFLU/9uMAw5faKABA8F+N/jEAPYv+grWroEp6urIwGjmJDIq8GUWx 7uGVjIsF6EcG/0vLmSSZYfGA7VUY5PWshFOXmooyFgBHptE90fUsvN6bv5EG9YpA06+6 gymIY0seAkNn/s9945zkzSt6le49neQV7Hjofp4Suc4RdU0trKDoxksvGZTFe7tBRZ9b K6bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rz0aDV9OpL7jI4BvLfVtUPXYDaxQQtRxUY20Zf2oyXA=; b=WRHO++7XtwNBVmzOG+ksALX/IIXYfa7zQrZr6rPyYbfjPYQmzDTSk2apxDxFiMjtAc cowDrnrx6qVlD4+Q/dJ/+TjymUOIjWmq3XGv/QShjeDSjCuKqJ2wj+iq2Ew0FKThC7AR dZLR6vK+1qXSyaLMV1kflFKaw2tzhB9h2FRs1Qk5DmSJaA8+3zDe/3kbpTnzHX0IzrQq GbLEunDqH8SARTr1J1bFw/SEO2Pn+JOklAtUvPi2NoVV5Pks1ASWDHuFKvv4tz/6rI42 AM0wLi+UsLknfDq6afHJyxxtXXs28N/H6wwNEg+tEjUDTFugFfdkUV93EbfDqPH49/sb xoIw== X-Gm-Message-State: APjAAAV6TRIHk1xiNFatjuLF2ycg11/9QI6FRtgW0azcIKtf9/R+uSDV xDkCpj7KLuxRSCWUVEkNwMwGfpgxh84mbul/T8Y= X-Google-Smtp-Source: APXvYqyERUnrii6LK2LZodMbjTA8prA8ZWqOH31IgCG6z/FH1RCv3CMJEdtL6bkUMlz2iEjnfrwb3wt+5J4T+ezP888= X-Received: by 2002:a6b:b797:: with SMTP id h145mr17061971iof.190.1554831290887; Tue, 09 Apr 2019 10:34:50 -0700 (PDT) MIME-Version: 1.0 References: <20190405102455.15311-1-tiny.windzz@gmail.com> <20190405102455.15311-3-tiny.windzz@gmail.com> <20190409100730.2rtxyy66knjning6@vireshk-i7> In-Reply-To: <20190409100730.2rtxyy66knjning6@vireshk-i7> From: Frank Lee Date: Wed, 10 Apr 2019 01:34:39 +0800 Message-ID: Subject: Re: [PATCH 2/2] dt-bindings: cpufreq: Document operating-points-v2-sunxi-cpu To: Viresh Kumar X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190409_103452_106360_458BD760 X-CRM114-Status: GOOD ( 13.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, mark.rutland@arm.com, Linux PM , Maxime Ripard , vireshk@kernel.org, rjw@rjwysocki.net, Linux Kernel Mailing List , sboyd@kernel.org, Chen-Yu Tsai , robh+dt@kernel.org, Linux ARM , Greg Kroah-Hartman , mchehab+samsung@kernel.org, davem@davemloft.net, devicetree@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 9, 2019 at 6:07 PM Viresh Kumar wrote: > > On 05-04-19, 06:24, Yangtao Li wrote: > > +++ b/Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt > > + cpus { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + cpu0: cpu@0 { > > + compatible = "arm,cortex-a53"; > > + device_type = "cpu"; > > + reg = <0>; > > + enable-method = "psci"; > > + clocks = <&ccu CLK_CPUX>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + operating-points-v2 = <&cpu_opp_table>; > > + #cooling-cells = <2>; > > + }; > > + > > + cpu1: cpu@1 { > > + compatible = "arm,cortex-a53"; > > + device_type = "cpu"; > > + reg = <1>; > > + enable-method = "psci"; > > + clocks = <&ccu CLK_CPUX>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + operating-points-v2 = <&cpu_opp_table>; > > + #cooling-cells = <2>; > > + }; > > + > > + cpu2: cpu@2 { > > + compatible = "arm,cortex-a53"; > > + device_type = "cpu"; > > + reg = <2>; > > + enable-method = "psci"; > > + clocks = <&ccu CLK_CPUX>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + operating-points-v2 = <&cpu_opp_table>; > > + #cooling-cells = <2>; > > + }; > > + > > + cpu3: cpu@3 { > > + compatible = "arm,cortex-a53"; > > + device_type = "cpu"; > > + reg = <3>; > > + enable-method = "psci"; > > + clocks = <&ccu CLK_CPUX>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + operating-points-v2 = <&cpu_opp_table>; > > + #cooling-cells = <2>; > > + }; > > + }; > > + > > + cpu_opp_table: opp_table { > > + compatible = "operating-points-v2-sunxi-cpu"; > > + nvmem-cells = <&speedbin_efuse>; > > + opp-shared; > > + > > + opp-480000000-0 { > > + opp-hz = /bits/ 64 <480000000>; > > + opp-microvolt = <880000>; > > + opp-supported-hw = <0x1>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + opp-720000000-0 { > > + opp-hz = /bits/ 64 <720000000>; > > + opp-microvolt = <880000>; > > + opp-supported-hw = <0x1>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + opp-816000000-0 { > > + opp-hz = /bits/ 64 <816000000>; > > + opp-microvolt = <880000>; > > + opp-supported-hw = <0x1>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + opp-888000000-0 { > > + opp-hz = /bits/ 64 <888000000>; > > + opp-microvolt = <940000>; > > + opp-supported-hw = <0x1>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + opp-1080000000-0 { > > + opp-hz = /bits/ 64 <1080000000>; > > + opp-microvolt = <1060000>; > > + opp-supported-hw = <0x1>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + opp-1320000000-0 { > > + opp-hz = /bits/ 64 <1320000000>; > > + opp-microvolt = <1160000>; > > + opp-supported-hw = <0x1>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + opp-1488000000-0 { > > + opp-hz = /bits/ 64 <1488000000>; > > + opp-microvolt = <1160000>; > > + opp-supported-hw = <0x1>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + > > + opp-480000000-1 { > > + opp-hz = /bits/ 64 <480000000>; > > + opp-microvolt = <820000>; > > + opp-supported-hw = <0x2>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + opp-720000000-1 { > > + opp-hz = /bits/ 64 <720000000>; > > + opp-microvolt = <820000>; > > + opp-supported-hw = <0x2>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + opp-816000000-1 { > > + opp-hz = /bits/ 64 <816000000>; > > + opp-microvolt = <820000>; > > + opp-supported-hw = <0x2>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + opp-888000000-1 { > > + opp-hz = /bits/ 64 <888000000>; > > + opp-microvolt = <820000>; > > + opp-supported-hw = <0x2>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + opp-1080000000-1 { > > + opp-hz = /bits/ 64 <1080000000>; > > + opp-microvolt = <880000>; > > + opp-supported-hw = <0x2>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + opp-1320000000-1 { > > + opp-hz = /bits/ 64 <1320000000>; > > + opp-microvolt = <940000>; > > + opp-supported-hw = <0x2>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + opp-1488000000-1 { > > + opp-hz = /bits/ 64 <1488000000>; > > + opp-microvolt = <1000000>; > > + opp-supported-hw = <0x2>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + > > + opp-480000000-2 { > > + opp-hz = /bits/ 64 <480000000>; > > + opp-microvolt = <800000>; > > + opp-supported-hw = <0x4>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + opp-720000000-2 { > > + opp-hz = /bits/ 64 <720000000>; > > + opp-microvolt = <800000>; > > + opp-supported-hw = <0x4>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + opp-816000000-2 { > > + opp-hz = /bits/ 64 <816000000>; > > + opp-microvolt = <800000>; > > + opp-supported-hw = <0x4>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + opp-888000000-2 { > > + opp-hz = /bits/ 64 <888000000>; > > + opp-microvolt = <800000>; > > + opp-supported-hw = <0x4>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + opp-1080000000-2 { > > + opp-hz = /bits/ 64 <1080000000>; > > + opp-microvolt = <840000>; > > + opp-supported-hw = <0x4>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + opp-1320000000-2 { > > + opp-hz = /bits/ 64 <1320000000>; > > + opp-microvolt = <900000>; > > + opp-supported-hw = <0x4>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + opp-1488000000-2 { > > + opp-hz = /bits/ 64 <1488000000>; > > + opp-microvolt = <960000>; > > + opp-supported-hw = <0x4>; > > + clock-latency-ns = <244144>; /* 8 32k periods */ > > + }; > > + }; > > Well, this is pure duplication of all the OPPs which isn't great. If I have > understood things correctly from the above example, then all you want is a > different microvolt value for each OPP, right ? Not exactly like this. But this is working for the current situation. > > Then you are using the wrong feature of OPP core I am afraid. What you should > rather look for is opp-microvolt- property, look in opp.txt bindings. Yeah. This is more appropriate. > > And these are the helper you need to use: > dev_pm_opp_set_prop_name()/dev_pm_opp_put_prop_name(). Thanks, Yangtao > > -- > viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel