From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7F8DC48BD3 for ; Wed, 26 Jun 2019 12:42:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EE912133F for ; Wed, 26 Jun 2019 12:42:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FHdnXPO0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="telupOue" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EE912133F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5boQxpmBpQhcGX3NjXKvxGsMy+nJHzDNxGEkeVOEkbI=; b=FHdnXPO0nZpxTd /J4y2Dx+dCj/+jd+qvCLEnpPovUJDRo2Iq03Ys8skhOe0RpjoSSS7yp0iS3buFRGLnHevxfFxGAXA mZUgx1fhh70De/abT1SnXJyCJjVZsnSfEk1oOoOTfKaoTawv0cZVFnd9gYx3TOGSqVnBH7eUUZ5AV d5QUFGuK8Om8G/zdWWKJ1rFlStNR/obO+7gLZ5EAHJDBi+bYsr0XXvKf9qOVBwz9IDkHK9YK68kfZ /98A4J+SDhIJBIkPOHCrqTlsaBuvvIPYwpvT4qgpO02LflOnWJ22RAbDjVHj2Mfuzd5n8WdurY6gQ h5MRYdPgRUNWPc5VO6zw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hg7Fb-00076N-Mm; Wed, 26 Jun 2019 12:42:11 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hg7FY-00075V-CQ for linux-arm-kernel@lists.infradead.org; Wed, 26 Jun 2019 12:42:09 +0000 Received: by mail-wm1-x344.google.com with SMTP id v19so1946443wmj.5 for ; Wed, 26 Jun 2019 05:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/89S57mpuhANqW7P0SQuk594h6BbB5jqPDSQ9Ds3jmA=; b=telupOueO49ezANV6MQ9EP6YOmXIXr3OEqq4W2xMbkHOazxjKzw6L5r+7c3baP7aQw Dy0tp1ggBs4bVBadpnGIQ9dkM+WLRGom/doa5TEgaRI2VYef8ZRiytfaVUaTg0G4BUzk 0BbUel2tFKFOJ/xiwl2uTdiG1JgTb0beJ65TZRC+iDFzCizZ+mmDIQ77RutpM4d5mIC2 1ygaaz5tnB7cv3SUQV0+W5NbCbzdpp/uc+FY51Dg6cGyY7geNRpWjX/Zxu+jj2xwhgoo 4ub8y+pd1gCHMlwMy0SGFnSpG5VQMMbPdbx02mkw+e/jRv26oy7C4WlaZUjet4Za+u0Z avfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/89S57mpuhANqW7P0SQuk594h6BbB5jqPDSQ9Ds3jmA=; b=c4+mG7G0j5lspdrFOZipJspzi6nlvfaGODqWmsVg4XvEicifs5mDu8oIo3t3nbgPaM VIDOkYq4JEjVk3ptgVGljVqN7wFxCqCCES9C3axQHskD5w1bV6OkERI98B8FFmkIRp7j PIAKQfX5P+crKLuggBvYtnMLvGdb2DD03FedA0KFdA8B4EY2TKhfQP/o9UbSzQbyO4fG PAW4HxugqMW3soSuWEeMZVs3pP0Qk56b0DmEHU1gRyiTgzDKNp8fmtlQucESM0AvfydF Re1HLYdRzWY46qTqK0tPL7u9XzKg64kqtuLh9wwDcd1ejNXDE5LM6Vm5QrMMWxlMSj8Z E31A== X-Gm-Message-State: APjAAAWUr6rD6pQgtpvJNN7UW36RyTK6041S4th2dPdGs5pKLE1gaekH yVmCkUjqyOrdt6PVYsF4K4SICVR9Mit6QHCpPu0= X-Google-Smtp-Source: APXvYqzEfG/o6BpKhYhz+f0gbYiJr1+1nFyKt/FO8KIHz8nHEc7l11ldGst5RGwz25NqYdt6zog6+MR/Rj+QBG17bbo= X-Received: by 2002:a7b:c051:: with SMTP id u17mr2584418wmc.25.1561552926103; Wed, 26 Jun 2019 05:42:06 -0700 (PDT) MIME-Version: 1.0 References: <20190626070706.24930-1-Anson.Huang@nxp.com> In-Reply-To: <20190626070706.24930-1-Anson.Huang@nxp.com> From: Daniel Baluta Date: Wed, 26 Jun 2019 15:41:54 +0300 Message-ID: Subject: Re: [PATCH] soc: imx-scu: Add SoC UID(unique identifier) support To: Anson Huang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190626_054208_451159_CA0A2859 X-CRM114-Status: GOOD ( 16.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , Abel Vesa , Shawn Guo , Sascha Hauer , Linux Kernel Mailing List , Daniel Baluta , dl-linux-imx , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 26, 2019 at 10:06 AM wrote: > > From: Anson Huang > > Add i.MX SCU SoC's UID(unique identifier) support, user > can read it from sysfs: > > root@imx8qxpmek:~# cat /sys/devices/soc0/soc_uid > 7B64280B57AC1898 > > Signed-off-by: Anson Huang > --- > drivers/soc/imx/soc-imx-scu.c | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/drivers/soc/imx/soc-imx-scu.c b/drivers/soc/imx/soc-imx-scu.c > index 676f612..8d322a1 100644 > --- a/drivers/soc/imx/soc-imx-scu.c > +++ b/drivers/soc/imx/soc-imx-scu.c > @@ -27,6 +27,36 @@ struct imx_sc_msg_misc_get_soc_id { > } data; > } __packed; > > +struct imx_sc_msg_misc_get_soc_uid { > + struct imx_sc_rpc_msg hdr; > + u32 uid_low; > + u32 uid_high; > +} __packed; > + > +static ssize_t soc_uid_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct imx_sc_msg_misc_get_soc_uid msg; > + struct imx_sc_rpc_msg *hdr = &msg.hdr; > + u64 soc_uid; > + > + hdr->ver = IMX_SC_RPC_VERSION; > + hdr->svc = IMX_SC_RPC_SVC_MISC; > + hdr->func = IMX_SC_MISC_FUNC_UNIQUE_ID; > + hdr->size = 1; > + > + /* the return value of SCU FW is in correct, skip return value check */ Why do you mean by "in correct"? > + imx_scu_call_rpc(soc_ipc_handle, &msg, true); > + > + soc_uid = msg.uid_high; > + soc_uid <<= 32; > + soc_uid |= msg.uid_low; > + > + return sprintf(buf, "%016llX\n", soc_uid); snprintf? > +} > + > +static DEVICE_ATTR_RO(soc_uid); > + > static int imx_scu_soc_id(void) > { > struct imx_sc_msg_misc_get_soc_id msg; > @@ -102,6 +132,11 @@ static int imx_scu_soc_probe(struct platform_device *pdev) > goto free_revision; > } > > + ret = device_create_file(soc_device_to_device(soc_dev), > + &dev_attr_soc_uid); > + if (ret) > + goto free_revision; > + > return 0; > > free_revision: > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel