From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 591B8C282C4 for ; Tue, 12 Feb 2019 12:55:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 274982084E for ; Tue, 12 Feb 2019 12:55:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mXBOlZab"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RhSFa4SB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 274982084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zVsfxEBJ5OFcx+GXXbsJT+if7YzVJ5LqdI57Fbdu9ZE=; b=mXBOlZablq5Thh 0UezP4yEF+FYNYE+MnscnXyglGwxrMLJ2dYWc6IjXf6AkPJVeT4F6GTATHiCR9a8pBW4hdlbmFIJr fT+nrLj6dAVhH3HnftH81CIbjq/aYXV6FhKPXjU2Z5OjqvPgb2aPiQ5HN2Fb8M1FWM5O3b+uqqPnH cP+8q9g7YMQQpi1nFSJwU1Mbzn1WDjA0MHVqPuejgj2URMoCsH0uUvivFDcl+Mp13nQFkKuappaDV WOtC7VF1zLMIR+8pisAdqQrps8FEYrdbXDpYzhVfnN+VD0siDvvpL9gVdq2HTDXwxtYttGuwuOCpr x5DOMMJZrsaLY4k6hEPQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtXax-0000gA-3Q; Tue, 12 Feb 2019 12:55:27 +0000 Received: from mail-vs1-xe43.google.com ([2607:f8b0:4864:20::e43]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtXat-0000fn-Cs for linux-arm-kernel@lists.infradead.org; Tue, 12 Feb 2019 12:55:25 +0000 Received: by mail-vs1-xe43.google.com with SMTP id t7so1490310vsq.5 for ; Tue, 12 Feb 2019 04:55:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DIKige9dZTqFRJNAYb0OrMSYW+c/EwZN2KD7sQCZWWk=; b=RhSFa4SBU71AwfbOX/ckWSqd1dgUUFcc5nU+Y1fM2ZFY09PPQSBu8JvXQ9IB15vtyR FEr5zx8sf/niYS3KPCOXKURMizWaGwgRRODuX15K8z+jPV6Mfw2j9XIytne7mrj6wG73 +OPtMwZk/VzFzVduhu5lyWus85ODvwbFCNm65B6UGfh9GnatRF4Sib16XV1x4mf6rMNc yaoDp7NUXNICrry8ivgjQzKd8odQjY0Nr16G8P0cvTSkOls/YlxgJ0KAhBvqGWhyYo8Z T/Jtqiz/xadhFpsFP0DCYvB8SiE0fWRoz3x+k1fD5GtXvMPUUZmgmHCVywmWInxk+TnA 4iIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DIKige9dZTqFRJNAYb0OrMSYW+c/EwZN2KD7sQCZWWk=; b=GRlM1mgRBFsG0nDYNypzw/OcVaMiLK8SH1jhfsxL4tZkOyw+8uqQ7IZ5A9goez9DKu v1EmQ2YFYeGhrmJfQonWZsiRZZHEH/eF06TEC9LXj3wLuCojjXwUtfw6Mf65LxY6hthU MOYEMe3vskvWDaGTxwbJWsQEgeUs37KFi7RIwkmtKLL048QWUWNUudPWXNWuWxjkn6Rf ZWHzcgip8VaVsb6QE3lDwnQeSf5rLVgfPKtxWKsr8EQy4kyFD+R3wJnHKpWzVWurFevY hhK8jQDFiP7YwGxMUyjKJm/wx69ulYHIJZ7wnoTnY7GCmivaP4HlnELy/6rPhCZEHi7E TB3w== X-Gm-Message-State: AHQUAuaHrvR2jUVYTu/Wg731v/gEjMdMt6zAoAIPZhICdfXSPao0O9xv bAuYG6qp1B9gqBjNqVIrW2tNO9WDWJn+IcqhICtsXQ== X-Google-Smtp-Source: AHgI3IbDIthD0Ym9Rg/49mRggo17etucCnnaz65WXx6Em8M/NOOTNU5hTHN03iuXg7bvLt7l7QnzIbv1kTCc+LoiitU= X-Received: by 2002:a67:8cc2:: with SMTP id o185mr1384485vsd.55.1549976122034; Tue, 12 Feb 2019 04:55:22 -0800 (PST) MIME-Version: 1.0 References: <1548740978-28495-1-git-send-email-sumit.garg@linaro.org> In-Reply-To: From: Sumit Garg Date: Tue, 12 Feb 2019 18:25:11 +0530 Message-ID: Subject: Re: [PATCH v6 0/4] Introduce TEE bus driver framework To: Ard Biesheuvel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190212_045523_452012_417D3DB2 X-CRM114-Status: GOOD ( 23.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Daniel Thompson , Michal Marek , Herbert Xu , Arnd Bergmann , Greg Kroah-Hartman , Bhupesh Sharma , Linux Kernel Mailing List , tee-dev@lists.linaro.org, Masahiro Yamada , Rob Herring , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Matt Mackall , Jens Wiklander , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 12 Feb 2019 at 17:41, Ard Biesheuvel wrote: > > On Tue, 12 Feb 2019 at 13:09, Sumit Garg wrote: > > > > On Tue, 12 Feb 2019 at 16:35, Ard Biesheuvel wrote: > > > > > > On Tue, 29 Jan 2019 at 06:50, Sumit Garg wrote: > > > > > > > > This series introduces a generic TEE bus driver concept for TEE based > > > > kernel drivers which would like to communicate with TEE based devices/ > > > > services. > > > > > > > > Patch #1 adds TEE bus concept where devices/services are identified via > > > > Universally Unique Identifier (UUID) and drivers register a table of > > > > device UUIDs which they can support. This concept also allows for device > > > > enumeration to be specific to corresponding TEE implementation like > > > > OP-TEE etc. > > > > > > > > Patch #2 adds supp_nowait flag for non-blocking requests arising via > > > > TEE internal client interface. > > > > > > > > Patch #3 adds TEE bus device enumeration support for OP-TEE. OP-TEE > > > > provides a pseudo TA to enumerate TAs which can act as devices/services > > > > for TEE bus. > > > > > > > > Patch #4 adds OP-TEE based hwrng driver which act as TEE bus driver. > > > > On ARM SoC's with TrustZone enabled, peripherals like entropy sources > > > > might not be accessible to normal world (linux in this case) and rather > > > > accessible to secure world (OP-TEE in this case) only. So this driver > > > > aims to provides a generic interface to OP-TEE based random number > > > > generator service. > > > > > > > > Example case is Developerbox based on Socionext's Synquacer SoC [1] > > > > which provides 7 thermal sensors accessible from secure world only which > > > > could be used as entropy sources (thermal/measurement noise). > > > > > > > > [1] https://www.96boards.org/product/developerbox/ > > > > > > > > Changes in v6: > > > > > > > > 1. Incorporate some nitpicks in patch #1 and #3. > > > > 2. Bundle all statics in a data structure in patch #4 and use dev_* > > > > instead of pr_*. > > > > 3. Add reviewed-by tags for patch #1, #2 and #3. > > > > > > > > Changes in v5: > > > > > > > > 1. Add support in module device table for TEE bus devices. > > > > 2. Correct license for optee-rng module. > > > > > > > > Changes in v4: > > > > > > > > 1. Use typedef instead of single member tee_client_device_id struct. > > > > 2. Incorporate TEE bus nitpicks. > > > > > > > > Changes in v3: > > > > > > > > 1. Fixed bus error path in Patch #1. > > > > 2. Reversed order of Patch #2 and #3. > > > > 3. Fixed miscellaneous syntax comments and memory leak. > > > > 4. Added comments in Patch #2 for supp_nowait flag. > > > > > > > > Changes in v2: > > > > > > > > Based on review comments, the scope of this series has increased as > > > > follows: > > > > > > > > 1. Added TEE bus driver framework. > > > > 2. Added OP-TEE based device enumeration. > > > > 3. Register optee-rng driver as TEE bus driver. > > > > 4. Removed DT dependency for optee-rng device UUID. > > > > 5. Added supp_nowait flag. > > > > > > > > Sumit Garg (4): > > > > tee: add bus driver framework for TEE based devices > > > > tee: add supp_nowait flag in tee_context struct > > > > tee: optee: add TEE bus device enumeration support > > > > hwrng: add OP-TEE based rng driver > > > > > > > > > > For this series > > > > > > Tested-by: Ard Biesheuvel > > > > > > > Thanks. BTW, Jens has created a GIT PULL[1] to incorporate this patch-set. > > > > > although I had to load optee.ko manually in order for the udev > > > autoload of optee_rng to trigger. > > > > Did you built OP-TEE module as out-of-tree? OP-TEE by-default is > > built-in kernel module as per following configs in default defconfig: > > > > CONFIG_TEE=y > > CONFIG_OPTEE=y > > > > Yes, but the distros will carry it as a module. > Hmm, I see. So in this case OP-TEE module needs to be loaded manually due to missing modalias for udev autoload. -Sumit > > > Not sure where the discussion went > > > last time, but could we please add "linaro,optee-tz" as a DT modalias > > > to the optee.ko module in any case? > > > > > > > This change is already part of your RFC patch [2] and I agree to make > > OP-TEE as platform driver. > > > > [1] https://lkml.org/lkml/2019/2/4/104 > > [2] https://lkml.org/lkml/2018/12/27/196 > > > > Indeed, but iirc there was a question from Jens and I wasn't sure it > had been answered in the mean time. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel