From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3815C433E0 for ; Thu, 4 Mar 2021 10:02:36 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EB3164F23 for ; Thu, 4 Mar 2021 10:02:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EB3164F23 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JtN31nUXMpw2LI45rv8s4kpN91Ri9qv4Jy/3bMRBaok=; b=gnHs2apwoqAOYioAdKT8hLAnj L+Xu0To5aD7ks6Rw3R0S4vG4dzHw8DYpKkMXRTrp0YiiSXlsk1IizyGa4oIeoCg8unen7PXwIV7KW MyQXWzRaf6DKyUO1x2Rl5uNuLoUrTaBl8x2M8ZroOpmeZWRrPXN1gGXezrZogSPjNrVULBNpwtn64 eQd1Fojq1E7+LnQlk0zbOABtVeHh//fZCHhEzhc0o7Ten39MShOGAVdK1L3JaqjDjltuxKlBZrbh9 9kXVDhaN6L6PbaC1+I9liG7WR4Jl2uYtE/Fr0NTjxWqLONfdXuFNqw1nbEUm0yJb+sfsWZSWmzEFG mydotWNqQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHkmi-008KUa-1d; Thu, 04 Mar 2021 10:00:44 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHkmY-008KTN-Su for linux-arm-kernel@lists.infradead.org; Thu, 04 Mar 2021 10:00:37 +0000 Received: by mail-lf1-x12e.google.com with SMTP id p21so42137575lfu.11 for ; Thu, 04 Mar 2021 02:00:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R+fyz1Gmo60Jzev6gG0weSOoqYLjk+pWR3oPV5MKoDA=; b=lCDW9qJOuKrhpjESaUjTrpzFc1bcy7QBYhT7TcfsnuwLoRMbe1vBr6ymXsligO+5jG sTneNJj8Lo/s0urIihtY1H8SXSXSMc0VPdePAkij11jLBKd6FP7z75Hhs/Q9YwntF3TE G22+pN90TDJgrRLb6J7+yM0URNfEbiQvrrFK/DTy8p1Br8WUQY/D81lv+oS6NhRELZMp XkyXefNOX+vyFG1WYPbOIOHFaqe+4SYCxjv0b/xioHR1/1QcZEtdOx1Occz4q/dBYc2P 2GGiiDVv7cvyezNdlPriPrhRL76yr8WAKE4nqpuFVw1UnJhcafnu1jt7dyRunIGH6Kvc jmYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R+fyz1Gmo60Jzev6gG0weSOoqYLjk+pWR3oPV5MKoDA=; b=irTO9rWr8BEoQVkQAFOwQgd529TY622N8xc100c0tYG20YeXKvWDTnER1xToEA5A7w IBcTpJPtBNB6m4ESctjuUyo2nxtI+usXE3e+NAQ7daBOit1s0Xa4KK6Ff2xaqoZWBric Lepmve9W5k5z3bzSlDEMVQ9+F6Y2dIVlHz1aaZ4z4E3VrE71xJPhwFr7kxRx9ZzWqjPM s3wmhfoXx8HYtxKyRzwIWij17K0H0fhfyb9FD2yaYZ5cQ9NBqgEmYqFLP/GAa8V1Iz/V D8P/JSmCUJoV3vseUHI+L/DKI/Ix4gJq889P9aPX6uMzZxoQRqXJYKUIuCjYIjtpBwW9 yATA== X-Gm-Message-State: AOAM53065jT7adT7g/mkTEF4MvG2pN6jRygRtQ+/yJSIZuOjYYSMEsqm BnUwtUxK055C9FTCDNXaHRD81HtNyOygPHP2yg+dgg== X-Google-Smtp-Source: ABdhPJwXlOd8DBkLy9Zlmb+SghsS4EzhmtWT2+RyLbpljz0AiTWuutSp5GiA//NnHMof1wzIFvt/4DAQincSik0zAuE= X-Received: by 2002:ac2:4d9b:: with SMTP id g27mr1920444lfe.113.1614852030131; Thu, 04 Mar 2021 02:00:30 -0800 (PST) MIME-Version: 1.0 References: <20210301131127.793707-1-sumit.garg@linaro.org> In-Reply-To: <20210301131127.793707-1-sumit.garg@linaro.org> From: Sumit Garg Date: Thu, 4 Mar 2021 15:30:18 +0530 Message-ID: Subject: Re: [PATCH v9 0/4] Introduce TEE based Trusted Keys support To: Jarkko Sakkinen Cc: Mimi Zohar , James Bottomley , David Howells , Jens Wiklander , Jonathan Corbet , James Morris , "Serge E. Hallyn" , Casey Schaufler , Janne Karhunen , Daniel Thompson , Markus Wamser , Luke Hinds , Elaine Palmer , Ahmad Fatoum , "open list:ASYMMETRIC KEYS" , linux-integrity@vger.kernel.org, "open list:SECURITY SUBSYSTEM" , Linux Doc Mailing List , Linux Kernel Mailing List , linux-arm-kernel , op-tee@lists.trustedfirmware.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jarkko, On Mon, 1 Mar 2021 at 18:41, Sumit Garg wrote: > > Add support for TEE based trusted keys where TEE provides the functionality > to seal and unseal trusted keys using hardware unique key. Also, this is > an alternative in case platform doesn't possess a TPM device. > > This patch-set has been tested with OP-TEE based early TA which is already > merged in upstream [1]. > > [1] https://github.com/OP-TEE/optee_os/commit/f86ab8e7e0de869dfa25ca05a37ee070d7e5b86b > > Changes in v9: > 1. Rebased to latest tpmdd/master. > 2. Defined pr_fmt() and removed redundant tags. > 3. Patch #2: incorporated misc. comments. > 4. Patch #3: incorporated doc changes from Elaine and misc. comments > from Randy. > 5. Patch #4: reverted to separate maintainer entry as per request from > Jarkko. > 6. Added Jarkko's Tested-by: tag on patch #2. It looks like we don't have any further comments on this patch-set. So would you be able to pick up this patch-set? -Sumit > > Changes in v8: > 1. Added static calls support instead of indirect calls. > 2. Documented trusted keys source module parameter. > 3. Refined patch #1 commit message discription. > 4. Addressed misc. comments on patch #2. > 5. Added myself as Trusted Keys co-maintainer instead. > 6. Rebased to latest tpmdd master. > > Changes in v7: > 1. Added a trusted.source module parameter in order to enforce user's > choice in case a particular platform posses both TPM and TEE. > 2. Refine commit description for patch #1. > > Changes in v6: > 1. Revert back to dynamic detection of trust source. > 2. Drop author mention from trusted_core.c and trusted_tpm1.c files. > 3. Rebased to latest tpmdd/master. > > Changes in v5: > 1. Drop dynamic detection of trust source and use compile time flags > instead. > 2. Rename trusted_common.c -> trusted_core.c. > 3. Rename callback: cleanup() -> exit(). > 4. Drop "tk" acronym. > 5. Other misc. comments. > 6. Added review tags for patch #3 and #4. > > Changes in v4: > 1. Pushed independent TEE features separately: > - Part of recent TEE PR: https://lkml.org/lkml/2020/5/4/1062 > 2. Updated trusted-encrypted doc with TEE as a new trust source. > 3. Rebased onto latest tpmdd/master. > > Changes in v3: > 1. Update patch #2 to support registration of multiple kernel pages. > 2. Incoporate dependency patch #4 in this patch-set: > https://patchwork.kernel.org/patch/11091435/ > > Changes in v2: > 1. Add reviewed-by tags for patch #1 and #2. > 2. Incorporate comments from Jens for patch #3. > 3. Switch to use generic trusted keys framework. > > Sumit Garg (4): > KEYS: trusted: Add generic trusted keys framework > KEYS: trusted: Introduce TEE based Trusted Keys > doc: trusted-encrypted: updates with TEE as a new trust source > MAINTAINERS: Add entry for TEE based Trusted Keys > > .../admin-guide/kernel-parameters.txt | 12 + > .../security/keys/trusted-encrypted.rst | 171 ++++++-- > MAINTAINERS | 8 + > include/keys/trusted-type.h | 53 +++ > include/keys/trusted_tee.h | 16 + > include/keys/trusted_tpm.h | 29 +- > security/keys/trusted-keys/Makefile | 2 + > security/keys/trusted-keys/trusted_core.c | 358 +++++++++++++++++ > security/keys/trusted-keys/trusted_tee.c | 317 +++++++++++++++ > security/keys/trusted-keys/trusted_tpm1.c | 366 ++++-------------- > 10 files changed, 981 insertions(+), 351 deletions(-) > create mode 100644 include/keys/trusted_tee.h > create mode 100644 security/keys/trusted-keys/trusted_core.c > create mode 100644 security/keys/trusted-keys/trusted_tee.c > > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel