From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF9B7C07E9A for ; Wed, 14 Jul 2021 11:11:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8481B61374 for ; Wed, 14 Jul 2021 11:11:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8481B61374 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2L0Eyr9/WmdTajmw1v874VDL87PL0YwPfCWBscSMRNY=; b=uLcMtezL31bVDy OIpd10bJEdBXMUEWRlRFO3y/33pgR3qqk2DbN8eB5BDcShnbbR1g5uo6nMyc6uZE4TrtuwL5QoL25 ws66cSupLbOT5VKTYoaF1WWW91aO+YDx0j4VRWcOSXoQwnj2d/3OX9vAimBsXhfdEvqsO+iT4eWC+ k03v+T1KAIVbW9B0I1H63UMabhVcIIrX5hT5i30mV9YwvfS2TXmM5QylC5YoFgkcDVZlVx1jBrliK GR2KgDxaX/H11yUv9jbilRh+POmt7SpZY0NkN3fx9FUTTXHd4zUTuMMBCdGepeF3sm30uYG2s1Rpy l7ol0YyawrdFR2GdumTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3clZ-00DIMv-5P; Wed, 14 Jul 2021 11:09:25 +0000 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3clV-00DILO-C3 for linux-arm-kernel@lists.infradead.org; Wed, 14 Jul 2021 11:09:23 +0000 Received: by mail-lj1-x232.google.com with SMTP id r16so2761348ljk.9 for ; Wed, 14 Jul 2021 04:09:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v0TMPvxOFb6IoP3ndZ/UuzxcR9hu1yO3tgEtU6vY2b4=; b=df9xZPM4UnD6+Imjxfd2YWdV4My49n7UYf7FIgX84ljq3vN1zQHkQw86zcWkQYboP/ qrDKAMsBZHNJ5adBDvsvY1+EmmNIB0OQRTBZhsFxrEhYUOeJpNLdDhiS2TZRMuySV4N/ jEC4zKaJODctXzexVzYoqILRoQ5W0/omFpY1rlx/DWe237AlpTn/Vp1tYE7cbUGvthD7 X/vmTl9zHOreJ5NlFYwy9l9TlrbagOvpwUXzYscBX/AVn94CN2EgkXubG3xGFEjCT6Z2 h18bBM3k3OALKiRIGsmMhdUB0XJ93pDym2kOeVqcHrL3fX6sLi9iEJPyD5Wcal1E5hYL eVGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v0TMPvxOFb6IoP3ndZ/UuzxcR9hu1yO3tgEtU6vY2b4=; b=aXbnEv/RHNVrI7VltWa05JpN13ul2zsFKzlXna91Wx9O4dUMAzDnwOzc6+YiwAaG1j EOvdcz2Hb36q/8zhC+yDtzOys5TVPOF9GOdlHh3JQoQ2TU2i5nCtNNQ0xRM3GJBoovoK x7+hPe5/T+H3Rpno0V4wLaw6Aoq6qp5EXFiwtKtLtltO8vJlXA3qXe/hwk/9ENG9/Mgz hA8zSQfdul4ZPNE1zoozGLU1ftgjBLt8BqkxxSUEV4avAlIZUkscGZq4ARhBVSfacvb8 85tKqwJwm9/SOaPUI/tz6CJ0mV5jAOrzPMSIHHa6Yekg3CFs5k07kSh2mzUIL34L2eLp EYmA== X-Gm-Message-State: AOAM533CeVd1IKYAFa2SLkKI8qc1o5A7RIxdBq7/PhVh1FkJNvzrt1rt NX0TTIG219efNhCfC27gn7OxhuChhp7MRy+QqKb7yaVr8bbyEw== X-Google-Smtp-Source: ABdhPJxEhoqRpr7HmwPThePbSuYCwwjX0ADDHc68KCE3st/zTMz7kSdPTP7Sct2Uy/2+Py/FNCCjSjTRkbLlqbtJT5k= X-Received: by 2002:a2e:bc13:: with SMTP id b19mr8883269ljf.480.1626260958700; Wed, 14 Jul 2021 04:09:18 -0700 (PDT) MIME-Version: 1.0 References: <20210527081404.1433177-1-jens.wiklander@linaro.org> In-Reply-To: <20210527081404.1433177-1-jens.wiklander@linaro.org> From: Sumit Garg Date: Wed, 14 Jul 2021 16:39:07 +0530 Message-ID: Subject: Re: [PATCH v2 0/5] Add FF-A support in OP-TEE driver To: Jens Wiklander Cc: Linux Kernel Mailing List , linux-arm-kernel , OP-TEE TrustedFirmware , Sudeep Holla , Marc Bonnici , Jerome Forissier X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210714_040921_484558_DB35EB75 X-CRM114-Status: GOOD ( 34.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jens, This patch-set skipped my inbox as I was not on the CC list. So while reading through ML archives, I found it. On Thu, 27 May 2021 at 13:45, Jens Wiklander wrote: > > Hi all, > > This adds supports for the OP-TEE driver to communicate with secure world > using FF-A [1] as transport. > > These patches are based on the FF-A v7 patch set by Sudeep Holla [2] [3]. > I could see the FF-A driver support merged upstream. Is this patch-set directly applicable on the upstream kernel? If yes, can you also share steps to test it on Qemu? > There is one change to the TEE subsystem with "tee: add sec_world_id to > struct tee_shm" to add support for holding globally unique handle assigned > by the FF-A. This is a field that I believe could useful for the AMDTEE > driver too. > > For communication the OP-TEE message protocol is still used, but with a new > type of memory reference, struct optee_msg_param_fmem, to carry the > information needed by FF-A. The OP-TEE driver is refactored internally with > to sets of callbacks, one for the old SMC based communication and another > set with FF-A as transport. Since now we have two ABIs towards secure world: - OP-TEE ABI - FF-A ABI I think it would be better to have ABI specific APIs separated from core.c to have a clear view of abstraction. How about new file names as: - optee_{msg/abi}.c - ffa_{msg/abi}.c > > There is also a difference in how the drivers are instantiated. With the > SMC based transport we have a platform driver, module_platform_driver(), > today which we're keeping as is for this configuration. In a FF-A system we > have a FF-A driver, module_ffa_driver(), instead. > > The OP-TEE driver can be compiled for both targets at the same time and > it's up to runtime configuration (device tree or ACPI) to decide how it's > initialized. Can you elaborate on different device tree or ACPI configuration? AFAIR, FF-A utilizes bus enumeration to scan OP-TEE UUID. -Sumit > > Thanks, > Jens > > [1] https://developer.arm.com/documentation/den0077/latest > [2] https://lore.kernel.org/linux-arm-kernel/20210521151033.181846-1-sudeep.holla@arm.com/ > [3] git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git v5.13/ffa > > v1->v2: > - Rebased to the FF-A v7 patch > - Fixed a couple of reports from kernel test robot > > Jens Wiklander (5): > tee: add sec_world_id to struct tee_shm > optee: simplify optee_release() > optee: refactor driver with internal callbacks > optee: add a FF-A memory pool > optee: add FF-A support > > drivers/tee/optee/call.c | 325 +++++++++++--- > drivers/tee/optee/core.c | 689 ++++++++++++++++++++++++++---- > drivers/tee/optee/optee_ffa.h | 153 +++++++ > drivers/tee/optee/optee_msg.h | 27 +- > drivers/tee/optee/optee_private.h | 88 +++- > drivers/tee/optee/rpc.c | 137 +++++- > drivers/tee/optee/shm_pool.c | 65 ++- > drivers/tee/optee/shm_pool.h | 1 + > include/linux/tee_drv.h | 7 +- > 9 files changed, 1326 insertions(+), 166 deletions(-) > create mode 100644 drivers/tee/optee/optee_ffa.h > > -- > 2.25.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel