From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: khilman@baylibre.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 11/14] arm64: dts: meson-g12a-x96-max: fix compatible
Date: Wed, 21 Aug 2019 23:14:28 +0200 [thread overview]
Message-ID: <CAFBinCA13xJHRmTrOHxSkoy2rMv3=+BBwZsLBmZn=cQ0pyE_Aw@mail.gmail.com> (raw)
In-Reply-To: <c2d78c7c-d9a8-e486-d3b1-c1447e24284b@baylibre.com>
On Wed, Aug 21, 2019 at 4:08 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> On 20/08/2019 22:32, Martin Blumenstingl wrote:
> > On Wed, Aug 14, 2019 at 4:33 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
> >>
> >> This fixes the following DT schemas check errors:
> >> meson-g12a-x96-max.dt.yaml: /: compatible: ['amediatech,x96-max', 'amlogic,u200', 'amlogic,g12a'] is not valid under any of the given schemas
> >>
> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> >
> > [...]
> >> - compatible = "amediatech,x96-max", "amlogic,u200", "amlogic,g12a";
> >> + compatible = "amediatech,x96-max", "amlogic,g12a";
> > only partially related: I wonder if we should add a s905x2 compatible
> > string here and to the .dts filename (just like we separate the GXL
> > variants s905x, s905d, s905w, ...)
> >
>
> We could, but AFAIK no variants of G12A are planned yet...
we already support two variants: S905X2 and S905D2 (I'm assuming that
these are similar to S905X and S905D meaning both are almost
identical)
but I guess we can stay with what we have until there's a reason to
have separate compatible strings (for example if we discover that
there is a difference that matters - like the OPP table on S922X vs
A311D)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-21 21:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 14:29 [PATCH 00/14] arm64: dts: meson: fixes following YAML bindings schemas conversion Neil Armstrong
2019-08-14 14:29 ` [PATCH 01/14] arm64: dts: meson: fix ethernet mac reg format Neil Armstrong
2019-08-20 20:21 ` Martin Blumenstingl
2019-08-14 14:29 ` [PATCH 02/14] arm64: dts: meson-gx: drop the vpu dmc memory cell Neil Armstrong
2019-08-20 20:28 ` Martin Blumenstingl
2019-08-21 14:04 ` Neil Armstrong
2019-08-14 14:29 ` [PATCH 03/14] arm64: dts: meson-gx: fix reset controller compatible Neil Armstrong
2019-08-20 20:21 ` Martin Blumenstingl
2019-08-14 14:29 ` [PATCH 04/14] arm64: dts: meson-gx: fix spifc compatible Neil Armstrong
2019-08-20 20:29 ` Martin Blumenstingl
2019-08-14 14:29 ` [PATCH 05/14] arm64: dts: meson-gx: fix watchdog compatible Neil Armstrong
2019-08-20 20:22 ` Martin Blumenstingl
2019-08-14 14:29 ` [PATCH 06/14] arm64: dts: meson-gx: fix mhu compatible Neil Armstrong
2019-08-14 14:29 ` [PATCH 07/14] arm64: dts: meson-gx: fix periphs bus node name Neil Armstrong
2019-08-20 20:25 ` Martin Blumenstingl
2019-08-14 14:29 ` [PATCH 08/14] arm64: dts: meson-gxl: fix internal phy compatible Neil Armstrong
2019-08-20 20:38 ` Martin Blumenstingl
2019-08-21 14:07 ` Neil Armstrong
2019-08-14 14:29 ` [PATCH 09/14] arm64: dts: meson-axg: fix MHU compatible Neil Armstrong
2019-08-14 14:29 ` [PATCH 10/14] arm64: dts: meson-g12a: fix reset controller compatible Neil Armstrong
2019-08-20 20:42 ` Martin Blumenstingl
2019-08-14 14:29 ` [PATCH 11/14] arm64: dts: meson-g12a-x96-max: fix compatible Neil Armstrong
2019-08-20 20:32 ` Martin Blumenstingl
2019-08-21 14:08 ` Neil Armstrong
2019-08-21 21:14 ` Martin Blumenstingl [this message]
2019-08-14 14:29 ` [PATCH 12/14] arm64: dts: meson-gxbb-nanopi-k2: add missing model Neil Armstrong
2019-08-20 20:25 ` Martin Blumenstingl
2019-08-21 14:08 ` Neil Armstrong
2019-08-14 14:29 ` [PATCH 13/14] arm64: dts: meson-gxbb-p201: fix snps, reset-delays-us format Neil Armstrong
2019-08-20 20:23 ` Martin Blumenstingl
2019-08-14 14:29 ` [PATCH 14/14] arm64: dts: meson: fix boards regulators states format Neil Armstrong
2019-08-20 20:35 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFBinCA13xJHRmTrOHxSkoy2rMv3=+BBwZsLBmZn=cQ0pyE_Aw@mail.gmail.com' \
--to=martin.blumenstingl@googlemail.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).