From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED078C433C1 for ; Tue, 23 Mar 2021 21:35:15 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80397619C7 for ; Tue, 23 Mar 2021 21:35:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80397619C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9bjy7Mf/o7ZTFR/GYcTLm8TJxggGW5rFr8dFpxVhHoI=; b=dJD3+V4m7yIo19R4DuwASGaVs yeLt2mC+9XDoDPXAgMh2fRysYYn41cQ2HMbOU8IACzFGMAEuXKSDLFJtnEnz6bC/DhghOsRVsrefL mwI7p5bGmEFqSGsgjR7YBy9viOghEsmb+NyHuyXjgFHK7/MG0HmUKO69vxDyY/I31OQ+CD0AnBF4/ TGyBSHamnWxVlrbd7YgLVjNv/u/fkgNXpxG+0tyfWFSQMEoVo28r8rctrx6Xyhvf/eQX1DaN+4BXZ C30lsBvs4+/CqhOIXhRfpX03PODXrtCRFYxDmI+x4mVwjco1K5xFX69fYAoPRTgryyebrCBwKMS7Q t61GkKb6Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOoee-00Fmst-Aw; Tue, 23 Mar 2021 21:33:36 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lOoeV-00Fms1-NF; Tue, 23 Mar 2021 21:33:29 +0000 Received: by mail-ed1-x533.google.com with SMTP id z1so25251538edb.8; Tue, 23 Mar 2021 14:33:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vNqTp+4J55pn8UtxCWhZI9WKQ5OJTgrthkxSNaaR9fk=; b=Z1X62JgaNMMBhLZQ4QlhpGE30R7oq8YUDzrEMEzTRD0vNkPaAU0FqGpgvMQr3SNw4N TQ2lURRF9XEcvjjsQtWoYsO7GtMMtlQB/pagSghOAntjFN+62FySADdKePG/SaNFdkTw jjRiQNIFaAgrove9trejAd+bh2AI53ZwBbeUGI+rGNQUgiUDhrqm/52yIa8mSOHbRADc /Hl8zXqJYmy5UllL/i5DfDsUENesGkIKUATnioFFGXBBjUtDvmeZiEaQGPAi+S8F39FF 81WLl9okrNOK9J9KAS05Up2FL0aVT//x6QW9B21AIw6AHfDL9xjBkEvHP9LtW5QOQSL8 tjEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vNqTp+4J55pn8UtxCWhZI9WKQ5OJTgrthkxSNaaR9fk=; b=p+mdmZgqd7yuyu+pOic0dXczQBKU0dYqJKoNnznFbQW+YZxChJCbn/y9xbsDWf4rmg 3fsA3S61e+dBmodKnvFNZ5Ta+T9+IbG8mnPrC3sa5r3ip6j8FN0f9j17rFas510MdLqM 9gVlzwFXpdgSJDGKHPhomfum79HXCGTq6ZAuLPN64WJb5TKxDb35RNXvuR4aI5CqKWle NZswfuJF56JbnQyHyr/pQsIaTyajanvi/LUDYSu+HEcsbhoh81zcFSlo06qfFN8xuvaU zPN40P6aWCtsqTUYvbzAAIn8T+FwWg5ETrrPlgjNR/JVQ61s9SG1LaV0P2kYbvG7FOOq kKqQ== X-Gm-Message-State: AOAM533T9b7G0ACNdUHPIjKEAGMnzmkJ/N3vXBTtATNbxklsyVaqZ/Xj oGAua5P+fx2CJ/2JTx6i8jr7SMtRf9GrwskEkHo= X-Google-Smtp-Source: ABdhPJxogLUC0j2kqIXnvE9ADeLdHe/dekVrvsjIiVez5mN8mdmstjeRi/0IbcBN4Amm2vqsw9nN/TGoA02CccJ8wno= X-Received: by 2002:aa7:c957:: with SMTP id h23mr6431368edt.301.1616535206608; Tue, 23 Mar 2021 14:33:26 -0700 (PDT) MIME-Version: 1.0 References: <20210315083459.359773-1-narmstrong@baylibre.com> <20210315083459.359773-2-narmstrong@baylibre.com> In-Reply-To: <20210315083459.359773-2-narmstrong@baylibre.com> From: Martin Blumenstingl Date: Tue, 23 Mar 2021 22:33:15 +0100 Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: serial: amlogic, meson-uart: add amlogic, uart-fifosize property To: Neil Armstrong Cc: gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210323_213327_890718_975F154E X-CRM114-Status: GOOD ( 16.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Neil, On Mon, Mar 15, 2021 at 9:37 AM Neil Armstrong wrote: > > On most of the Amlogic SoCs, the first UART controller in the "Everything-Else" > power domain has 128bytes of RX & TX FIFO, so add an optional property to describe do we still need wrapping of long lines in commit messages? if so I think the line above is too long > a different FIFO size from the other ports (64bytes). > > Signed-off-by: Neil Armstrong Reviewed-by: Martin Blumenstingl one additional note below > --- > .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml > index 75ebc9952a99..e0a742112783 100644 > --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml > +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml > @@ -55,6 +55,12 @@ properties: > - const: pclk > - const: baud > > + > + amlogic,uart-fifosize: > + description: The fifo size supported by the UART channel. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [64, 128] I personally think this is generic enough to be described as fifo-size (as it's done in Documentation/devicetree/bindings/serial/8250.yaml) let's wait and hear what Rob thinks Best regards, Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel