From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 066A3C3A589 for ; Tue, 20 Aug 2019 20:38:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D0AFE22DD3 for ; Tue, 20 Aug 2019 20:38:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Qw11Rqvn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="NZz+Q/nQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0AFE22DD3 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RhPe7YorT1lGqznzWlP2szw94D9K28AX9gGAPF0k8wc=; b=Qw11RqvnyfJ4ti 6A3ZmV3es0y0nxl+fN/CWZnhb3bc22Hk0cqwr9r2MtytPqCzZAzi5lnso7x92+Ps3KCB7czdh3EG/ Z66FOZJlLIPx4bcms080GXpCOjTSEEtHbyrT16xNb0qbUEZ4FY8gqjOF80oG888grwAId90gVdrEL BT2w6W8EPD3tNhpvdImXVJbuhgExz0UvzuVIXJNdSQY6D/6n5BG4GmPlZ87hbHUAaMDfBUZ97cpik oRha6dngFNlwPsCqADF9SIH9JYMyPinA/a7ko8J6pSY+O/eqSRqyCa5AXtT4ptjhR9FN3zkAqMrX+ f6G5OSl0F3qJYZxLrE2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i0Ath-0004Xi-A0; Tue, 20 Aug 2019 20:38:29 +0000 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i0Atc-0004Vx-Qj; Tue, 20 Aug 2019 20:38:26 +0000 Received: by mail-oi1-x241.google.com with SMTP id n1so2786226oic.3; Tue, 20 Aug 2019 13:38:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7VmI4UR9rm/Jfd08uHYSrv3Ihas2nSA2EW/A7sAlzUk=; b=NZz+Q/nQp5XIJDHqOuZKxrlqHsz7DlKqAGfPwQw+ZIWoVvVirJzUdKy0D3SePNTrbi oXJX70Ubh1xaczVNx+RqFnM4ehZhrWqs6cyhbFGPJYkfP+9qkx8d2UAX4YrkB5+wZu3A 4yw2J4s1M6UaUjgkRsTWqHXrKW42tpKV8kYRmUiMdOwuiQ7ZZqHiK0JvRZN6ZL4Gpkly f1JsPfx180hyjBqpXHSZ5AyYsVvXw6SBTUshGwLW+4f9koeQjhk5poS15zAmTPQnKdDj x/Iwnd1YkEaOFvt+MhMNZRoFS46Q8sT6d1sqjO+j9Kjcr/OBkkm29odhltz1HBO/suVP 5NhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7VmI4UR9rm/Jfd08uHYSrv3Ihas2nSA2EW/A7sAlzUk=; b=tzN+G5h2tACdvjrplB8reDwN3vV/B0RuT3iT3nQ4JjopoumdVwx+Ql2Qfox8FqnFSG 1suYnwGJdW2Ax05iAr4UrqJXObvZqdq/Kufny7b+xkLzVWwpiEC1f/DGs8p0vQIMv6tp 1PazOBdTH482Vhzh092r5WfxCBDPp6lt9DYm0vpinVpCNY+iGUAnmNCKhqr/3VCxqo3L KoWqUzqwCPMG61DgJuTe/iytXg5hVnQbs3FEXlsF9Ahds3fnpywb2zA+yBVyheJQE9hK LU61t1Z9moUPy0nSKclr9EBzTd7rrYdMMe82edoHo3L8cfHOCf1REYFI2slPy/SuT7A0 /f2w== X-Gm-Message-State: APjAAAWHtfSTRbZ7lSW0RAlSklQSFSxzgSEmRrfEM9ZW/2qwQ4yEeCWT Np7NiyooFZxADMgEJCGNewL5o9CYIfbv6IxvZHY= X-Google-Smtp-Source: APXvYqxrzFrQ+g2QEmNNouNemvPcTmQHcQR4X6WXqzrbCBDuYyrd6w2oQ7citF3f2pm6VSFkWc7jHwI34ndZ7LUVb4I= X-Received: by 2002:a05:6808:b14:: with SMTP id s20mr1380498oij.15.1566333504047; Tue, 20 Aug 2019 13:38:24 -0700 (PDT) MIME-Version: 1.0 References: <20190814142918.11636-1-narmstrong@baylibre.com> <20190814142918.11636-9-narmstrong@baylibre.com> In-Reply-To: <20190814142918.11636-9-narmstrong@baylibre.com> From: Martin Blumenstingl Date: Tue, 20 Aug 2019 22:38:13 +0200 Message-ID: Subject: Re: [PATCH 08/14] arm64: dts: meson-gxl: fix internal phy compatible To: Neil Armstrong , jbrunet@baylibre.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190820_133824_869216_56C3522D X-CRM114-Status: GOOD ( 14.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: khilman@baylibre.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org adding Jerome On Wed, Aug 14, 2019 at 4:31 PM Neil Armstrong wrote: > > This fixes the following DT schemas check errors: > meson-gxl-s805x-libretech-ac.dt.yaml: ethernet-phy@8: compatible: ['ethernet-phy-id0181.4400', 'ethernet-phy-ieee802.3-c22'] is not valid under any of the given schemas > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > index ee1ecdbcc958..43eb158bee24 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > @@ -709,7 +709,7 @@ > #size-cells = <0>; > > internal_phy: ethernet-phy@8 { > - compatible = "ethernet-phy-id0181.4400", "ethernet-phy-ieee802.3-c22"; > + compatible = "ethernet-phy-id0181.4400"; on G12A there was a specific reason (iirc it was because the PHY ID can be any arbitrary value programmed into some register) why we added it with a compatible string Jerome, do we have the same situation on GXL/GXM as well? if not I prefer to drop the compatible string because it's probably from a time where the PHY dt-bindings stated "add the PHY ID compatible string if you know it" while the actual suggestion was "only add it if reading the ID doesn't work for some reason" Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel