archive mirror
 help / color / mirror / Atom feed
From: Martin Blumenstingl <>
To: Neil Armstrong <>
Cc:,,,,  Stefan Agner <>
Subject: Re: [PATCH] drm/meson: fix shutdown crash when component not probed
Date: Thu, 20 May 2021 22:25:45 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Neil,

since this has not received any Reviewed-by yet I tried my best to
review it myself

On Fri, Apr 30, 2021 at 10:28 AM Neil Armstrong <> wrote:
> --- a/drivers/gpu/drm/meson/meson_drv.c
> +++ b/drivers/gpu/drm/meson/meson_drv.c
> @@ -485,11 +485,12 @@ static int meson_probe_remote(struct platform_device *pdev,
>  static void meson_drv_shutdown(struct platform_device *pdev)
>  {
>         struct meson_drm *priv = dev_get_drvdata(&pdev->dev);
this part made it hard for me because I was wondering where the
matching dev_set_drvdata call is
it turns out platform_set_drvdata is used instead, meaning for me it
would have been easier to understand if platform_get_drvdata was used
that's however nothing which has changed with this patch

> -       struct drm_device *drm = priv->drm;
> -       DRM_DEBUG_DRIVER("\n");
> -       drm_kms_helper_poll_fini(drm);
> -       drm_atomic_helper_shutdown(drm);
> +       if (!priv)
> +               return;
> +
> +       drm_kms_helper_poll_fini(priv->drm);
> +       drm_atomic_helper_shutdown(priv->drm);
>  }
then this part finally made sense to me (as non-drm person), as
platform_set_drvdata comes near the end of meson_drv_bind_master (so
any errors would cause the drvdata to be NULL).

with this I can also give me:
Reviewed-by: Martin Blumenstingl <>
in addition to my:
Tested-by: Martin Blumenstingl <>

Can you please queue this up for -fixes or do we need to ask someone to do it?

Best regards,

linux-arm-kernel mailing list

  parent reply	other threads:[~2021-05-20 20:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-30  8:27 [PATCH] drm/meson: fix shutdown crash when component not probed Neil Armstrong
2021-05-02 23:04 ` Martin Blumenstingl
2021-05-20 20:25 ` Martin Blumenstingl [this message]
2021-05-25  7:19   ` Neil Armstrong
2021-05-25  7:27 ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).