From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5525C4360F for ; Tue, 2 Apr 2019 19:35:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E1AE2070D for ; Tue, 2 Apr 2019 19:35:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Pn9Imx9B"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="aVtzRg3y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E1AE2070D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wakYoQr0GMwiadOIC2mZYEjejfxCKNH/mCA0c3bi88o=; b=Pn9Imx9B1ONkX4 oVWglRlI9FdX8x4ZHY5nlZNPfugDWmE0JyI8PBX7vYd/MCZg25OJDXy/6/Z4JanTX5HwU0L7c+17A 1TwRQOeIveJOSBOSt9pcu64wO6n3zAnC6+q6IC80VjOZw1RgXSHBOdxocGLINIkwXyKf/rOkrFvAb Rddvn6nVxSSAMD3/rHKG59qWhppJHJAKV5HZIgTrNt34mD9FjLgccatQQiL8kEFJRoF4O3yqi4TyC NoszlWEetc1/KiU/BSjZjGHgxPfBBoPcXrcnXp8Y/l3oDHEgt3iHzC+xKhWYt9r2bCM6fvDYy199r PJlZNuiZAMfbnNZY8aeQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBPCA-0002e8-0D; Tue, 02 Apr 2019 19:35:42 +0000 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBPC6-0002dc-AW for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2019 19:35:39 +0000 Received: by mail-ot1-x342.google.com with SMTP id 64so13101593otb.8 for ; Tue, 02 Apr 2019 12:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9qggzwLm7Q6E+GLfDVG42y9ueqSArVPfDeKlmnOWQuM=; b=aVtzRg3yDmU0mHeDs9OLE8OWR3+dPw9ANaD2NG2tYt+WAF8M4C42xddrQQLAj+hX/K 8jptGVRYPn2Y7BpftOuGxG4VGPB+CKWkpCODk7g/fN6u8QlEv7WV7uh4DVPoPNDJDnGi wrd9O6BiXm8uL918aSbjs4dXUjh84yk5t/D3QzZ7nZhR41CZ9dJYS2ceVKZBXUMIKrT7 +4WChz6+qkTPFE56lhwK+rjn6uRCXYKqq7PqGFbILOxTnYOPi/Vytdvm0LEgOwaUhJk7 i4his5aJeuPtiOqH9SxWTKnjJcRPSqRbjrIRIz5gDJmwsuy/pHEqGhrEXZoPjHIAPjk7 PuFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9qggzwLm7Q6E+GLfDVG42y9ueqSArVPfDeKlmnOWQuM=; b=AGYyHAwV00WkZQDyf3oVhH1I9NnPL54K1cWLsO5jvdHYFXbs1LdNnUVlQQRuJ2eMjY au9g6xlDnJoXavSg+wveW/el+euJ/19edncVEDec5d2OQVPT3vNOtAJdhfmoMo9/At7/ BGmV4R2ZIqX9kQ422JrfsSjDVP/cHqkRUoTQb8WXpfjwe0vMgXks1MKgTDW/RJQ91dvo 6bDduurv+tzDHHLcsswLGmVHsVbc+0eqRXrM/Ibtn4aD7WEZouz1QGKb3cjNeXQkc3lP XpnjJeDc8tEoYbHU8nIHhTNz857qEzPZKIBfmjz1HWBDmhzGOdsrPs5TVinkuRSSCY8h BuQw== X-Gm-Message-State: APjAAAU+iUr7kD+0VMevlNwgYXO2i0hx5XEFGH1M0RFoWKgYjWZGd0ZY 0WIi33IMUbOjzZsxmmNjpZYp/t/tS0sLe4bvr0c= X-Google-Smtp-Source: APXvYqxYfM7IjgejHp31Ne2eODrfYoJ6nQzFfv2q6O94i8IrN31e/SRW9BCaEnMmMfBqK89+EoPNtOqVLH+MhOnOudM= X-Received: by 2002:a9d:6e88:: with SMTP id a8mr34413507otr.117.1554233737171; Tue, 02 Apr 2019 12:35:37 -0700 (PDT) MIME-Version: 1.0 References: <20190401165131.23370-1-miquel.raynal@bootlin.com> <20190401165131.23370-16-miquel.raynal@bootlin.com> In-Reply-To: <20190401165131.23370-16-miquel.raynal@bootlin.com> From: Martin Blumenstingl Date: Tue, 2 Apr 2019 21:35:26 +0200 Message-ID: Subject: Re: [PATCH 15/15] arm64: dts: marvell: Convert 7k/8k usb-phy properties to phy-supply To: Miquel Raynal X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190402_123538_389200_94DE3770 X-CRM114-Status: GOOD ( 22.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Jason Cooper , devicetree@vger.kernel.org, Antoine Tenart , Gregory Clement , Russell King , Kishon Vijay Abraham I , Nadav Haklai , Rob Herring , Thomas Petazzoni , Maxime Chevallier , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Miquel, thank you for keeping me in the loop! On Mon, Apr 1, 2019 at 6:52 PM Miquel Raynal wrote: > > Update Aramda 7k/8k DTs to use the phy-supply property of the (recent) > generic PHY framework instead of the (legacy) usb-phy preperty. Both > enable the supply when the PHY is enabled. > > The COMPHY nodes only provide SERDES lanes configuration. The power > supply that is represented by the phy-supply property is just a > regulator wired to the USB connector, hence the creation of connector > nodes as child of the COMPHY nodes and the supply attached to it. shouldn't this also be reflected in the dt-bindings? > Cc: Martin Blumenstingl > Signed-off-by: Miquel Raynal > --- > .../arm64/boot/dts/marvell/armada-7040-db.dts | 26 ++++++++++--------- > .../marvell/armada-8040-clearfog-gt-8k.dts | 13 +++++----- > .../arm64/boot/dts/marvell/armada-8040-db.dts | 13 +++++----- > .../boot/dts/marvell/armada-8040-mcbin.dtsi | 13 +++++----- > 4 files changed, 35 insertions(+), 30 deletions(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-7040-db.dts b/arch/arm64/boot/dts/marvell/armada-7040-db.dts > index 131ce4229db0..4b8df359b1cc 100644 > --- a/arch/arm64/boot/dts/marvell/armada-7040-db.dts > +++ b/arch/arm64/boot/dts/marvell/armada-7040-db.dts > @@ -45,16 +45,6 @@ > enable-active-high; > gpio = <&expander0 1 GPIO_ACTIVE_HIGH>; > }; > - > - cp0_usb3_0_phy: cp0-usb3-0-phy { > - compatible = "usb-nop-xceiv"; > - vcc-supply = <&cp0_reg_usb3_0_vbus>; > - }; > - > - cp0_usb3_1_phy: cp0-usb3-1-phy { > - compatible = "usb-nop-xceiv"; > - vcc-supply = <&cp0_reg_usb3_1_vbus>; > - }; > }; > > &i2c0 { > @@ -200,15 +190,27 @@ > }; > }; > > +&cp0_comphy1 { > + cp0_usbh0_con: connector { > + compatible = "usb-a-connector"; > + phy-supply = <&cp0_reg_usb3_0_vbus>; > + }; > +}; (disclaimer: I don't have any board with a marvell SoC, so I don't understand how it works and I can't debug it) I know about the "phy-supply" property inside the PHY node itself (that would be cp0_comphy1 in this case). The connector binding does not mention a phy-supply property: Documentation/devicetree/bindings/connector/usb-connector.txt I don't understand which driver enables the phy-supply when it's part of a "connector" child-node. do you have a hint where I should start looking? Regards Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel