From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09D49C282DD for ; Thu, 9 Jan 2020 17:12:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2D932067D for ; Thu, 9 Jan 2020 17:12:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bA8A/Mf7"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="NZk8QVJ4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2D932067D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lfrsWu+beND675ZPndZxjCiR97EC2S2fPbW2lqla0GQ=; b=bA8A/Mf7OxSJUR US3g/S2krLNwdhF0rQqKQWAWTWHoTy4FqTBIWio02aTk3bVVc/NnIvvhackl9deGn+YeCpGl9ZZwU hvSz5R0ld+70m+TPNtuLNnAbzvuRFyAy2PrvI5qCsiCOGYgRAnHitr1uVYAuLmp/9AC3GTc2SA4Au 7FPGlezFubn8YRQhrnT5o/tl8qlb8igW0SfqF6r9n5a4D6nBEeNuMmij31Gj/IFYEF9wtoWPh/TAw 1OBYrdAyBUOYhfmD6IabNftNpEun0rmIJczH7VpA1Yljh9Y7KePgzEMN3YXpLV/fpN7tttKeagOnI 64okLom9XZ9txQ17bN6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipbMC-0001VX-FP; Thu, 09 Jan 2020 17:12:28 +0000 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipbM7-0001TZ-Le; Thu, 09 Jan 2020 17:12:25 +0000 Received: by mail-ed1-x542.google.com with SMTP id v28so6225564edw.12; Thu, 09 Jan 2020 09:12:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m5bKqTGzATt6X20fwIM187YSSZ5nrekRXnj5LVqJY7Y=; b=NZk8QVJ4WAq4R3o1D9+VK4ZSDQSQK7dvbRBf4AMuCjvRavx3veVI/WQdqKnErpQRCi Eds8ghTPfv2hOFlO+55g+LMIJEC7O2+PJrmajsk7a7ZfOWWf5KbxCbL/TWpXi++9cpKv 8aBr2fKChY5SkaGsOnqjfiEUsrybPtHq9g0CK6+sssK3HgBu9YUvbopeuATcEF0PO0xI tnC5vORlB623hwx5NeI+ql2fbwiqXj1AbZ3c4BjnMQ4f+ysx6m5kguWC8Xg/dyYQZMHs 84dkmKBvzqz1rcILrG2brbxH8W0Sy9kKfMjsWi3uGO/8Fpsg4osgxmdB1wnTfL9aO7BA 1/yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m5bKqTGzATt6X20fwIM187YSSZ5nrekRXnj5LVqJY7Y=; b=s0sBt7X/74IjEM+R1vXA0u44BEXtCM9HJ41Yi5GVhz5qUSQmPEK33VZUhYAAtRZlJa O2ch9eB/4gGioriti34BqcC0YuywU9obFhQRCitYBeVpziq90wRwwozrSIeb1J18N6QF +t907KCJfKcVLOuUGFaV4xkvYgfVLdeqZ3ifjF9Gw0TgsJnkVSQHlhnyIJ32p6DUldGu Nb3eXqhT+RgGIi3SFXV71pOFadOCCr/D+S106OR9C87IPPch7L57xN478MO0g3asskZE yUQ3ioN8DbExFJ+nNV0Scc2Vt9e1b1tTI4i6OMnFQJ3ynZ8emL3ylrN16zUjOLeWuc8x 0XAw== X-Gm-Message-State: APjAAAUEonssyyhj3nYuq4GkA8qv2ylKY25dhZP8IMiPN1d+pF5NQyuM sba+EzWu03wn5VbzQzLtLq0mGMzRsyONqv1Ubl4= X-Google-Smtp-Source: APXvYqyLdglBvA5azqE41oQ6/P+wJuoQqzv1gmvgl8pOyKv1FX2KnStTQwNTBWRxCdUkXCCfXmw+cXn4c4ssjYI5N3Y= X-Received: by 2002:a50:fb96:: with SMTP id e22mr12160409edq.18.1578589941734; Thu, 09 Jan 2020 09:12:21 -0800 (PST) MIME-Version: 1.0 References: <1578537045-23260-1-git-send-email-hanjie.lin@amlogic.com> <1578537045-23260-2-git-send-email-hanjie.lin@amlogic.com> In-Reply-To: <1578537045-23260-2-git-send-email-hanjie.lin@amlogic.com> From: Martin Blumenstingl Date: Thu, 9 Jan 2020 18:12:10 +0100 Message-ID: Subject: Re: [PATCH v4 1/6] dt-bindings: phy: Add Amlogic A1 USB2 PHY Bindings To: Hanjie Lin X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200109_091223_717681_23566E7A X-CRM114-Status: UNSURE ( 7.57 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Victor Wan , Jianxin Pan , Neil Armstrong , Stephen Boyd , Kevin Hilman , Michael Turquette , linux-usb@vger.kernel.org, Yue Wang , Qiufang Dai , devicetree@vger.kernel.org, Liang Yang , Jian Hu , Xingyu Chen , Greg Kroah-Hartman , Carlo Caione , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 9, 2020 at 3:30 AM Hanjie Lin wrote: [...] > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: xtal_usb_phy the "usb_phy" part of "xtal_usb_phy" seems redundant to me: it's the XTAL clock input (this is what I'd expect as clock-name) of the USB PHY (this is already part of the node name). in addition to keeping the reset-names consistent (as Neil suggested) please also use the same clock-names as G12 Thank you! Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel