From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3538FC433DF for ; Fri, 26 Jun 2020 13:48:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01D7820679 for ; Fri, 26 Jun 2020 13:48:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rJmNjDoK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uerlbCVT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01D7820679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1WiRWPPYoI9dn5Z7EihHyAj356TXn9D9fahRmzk4rxw=; b=rJmNjDoK/WFrk6UrUy9DqCX0d B+xI/Uni6L5slLeOg79McrU9NBIht4ojz3hiTne0svvUDkdyjiH/23KDXNxTghjnSa68nqmxUuQzK vTq1czOsNwsSUtXNBgwcb/6Hz2faGlDQEcOy2+SHbjpKQNfzx21FEL7hJCrI56x2A5ly5yt0+uyVK XKhGZp/94E285FLjP11IHCO6LsqUMGUj/8qa5p9K623rI4pMrVt7qmOz9fW82NAucNsKSBR2bLLAb BLDzoTarY0iBGhLxZy6LsDddMSh2hUHjHgZ9VkGMcmkqjYFODFC8WvWltxORxXg8nVQ6EAUhb+2ts eTYNYVVrA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joogy-0003Ee-90; Fri, 26 Jun 2020 13:46:56 +0000 Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joogv-0003Cm-13 for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 13:46:53 +0000 Received: by mail-oi1-x244.google.com with SMTP id j11so5426995oiw.12 for ; Fri, 26 Jun 2020 06:46:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u52uSN3tbB8BJ8TCDzaGgSoU5fUp65xk0NIsBfbCuUw=; b=uerlbCVTm6bhJPJdRojlnnrVxEtxsK8hQALAle/RapM3i54Jijx/GgCL+gWqtF3N4k xtoF9Ck1Y5zFKR0Z2vnTmdS2fJFdPQdqPZQFCzOhXT+aVX4jtdutgtJ3HVU//vGV1hhV 7RU6uVK+canEjisRISkr6f0QyXTs7+YdWYczjlZXP/1I9mdm9upwfBNqlIKNuBDuaAtV V/IQKKwxQKQ0i3Hh3jilqGiytDNjm043a1ON5gHoMzySV4VqLzeC0/saz7/dm+WCwZYK 3G1w5vNinpFUaW3sVnXPPCQJh9+5vc4M+qmgMLq0+6PFc4LvO9DPTn61OMSBzdaJVgkz P6hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u52uSN3tbB8BJ8TCDzaGgSoU5fUp65xk0NIsBfbCuUw=; b=ZNh5pS24aUBdChKr5XJI6WTCEtEwurKg2+p30KE5vKbrTdHRHuR1sPpQ1RNUMfVkO4 uBr5a7ShnPqGr/QNaLBLlJVryZZbpRccX1o4cLmMr6ZI1dQi/R/Js8J7Wfb8x+15MuZN 2VK62TcSe9FZQZWIfLPziJ+Rvl2QgPyXOSHvLorn7g5nuXyh19W2a7WsCdO+MkQ+BQVR K+LqGGQFLICEDF9ZThJcHGXSZctIdjT9zcT3pACypoW9hQOOpe80OljLHSnVUSmkk9DS 8UiufKDOybkvJuqn2PoQ1y3AR/BYfq5H45WuKmBrv2zH0vcTzboZ6EVpjGiwSWqS5OCm XVxA== X-Gm-Message-State: AOAM532pZP31QU0n1iYm5NjBiu51SHX0hpZVrxkij6QWKYvLC02TyZnA nWqb745crQ1c10zkXyH4losbOzfjKkqVvoscasY= X-Google-Smtp-Source: ABdhPJw+adT2C8ScqVlyivOWskDWeFChgGpyoi580SKSGJZ6QdPB5OZwDMfLxuG0ID1SRCoWOBHtdfxqS6DttVK53nQ= X-Received: by 2002:a54:4494:: with SMTP id v20mr2521613oiv.154.1593179211074; Fri, 26 Jun 2020 06:46:51 -0700 (PDT) MIME-Version: 1.0 References: <20200626130525.389469-1-lee.jones@linaro.org> <20200626130525.389469-10-lee.jones@linaro.org> In-Reply-To: From: Oded Gabbay Date: Fri, 26 Jun 2020 16:46:23 +0300 Message-ID: Subject: Re: [PATCH 09/10] misc: habanalabs: irq: Add missing struct identifier for 'struct hl_eqe_work' To: Lee Jones X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, Arnd Bergmann , "Linux-Kernel@Vger. Kernel. Org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 26, 2020 at 4:45 PM Oded Gabbay wrote: > > On Fri, Jun 26, 2020 at 4:05 PM Lee Jones wrote: > > > > In kerneldoc format, data structures have to start with 'struct' > > else the kerneldoc tooling/parsers/validators get confused. > > > > Squashes the following W=1 warning: > > > > drivers/misc/habanalabs/irq.c:19: warning: cannot understand function prototype: 'struct hl_eqe_work ' > > > > Cc: Oded Gabbay > > Signed-off-by: Lee Jones > > --- > > drivers/misc/habanalabs/irq.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/misc/habanalabs/irq.c b/drivers/misc/habanalabs/irq.c > > index fac65fbd70e81..4e77a73857793 100644 > > --- a/drivers/misc/habanalabs/irq.c > > +++ b/drivers/misc/habanalabs/irq.c > > @@ -10,7 +10,8 @@ > > #include > > > > /** > > - * This structure is used to schedule work of EQ entry and armcp_reset event > > + * struct hl_eqe_work - This structure is used to schedule work of EQ > > + * entry and armcp_reset event > > * > > * @eq_work - workqueue object to run when EQ entry is received > > * @hdev - pointer to device structure > > -- > > 2.25.1 > > > > This patch is: > Reviewed-by: Oded Gabbay > > Applied to my -fixes tree. > Oded Ah, just saw it is part of a series, so I'm not applying it to my tree. Oded _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel