From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B50C3C433E0 for ; Mon, 29 Jun 2020 15:04:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8194B23E55 for ; Mon, 29 Jun 2020 15:04:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Gi/UlCmh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FHOaKahN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8194B23E55 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LrPRbhL20NeDCV5F+jhCZnYqkif5lgLmg65dWtTeYcU=; b=Gi/UlCmh7t0OB8xEl+sV1ssQU EdH1nY2GMWTOZAMkvvS6AeZbwNU9SZdb1ZQluxs49OjLxQd/xSMmO/6rZPxXzvtSnuufF0t3WJlJT 515mSbcfbT9i22WTNAJ35QfpNMoa4UKjQMqsQrLebEVQAU/l8F0u8JkaADBZtnZMDJJLhG1GQ5w+r aj8ezQCf7iFcl6Bwem8grGqcdTBGS29ubJQ50SGapVqv9ChuUB1Q43A6NG1TCMKjG1hgal0a9QbW3 QYA2DxiDYYxj5gdf9mASlEvHorKoBILUvg5AawEVRRjODTW2hvRmVDyzmMEWumGmaRZYIPmeP/q6Z vE1XjEBQw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpvJB-0000Rq-37; Mon, 29 Jun 2020 15:02:57 +0000 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpvJ8-0000QT-MT for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 15:02:55 +0000 Received: by mail-ot1-x342.google.com with SMTP id 76so1367343otu.9 for ; Mon, 29 Jun 2020 08:02:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L+1Xz44ar6Uipm1PA8hKU1mmGQISJNR16huXvQBXU6I=; b=FHOaKahNgiBqalW/HJ7xU6Lci0yyJ1W3j5q7NdKCfei0LGFhxNl66FqNvW578NF/Tp Xwon/3JNQgjYAGlkDbo5kfqW3ti/ewtur0uxwVKM5NUQ57dHFpKpn6a7HF0CB4Bi/OaU qVX6wx33PATZj2rAQJ6T4gGTP27jbxsH9w4fkPFzbhGgMIX2J4AsQDuBrS2UEUnctgT3 o63jtCu8cDpkUIsx1jddZM1JCLhG20iDpgn6jTJfjDW1oT5PA/o3Eag38rj3CH8aMoTH yMoSN+6rCfEqZb/o59YTB46ceXfNkidS6um7I2w92F0bYK6XQhq9oCVJtrYVXoj71s2E mNwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L+1Xz44ar6Uipm1PA8hKU1mmGQISJNR16huXvQBXU6I=; b=FSx9/NMWD3HTyteox9EXSizqx/dmDRyPblj/KcmraIyEC0it4CFMlwd/Wn7zZbsjJH KSn43VHRWRiC6Q9Df+VDKva2ig10h8mvhzqqrAmTyVsJGg/0aix4aNSB2iIQNgNnEI45 u4RZhk1vQolaQ58K/ERudp8U2rknoas6iaqH94jvVgM7Q9uI3v3vjXS8TTJkkj45sx/r UQQJV+9wLaEGKqXZThE5422arcN/IdIA88Peckl6D+Esq/PdXV0nPz44IJu2yKvXg8wJ ni5HXTMpHcTeOyiwcsLxnHRtAupoOwuPDlu2mSrxHCfuJL6k1ySL8wbNUwYCyyu82ARj BtIA== X-Gm-Message-State: AOAM531usWz8nLbnwkwMSk9fA6ddwJM0RVER8Cfyx5WM9zdP4A9G7Rll V48AmjFnGgP50TACNeEoqSvqdDAu7KLqbvKmyyQ= X-Google-Smtp-Source: ABdhPJxAv3nNA07e6BnrRu3LBTJ+LyIE2q/QM8cY6s6i/AdfdMV0lBURqFifSBhRLBv25JuF3dX27RCSg/1khsAd2mw= X-Received: by 2002:a05:6830:3151:: with SMTP id c17mr14283505ots.143.1593442971967; Mon, 29 Jun 2020 08:02:51 -0700 (PDT) MIME-Version: 1.0 References: <20200629140442.1043957-1-lee.jones@linaro.org> <20200629140442.1043957-11-lee.jones@linaro.org> In-Reply-To: <20200629140442.1043957-11-lee.jones@linaro.org> From: Oded Gabbay Date: Mon, 29 Jun 2020 18:02:24 +0300 Message-ID: Subject: Re: [PATCH 10/20] misc: habanalabs: gaudi: gaudi_security: Repair incorrectly named function arg To: Lee Jones X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Tomer Tayar , linux-arm-kernel@lists.infradead.org, Arnd Bergmann , "Linux-Kernel@Vger. Kernel. Org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 29, 2020 at 5:04 PM Lee Jones wrote: > > audi_pb_set_block()'s argument 'base' was incorrectly named 'block' in gaudi_pb_set_block()'s > its function header. > > Fixes the following W=1 kernel build warning(s): > > drivers/misc/habanalabs/gaudi/gaudi_security.c:454: warning: Function parameter or member 'base' not described in 'gaudi_pb_set_block' > drivers/misc/habanalabs/gaudi/gaudi_security.c:454: warning: Excess function parameter 'block' description in 'gaudi_pb_set_block' > > Cc: Oded Gabbay > Cc: Tomer Tayar > Signed-off-by: Lee Jones > --- > drivers/misc/habanalabs/gaudi/gaudi_security.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/misc/habanalabs/gaudi/gaudi_security.c b/drivers/misc/habanalabs/gaudi/gaudi_security.c > index 6a351e31fa6af..abdd5ed8f2cf6 100644 > --- a/drivers/misc/habanalabs/gaudi/gaudi_security.c > +++ b/drivers/misc/habanalabs/gaudi/gaudi_security.c > @@ -447,8 +447,7 @@ static u64 gaudi_rr_hbw_mask_high_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = { > * gaudi_set_block_as_protected - set the given block as protected > * > * @hdev: pointer to hl_device structure > - * @block: block base address > - * > + * @base: block base address > */ > static void gaudi_pb_set_block(struct hl_device *hdev, u64 base) > { > -- > 2.25.1 > With the above fix, This patch is: Reviewed-by: Oded Gabbay _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel