From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06677C433E0 for ; Fri, 26 Jun 2020 13:47:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C693820679 for ; Fri, 26 Jun 2020 13:47:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gUg5Pzb8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GfJqg3ZN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C693820679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XaPyU71UOVhnrRI3k356BL6/xdHvFRRik3Hm2jrb1qQ=; b=gUg5Pzb8d3eO883CZp9M5Txn8 OiynUVLGYZty9QEjRYq4AxYjPNs81Y7Hxp4AnbJiL/9aXX5v4r487WBl9NThedeH42EJiS4lZkab2 +VW2F7DQgUHduTToBUmm5hFehCM8uIS8CgYraTzrDLducpS3vf8DIMrIiZEAN09V7NQJz8tSUtGoc 4gjsMLrilJkAi9J7M+ogezMOijXMKB+8V2vNJ1p4gKbDbGql/e5vG7O7eNim0/+BfLuiV/GrMFJvy B5zWygPqF1VqKCrZ4vaRL/l2lgTLeJLBvsC5TGBFPnAcnFQsCErZugbzUKHiP3FsQ7IofUegHL9w8 GUdd80ZIQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joofh-0002zK-Rz; Fri, 26 Jun 2020 13:45:37 +0000 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jooff-0002yg-V3 for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 13:45:36 +0000 Received: by mail-ot1-x341.google.com with SMTP id n5so8672122otj.1 for ; Fri, 26 Jun 2020 06:45:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sN17aCLbTayc3AS+U/b9AfFbyEW30u7uEHmtrdAAhYU=; b=GfJqg3ZNt4UmpVgE0QOzDzPcqu7deFiiTDzkNaPw/g2Rg2CHKjHGg0hmOXtpPvcY0/ CBeEK2KnG9t7SWPgigJuoUTyaLeS/RKaO2EDcmIJUc0iyJOpRiHSVwOMQK779VmbvpN0 O2yLAqYC45Ah8oTlY18xIBxXU/6btB2im0xzFtuWqyDdcGeTNtqvwHHlQE03UDSN3sac R9Z/Ray2QbqYiJQkICRgMkBEPZ/+gpcJsIAQS1KT6rlvGxoxc3fxdfcayyjgbEyOD3CT 9oF1c8ge+q2xMSjbBGW1uckJYKHMACMGu/kGW4JJBFf2HZKG+6AsvSTU3exxRMzm9QrA gSAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sN17aCLbTayc3AS+U/b9AfFbyEW30u7uEHmtrdAAhYU=; b=HgP3PrbPolTBsQFLueaH3ebSvPtVyworZLf02xuf7m2H6n6a+6oyenHRLzGI89BmhK 2DMoHrSXB/GnfyuxxnzfNsIlxva1RX59fAKiAJ0mlcsKVBP1n7vCgtjxBOwISYbl9Im2 TqceZ7gK9ZL6QJWOAIDc4dBPhzc/9GQ4Sa6K8t1k28VNpM9X/068G5CxZF7bJPs46zg7 wEReIgvntSmYmgPihVcEFxLGZQK7morczriuWZXYidBqjqc2Rc2OQ2pYcu+gd1KccjM1 2H2veJ9cNcwDuzplfMjCH8lQHsDbd5vD/SXh0ZLzJo7gShKfHH5namGPPE7f6LizfprZ f14Q== X-Gm-Message-State: AOAM5335/50lWXerqS4PAL5TbVGTvkI2AD4zXCZwAQZkLovtc+06gwGk nfI35I3LgVPwYBZf9PGvgVeDR84t4X55qF+PXdU= X-Google-Smtp-Source: ABdhPJwbpmS4V2u2bnYS1ncnxUbpIKYwdxaiYHwUwTCheGy0v9p+7bV6S3hEqDZOE4FyEZd7flC8P0FCcN41dxO/+0Y= X-Received: by 2002:a05:6830:3151:: with SMTP id c17mr2550253ots.143.1593179131960; Fri, 26 Jun 2020 06:45:31 -0700 (PDT) MIME-Version: 1.0 References: <20200626130525.389469-1-lee.jones@linaro.org> <20200626130525.389469-10-lee.jones@linaro.org> In-Reply-To: <20200626130525.389469-10-lee.jones@linaro.org> From: Oded Gabbay Date: Fri, 26 Jun 2020 16:45:04 +0300 Message-ID: Subject: Re: [PATCH 09/10] misc: habanalabs: irq: Add missing struct identifier for 'struct hl_eqe_work' To: Lee Jones X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, Arnd Bergmann , "Linux-Kernel@Vger. Kernel. Org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 26, 2020 at 4:05 PM Lee Jones wrote: > > In kerneldoc format, data structures have to start with 'struct' > else the kerneldoc tooling/parsers/validators get confused. > > Squashes the following W=1 warning: > > drivers/misc/habanalabs/irq.c:19: warning: cannot understand function prototype: 'struct hl_eqe_work ' > > Cc: Oded Gabbay > Signed-off-by: Lee Jones > --- > drivers/misc/habanalabs/irq.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/misc/habanalabs/irq.c b/drivers/misc/habanalabs/irq.c > index fac65fbd70e81..4e77a73857793 100644 > --- a/drivers/misc/habanalabs/irq.c > +++ b/drivers/misc/habanalabs/irq.c > @@ -10,7 +10,8 @@ > #include > > /** > - * This structure is used to schedule work of EQ entry and armcp_reset event > + * struct hl_eqe_work - This structure is used to schedule work of EQ > + * entry and armcp_reset event > * > * @eq_work - workqueue object to run when EQ entry is received > * @hdev - pointer to device structure > -- > 2.25.1 > This patch is: Reviewed-by: Oded Gabbay Applied to my -fixes tree. Oded _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel