From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42200C433E0 for ; Tue, 9 Mar 2021 11:03:49 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCB2D6524C for ; Tue, 9 Mar 2021 11:03:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCB2D6524C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=em+BigwvsteDDVWUJ5Ea/3Xka2ya7IOYDwdhX15nW+E=; b=eTrpwTcIpIT20a5+B5+dnhiGt 7XN2oamLkQOyUsFJTGtHEIuvECeJs3XjGo+1ZQsk0FZGLYSFVWYCDBPT9TL+gr4OaYggGjTOCjMdR 8qollEhajxxlNvCOj/bkATC6hUApGD6DspspFaIy6TdQICsj7rQnQN3UDk/Wp5V02wbzu0Ih7UX6H 8ujZrabU+dgL8xZJtdqS9B/SvBM0TjGJcPWwiv1BgrbimlQ/m4ufYh9VOkTCWrYYSU81RfITNz9Wx asVHMGHjg2XQ3z+usLsqBWk/OoHkOALPgbb1sLfSgFEX8v2bXCYKN4QEZwMXNXMojIBcGl0Sk8H1l YbXaUGV4w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJa7b-004Fda-GB; Tue, 09 Mar 2021 11:01:51 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJa7V-004FdD-Hj for linux-arm-kernel@lists.infradead.org; Tue, 09 Mar 2021 11:01:47 +0000 Received: by mail-ed1-x529.google.com with SMTP id l12so19268120edt.3 for ; Tue, 09 Mar 2021 03:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vdZ4o+zoeGhBm3eWUzEKAm3SjsyvDpQ7XHjJEgZbpvA=; b=mLLgcOkGiUnzFw3UE3oQBVac/QperD9HatYPiTHaHcjhWXjSDD9xGqDW9WAKvrfswy 12Kaqb8Mxo0fSaxpDqm5TJki2Vs+jTW3433sX1ZHcUJ2m4/Pi8FnaoAW78pwEm2X2erO 8fRS7lCr/tep5XCTaV5V8csBu2hfOkYN7lB7rNFPcE42icw/QkJvQMHzxIFuBAyUjAKG INrt/uotzmU+770iB07TJu/T//V7mQ1Qt4g/7OPcU5T2DXTKnmMfH8FkMRcC01sKh52i FJwt39CTqR9mmdQ4vly4YFUdfl8mt8Hy/tDK5ys81SjtV9JAkLVYUbJnVwi+M/VNYQMN 5TUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vdZ4o+zoeGhBm3eWUzEKAm3SjsyvDpQ7XHjJEgZbpvA=; b=igcgYOM6+5ykkC0tZ021+VXX0/319CvJvuGbCUAR6l2gkGloJVd54DdFDEQ2PkdxUF EhXciz+sM4mXfrA0qZPA5nIg4r3p5u16i4uy2ryiDT22na5VKt794190iUrVL/SQFJvr i3P3wkF0bPWLN24NEoU0oK2k31a8jyWwFit4jxJUdv4LNNI9wFk6c6BoP3QF4q1oSk55 S4nhIPaVO9UiZIu0Sz2VmKuA9oRuf13qe+vG+Uji0XEpL/+EYHbfV4N21Nc1dRovY81+ zx1Ru1qRdIWxKZi2h3lkSOa1GQyr3yQnFRiFMUiiu2HtYUvWF+FZklubTbtmgFeSt+F/ 7DmQ== X-Gm-Message-State: AOAM530FkU4cziXTR1QHhkRHP9Jbs7mLVlJBFkespRyMBHfVEd8SBrmQ 6TJ/V1DZMEBP1Joaw9YyILlthqeN9k49bfllOlwSbQ== X-Google-Smtp-Source: ABdhPJxklFVbfFNwNwAAaKz6vbxUZ69o/Z0+23/AeFD9ENbDqkgki+Ljib01MLFfq9nwJFRwK6T2DanfvfvyeHNfctY= X-Received: by 2002:a05:6402:19a:: with SMTP id r26mr3358969edv.44.1615287704169; Tue, 09 Mar 2021 03:01:44 -0800 (PST) MIME-Version: 1.0 References: <20210301142315.30920-1-steven.price@arm.com> <20210301142315.30920-7-steven.price@arm.com> In-Reply-To: <20210301142315.30920-7-steven.price@arm.com> From: Peter Maydell Date: Tue, 9 Mar 2021 11:01:27 +0000 Message-ID: Subject: Re: [PATCH v9 6/6] KVM: arm64: Document MTE capability and ioctl To: Steven Price Cc: Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Julien Thierry , Suzuki K Poulose , kvmarm , arm-mail-list , lkml - Kernel Mailing List , Dave Martin , Mark Rutland , Thomas Gleixner , QEMU Developers , Juan Quintela , "Dr. David Alan Gilbert" , Richard Henderson , Haibo Xu , Andrew Jones X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210309_110145_873294_FBCFCFA3 X-CRM114-Status: GOOD ( 28.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 1 Mar 2021 at 14:23, Steven Price wrote: > > A new capability (KVM_CAP_ARM_MTE) identifies that the kernel supports > granting a guest access to the tags, and provides a mechanism for the > VMM to enable it. > > A new ioctl (KVM_ARM_MTE_COPY_TAGS) provides a simple way for a VMM to > access the tags of a guest without having to maintain a PROT_MTE mapping > in userspace. The above capability gates access to the ioctl. > > Signed-off-by: Steven Price > --- > Documentation/virt/kvm/api.rst | 37 ++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst > index aed52b0fc16e..1406ea138127 100644 > --- a/Documentation/virt/kvm/api.rst > +++ b/Documentation/virt/kvm/api.rst > @@ -4939,6 +4939,23 @@ KVM_XEN_VCPU_ATTR_TYPE_VCPU_TIME_INFO > Allows Xen vCPU attributes to be read. For the structure and types, > see KVM_XEN_VCPU_SET_ATTR above. > > +4.131 KVM_ARM_MTE_COPY_TAGS > +--------------------------- > + > +:Capability: KVM_CAP_ARM_MTE > +:Architectures: arm64 > +:Type: vm ioctl > +:Parameters: struct kvm_arm_copy_mte_tags > +:Returns: 0 on success, < 0 on error > + > +Copies Memory Tagging Extension (MTE) tags to/from guest tag memory. Mostly virt/kvm/api.rst seems to include documentation of the associated structs, something like: :: struct kvm_arm_copy_mte_tags { __u64 guest_ipa; __u64 length; union { void __user *addr; __u64 padding; }; __u64 flags; }; which saves the reader having to cross-reference against the header file. It also means you can more naturally use the actual field names in the doc, eg: > +The > +starting address and length of guest memory must be ``PAGE_SIZE`` aligned. you could say "The guest_ipa and length fields" here. Also "The addr field must point to a buffer which the tags will be copied to or from." I assume. > +The size of the buffer to store the tags is ``(length / MTE_GRANULE_SIZE)`` > +bytes (i.e. 1/16th of the corresponding size). > + Each byte contains a single tag > +value. This matches the format of ``PTRACE_PEEKMTETAGS`` and > +``PTRACE_POKEMTETAGS``. What are the valid values for 'flags' ? It looks like they specify which direction the copy is, which we definitely need to document here. What happens if the caller requests a tag copy for an area of guest address space which doesn't have tags (eg it has nothing mapped), or for an area of guest addres space which has tags in some parts but not in others ? > + > 5. The kvm_run structure > ======================== > > @@ -6227,6 +6244,25 @@ KVM_RUN_BUS_LOCK flag is used to distinguish between them. > This capability can be used to check / enable 2nd DAWR feature provided > by POWER10 processor. > > +7.23 KVM_CAP_ARM_MTE > +-------------------- > + > +:Architectures: arm64 > +:Parameters: none > + > +This capability indicates that KVM (and the hardware) supports exposing the > +Memory Tagging Extensions (MTE) to the guest. It must also be enabled by the > +VMM before the guest will be granted access. > + > +When enabled the guest is able to access tags associated with any memory given > +to the guest. KVM will ensure that the pages are flagged ``PG_mte_tagged`` so > +that the tags are maintained during swap or hibernation of the host, however s/,/;/ > +the VMM needs to manually save/restore the tags as appropriate if the VM is > +migrated. > + > +When enabled the VMM may make use of the ``KVM_ARM_MTE_COPY_TAGS`` ioctl to > +perform a bulk copy of tags to/from the guest "guest." > + > 8. Other capabilities. > ====================== > > @@ -6716,3 +6752,4 @@ KVM_XEN_HVM_SET_ATTR, KVM_XEN_HVM_GET_ATTR, KVM_XEN_VCPU_SET_ATTR and > KVM_XEN_VCPU_GET_ATTR ioctls, as well as the delivery of exception vectors > for event channel upcalls when the evtchn_upcall_pending field of a vcpu's > vcpu_info is set. > + > -- > 2.20.1 Stray whitespace change ? thanks -- PMM _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel