From: Alexandre Mergnat <amergnat@baylibre.com>
To: Chen-Yu Tsai <wens@kernel.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
baylibre-upstreaming@groups.io,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
linux-clk <linux-clk@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH 3/8] clk: meson: gxbb: migrate to the new parent description method
Date: Fri, 26 Jul 2019 12:27:48 +0200 [thread overview]
Message-ID: <CAFGrd9pWdhktEjQzGTTk1zdVVXuXaZL--CFjA-BPwia6AzmRQA@mail.gmail.com> (raw)
In-Reply-To: <CAGb2v64AJFMkZQaytYMN+EsLT0sS-3VwzWUfb3g7SdL7kCfu+g@mail.gmail.com>
Le jeu. 25 juil. 2019 à 19:09, Chen-Yu Tsai <wens@kernel.org> a écrit :
>
> On Thu, Jul 25, 2019 at 10:50 PM Jerome Brunet <jbrunet@baylibre.com> wrote:
> >
> > On Mon 22 Jul 2019 at 11:54, Alexandre Mergnat <amergnat@baylibre.com> wrote:
> >
> >
> > > @@ -1592,13 +1737,29 @@ static struct clk_regmap gxbb_vid_pll_div = {
> > > .hw.init = &(struct clk_init_data) {
> > > .name = "vid_pll_div",
> > > .ops = &meson_vid_pll_div_ro_ops,
> > > - .parent_names = (const char *[]){ "hdmi_pll" },
> > > + .parent_data = &(const struct clk_parent_data) {
> > > + /*
> > > + * This clock is declared here for GXL and GXBB SoC, so
> > > + * we must use string name to set this parent to avoid
> > > + * pointer issue.
> > > + */
> >
> > I don't really get the issue with this comment.
> >
> > How about:
> >
> > /*
> > * Note:
> > * gxl and gxbb have different hdmi_plls (with different struct clk_hw).
> > * We fallback to the global naming string mechanism so vid_pll_div picks
> > * up the appropriate one.
> > */
>
> If you're sticking to global names for now, you could just skip converting
> this clock altogether. I suspect .parent_names will be around for some time.
I prefer to perform a complete migration because it is possible that
.parent_names
becomes deprecated one day. I think it's cleaner to do it one shot and
avoid keeping
redundant structure with the new one.
>
> On the other hand, if you really want to get rid of global clock name based
> parenting, you could use clk_hw pointers, and have the probe function fix
> up this one based on the compatible string. That's what I did.
Sounds good, may I have the commit or file which is implement this please?
I wonder if it worth to add complexity in probe instead of using a dedicated
field in .parent_data for string name. I guess that depend on the complexity
done in probe.
>
> Just my two cents.
>
> ChenYu
>
> > > + .name = "hdmi_pll",
> > > + .index = -1,
> > > + },
> > > .num_parents = 1,
> > > .flags = CLK_SET_RATE_PARENT | CLK_GET_RATE_NOCACHE,
> > > },
> > > };
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-26 10:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 9:54 [PATCH 0/8] clk: meson: ee: use the new parent description method Alexandre Mergnat
2019-07-22 9:54 ` [PATCH 1/8] clk: meson: g12a: move clock declaration to dependency order Alexandre Mergnat
2019-07-22 9:54 ` [PATCH 2/8] clk: meson: g12a: migrate to the new parent description method Alexandre Mergnat
2019-07-22 9:54 ` [PATCH 3/8] clk: meson: gxbb: " Alexandre Mergnat
2019-07-25 14:49 ` Jerome Brunet
2019-07-25 17:09 ` Chen-Yu Tsai
2019-07-26 10:27 ` Alexandre Mergnat [this message]
2019-07-22 9:54 ` [PATCH 4/8] clk: meson: axg: " Alexandre Mergnat
2019-07-22 9:54 ` [PATCH 5/8] clk: meson: meson8b: " Alexandre Mergnat
2019-07-22 9:54 ` [PATCH 6/8] clk: meson: clk-regmap: migrate to " Alexandre Mergnat
2019-07-22 9:54 ` [PATCH 7/8] clk: meson: remove ee input bypass clocks Alexandre Mergnat
2019-07-22 9:54 ` [PATCH 8/8] clk: meson: remove clk input helper Alexandre Mergnat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFGrd9pWdhktEjQzGTTk1zdVVXuXaZL--CFjA-BPwia6AzmRQA@mail.gmail.com \
--to=amergnat@baylibre.com \
--cc=baylibre-upstreaming@groups.io \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=sboyd@kernel.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).