From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49136C43381 for ; Thu, 28 Feb 2019 07:33:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16A3C205C9 for ; Thu, 28 Feb 2019 07:33:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FI9P/FQT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16A3C205C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RbwYiZT3InkQm051zYLWkDNuvfB2LCAl5fcbEosPXiU=; b=FI9P/FQTnKUBTE 0NWvkhNw/I2uwIBwkAJ0XdIIaj1MIAWViEfsoV/C1mWpjXlKXAFT2LWLjhBiZPSNl7keqtQPyhklc BUT+LGQt2m0GOewhqHIhbZauBZsHXWejNJORxsh1a5ndZ+4p5sGank1pJbfeDiict1DXWjttqEO+T 0xaYS0GgsvhPk+TfHG4xkYn9gj3hH7q20JarMb3z7WGGqMb6Phd8FBpFpmuEMTHpgLmwOJ3fu7NC1 3fzP/eAtd6tkTblAfz6K4wq4veop3duWZQ2sCC1RElP5DnGjyYq5Tzx/nKro/4U4TXiCBTU26csY7 rXJuvcIcLFUJ+2cdj6Ww==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzGCV-0005PW-EE; Thu, 28 Feb 2019 07:33:51 +0000 Received: from mail-ot1-f68.google.com ([209.85.210.68]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzGCR-0005PA-Gf for linux-arm-kernel@lists.infradead.org; Thu, 28 Feb 2019 07:33:49 +0000 Received: by mail-ot1-f68.google.com with SMTP id z19so16843446otm.2 for ; Wed, 27 Feb 2019 23:33:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2sOut2gTeCqv2k5ZCeFWMlqYNFLX+NTFC0xPO6pLSTo=; b=Mu82ZdHWpAsrlSwwfG8E+iFS244tbDoq8GlPfdM7xAxUSkSwhgss8pLIayJq2SQ7zL rtiVukfZpQqVwPPgGww9R1E4uRiBYWG9Xq+QLWXeyjgQ602oiJFdUeZkvgxKwxqIuqlu gjdRcTW9H1mkbE6bpcUuCiZHA/W4qO6EftzIcGlWL3g681w47jIZXiH5W8Ae0L2qbVlb afft3krwTCOjJYTMXfohsj99AgD2T9YUKFuJgc988HYtz81kk9wFyY5Qhese98rWTLui JCar8m1hDXn4JyyQgzG4335BM774yUpewfcv65IJYtaJWbU5ug10bU+QRHQWV3gqEv6R NBog== X-Gm-Message-State: AHQUAuarM8SxWK2CF4//H0OgKBfskrTWcT4xwnT8LsX10tjZZVZGYjTI wLYIRvosOuTsSBcfoatkXSJHXRw53Swm7VAe5wA= X-Google-Smtp-Source: AHgI3IaWkTdHjJFUbtFOG11qSjKzkKC1+eXrp1YzdjS/LpqUGVfCIztH8sWL+VM1mZhTsKHyaiOviJTjek/WXLSx+lQ= X-Received: by 2002:a9d:67d2:: with SMTP id c18mr5002000otn.339.1551339226560; Wed, 27 Feb 2019 23:33:46 -0800 (PST) MIME-Version: 1.0 References: <20190215163220.20041-1-paul.kocialkowski@bootlin.com> <387ed483-b205-beda-319d-6f2b8ea55601@gmail.com> <38f6708476e9beca4583ccc2a62e238a4981b735.camel@bootlin.com> <958bb823-3dc8-607f-3c38-3d902acb85a8@gmail.com> <20190219172515.GC13075@lunn.ch> <9cb2f7a8-a8cf-ef80-d260-cc67c072b5c5@xilinx.com> <8bb813fb-102b-00c9-fb6f-a3e928965051@xilinx.com> In-Reply-To: From: Harini Katakam Date: Thu, 28 Feb 2019 13:03:35 +0530 Message-ID: Subject: Re: [PATCH RESEND net] net: phy: xgmiitorgmii: Support generic PHY status read To: Michal Simek X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190227_233347_556778_DB3D1EFE X-CRM114-Status: GOOD ( 20.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Kocialkowski , Thomas Petazzoni , "David S . Miller" , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, Feb 27, 2019 at 2:35 PM Harini Katakam wrote: > > Hi Andrew, Paul, > > On Wed, Feb 27, 2019 at 2:15 PM Michal Simek wrote: > > > > On 21. 02. 19 12:03, Michal Simek wrote: > > > On 21. 02. 19 11:24, Paul Kocialkowski wrote: > > >> Hi, > > >> > > >> On Wed, 2019-02-20 at 07:58 +0100, Michal Simek wrote: > > >>> Hi, > > >>> > > >>> On 19. 02. 19 18:25, Andrew Lunn wrote: > > >> Understood. I think we need to start a discussion about how the general > > >> design of this driver can be improved. > > >> > > >> In particular, I wonder if it could work better to make this driver a > > >> PHY driver that just redirects all its ops to the actual PHY driver, > > >> except for read_status where it should also add some code. > > Thanks, I'm looking into this option and also a way to expose the correct > interface mode setting as you mentioned below. I'll get back before the > end of the week. Please do let me know if you have any further suggestions. > This IP does not have a PHY identifier or status register that can be accessed from the phy framework. We could discuss with our design team to add these in the future. But that would take sometime and this version should be still be supported. Also, if this IP has a PHY driver, then two phy drivers would have to be probed which are connected in a serial manner and I believe I'll have to update the framework to support that. Could you please let me know if you have any inputs on this? OR since this is just a bridge IP, is it acceptable to address the error cases? -> Module loading/unloading -> Spinlocks for protection -> Correct phy mode information to the driver. -> Any other concerns I could do a respin of this patch after addressing Andrew's comments: https://patchwork.kernel.org/patch/9290231/ Regards, Harini _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel