From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFACCFA3728 for ; Wed, 16 Oct 2019 19:20:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C04AC2053B for ; Wed, 16 Oct 2019 19:20:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PoqISmfj"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="rdImgBV5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C04AC2053B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iniVAeVzseuuzVp9fic/kQWdufZR3QIAFAZe0viUL8w=; b=PoqISmfjL96kJw mAumHmVT24CQNAQGCX99RD6xfhS/Mj50ZOO7uRW3YZyUz7Jz0xrNwmTz/9baHip4nsMEwJ3i+WY3L Wlv+YV8G16Zib6edanE+QGEeE75Oh53EiI3pSVHkAPs5GAH5yjL6dilj+b2MZMnCt+gS3rWd/oyIU WZ/X3q5E1Xd2WejDw/fVPex9yEwKVCZRhDLnVpP4jhv3/1+/TLxzPkCuaMS+7uS2DG2lJhvpFeKwm wzkaEtXlcxn4G5qEiTL2TYXFnwAs5b3RFsvt77upk/vuHnWa9j9U54G7/zBU5cpwxhYkfylzK6SMa xGBI/59MSJSjO70Aj6EA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKoql-0003gL-7k; Wed, 16 Oct 2019 19:20:47 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKoqh-0003fe-WF for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2019 19:20:45 +0000 Received: by mail-pg1-x541.google.com with SMTP id e13so6652966pga.7 for ; Wed, 16 Oct 2019 12:20:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nkjcBI/sR0pHQa7Q6ZwYOj6wNZTv9s5BqUzK5l7ttQg=; b=rdImgBV5rSX819CWsaELSfHqCFtbKBlCgDcC1RDvmhUH4cxrZllIk9JJ4A3ft2cndE VEW0TUE7aluFb5sGutlpLF2zLOxMvSjZwYBpPZtUjPS91c1gOcqbTdlVsLDBKyZzpSWr N6IBsIPY8HYN5UsQs0atjxR9M+89To10Rks6ATMcWvWv8du5xxvXx79yxrzCY5rbCd6N X1aNnwHNB6nVARAEp7XKbKHn/2myhZkH1jy8CwLaM36qFh9YNuxoOTcz5Dz2QJBILuA3 p93/vdRHF7+ABcOD8H8+CGE+/YqpYaOxrSkiHdYXsVxtuzBjBdn2WRPevotJpnYSBGeg ItaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nkjcBI/sR0pHQa7Q6ZwYOj6wNZTv9s5BqUzK5l7ttQg=; b=KHFLxsa+x7NfOSCRIcoy5Rx+355YHRrSXF5FfeMs7GE1XuYSnX5H6LxXwFVmIGb5zu Sxkq3QD8hhAXr/mbPhfNveEhpnbBti9AfH8CJWE3yi9Pq7+7PolpYIkFXD+5C6UCQ7Mm UU6Z++z1p5ZGYW/YS1YfPchoP5uUtdqccLTzehoF0YOUadXfQI0aE9Zvz/75qoRHRRAR jx6w1MRytX5G8eshWLV8YTuETGEpjaeBNqVZiuktWU5CkWfWx9OsjqYTi1bVcLaK8RnK VqdTawz1ydi0nCFQDaQIwHFJKaAlv+ZdILRvkWC37882eK61ivJU4hDwBvcl5WhIh0Ea 34zA== X-Gm-Message-State: APjAAAVxL61Kn+8dzACGjfS6/at9rNlUHDdJcOy4MJjdY45G8BsW5Wcg 3/78uYy/WptLVa/39rAFJkMDbPLtTsJjYzf3Dm2MRA== X-Google-Smtp-Source: APXvYqwoWZoU1NQcYrpdH/oqoCAqIzIKZ/BPjYCIHumscCSMLtnNlqQsKoIXYT9B0G5ZK//ak2ZZhT8vfvalCP74+kc= X-Received: by 2002:a17:90a:2451:: with SMTP id h75mr7096361pje.131.1571253639855; Wed, 16 Oct 2019 12:20:39 -0700 (PDT) MIME-Version: 1.0 References: <20191009212034.20325-1-jae.hyun.yoo@linux.intel.com> <49244d71-cbc3-f2ae-97ac-74b5f68a4816@fb.com> <4ca4083d-23ff-0475-f5fd-ec3745b440b2@linux.intel.com> In-Reply-To: <4ca4083d-23ff-0475-f5fd-ec3745b440b2@linux.intel.com> From: Brendan Higgins Date: Wed, 16 Oct 2019 12:20:28 -0700 Message-ID: Subject: Re: [PATCH] i2c: aspeed: fix master pending state handling To: Jae Hyun Yoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191016_122044_038978_C9727746 X-CRM114-Status: GOOD ( 13.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , "linux-aspeed@lists.ozlabs.org" , Wolfram Sang , Andrew Jeffery , Tao Ren , "openbmc@lists.ozlabs.org" , "linux-i2c@vger.kernel.org" , Rob Herring , Joel Stanley , Benjamin Herrenschmidt , "linux-arm-kernel@lists.infradead.org" , Cedric Le Goater Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 10, 2019 at 4:52 PM Jae Hyun Yoo wrote: > > On 10/10/2019 4:29 PM, Tao Ren wrote: > > On 10/9/19 2:20 PM, Jae Hyun Yoo wrote: > >> In case of master pending state, it should not trigger a master > >> command, otherwise data could be corrupted because this H/W shares > >> the same data buffer for slave and master operations. It also means > >> that H/W command queue handling is unreliable because of the buffer > >> sharing issue. To fix this issue, it clears command queue if a > >> master command is queued in pending state to use S/W solution > >> instead of H/W command queue handling. Also, it refines restarting > >> mechanism of the pending master command. > >> > >> Fixes: 2e57b7cebb98 ("i2c: aspeed: Add multi-master use case support") > >> Signed-off-by: Jae Hyun Yoo > > > > Tested-by: Tao Ren > > > > Tested the patch on Facebook Minipack BMC (multi-master i2c-0 environment) and > > everything looks good to me. Looks like we got the necessary tested-bys and reviewed-bys. Can we apply this for next? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel