From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D8E8C7618B for ; Thu, 25 Jul 2019 15:45:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7245A22BED for ; Thu, 25 Jul 2019 15:45:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nt49wRw7"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eTOznLn+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7245A22BED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NyZIelMcQ8xa9EaEnVctU+4Lwxo33ExE1l8eEozjB5E=; b=nt49wRw77P6OjJ fXXEgt6dkZupBjOQfMdlqRljCuKzfM5fgXKHLLQFfODX8CCA7V3+x8G24gf8Gkdz3iPl7AvNqrJHV uYuKqyUT+PjfMBs594ahhZ4HJkhpxGDn7Dy+8MEiwK/ZY6fhlsHJNiWuJmEa3SvRZm1nHCPUZJE+k 8vhcawwmT4I235ki3iwYfUVnx7gILE0+sWYCv8R9jWqD7Bb8gAqZfEC2VF4PsihOPGaQbuyvt59cJ A9K2WR0vhJ84NSYjOv0qas6YQDdqsYb9pj8E3q5T8zjIglyHJYqLmWc7bGaCiX9O8dV1Y9NLv5+h2 QG0xvtv8wM2BJh1pYZqQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqfvy-0004L2-4j; Thu, 25 Jul 2019 15:45:34 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqfvt-0004Kb-3S for linux-arm-kernel@lists.infradead.org; Thu, 25 Jul 2019 15:45:32 +0000 Received: by mail-qk1-x741.google.com with SMTP id v22so36766613qkj.8 for ; Thu, 25 Jul 2019 08:45:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h9LGzcmkICoUxxnlsKC1X8+vEgPSc2yFtdgmoYyCqVU=; b=eTOznLn++Utw/g86SVzVuaVK7I0aakMdCZQ3RXLow3bWFqC6FEn1BAn+IwBIf7R/2v 6Slc74WqGZA7wE4T24iZ8Bbik2zKVUMxMgq1AC1nWqwiBgNAXYBYuBbSUW6nNkXXeXEk a3jYEur+RgOILRIWjyspfNOz0eWobPX5uXhPTFhpA+j3l7sg8bV2ARY7ewfNPBns4DhS 70TZ5wEpNqT3f8180TE89tLZ7RE75wa5t9gjSjz4iO9KCOonY+lMl0QoRS/zeuRnXg5W 7El8YflEXESsW8klp7SPggQ/WYDB7xJ2vZqZu+OPxO83BkexdhH//NqFH18Dw+/EJtOu r1gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h9LGzcmkICoUxxnlsKC1X8+vEgPSc2yFtdgmoYyCqVU=; b=NXSOaKDkKt5xY5cxYgaM0TYJ+XD9NNF30GaCrutsaM37BEODjhn0xgsYsLUymDpqHs V+ftnuTTbEa4rWNVtl+K5AS2ZgGbhUP6zBOZspsOBUtnLon2AUmGtSsjMxTEeWXij2Yi AvNYdGHS+eb1ED89lHr0C9qK3vxOL9NWdgfP0joU3JQQOYb9EqMk/Lgq1AJwtUhbN34e a/7E2qC1bX/ZwsuK3kSZKF2Xdj9bDn7oCGUC6+559m+LNm4geKf2QlmvhIdmLjLXeCgb rV8ebYFYoMmylrqhqeRVrDjObmMTb+RjMuyiLazoTeayTQ83qz9BM7oXiPj3BDS5eBMr GSaA== X-Gm-Message-State: APjAAAXpH6o5pplECz7S1v2u+GJg1+kTU1ACLADG1b1WMxrwZOrvNWEP kgSxYRUBvpW6x733Cyp4lkIJ7HZmfEcXHu88vdcGYE2gs04= X-Google-Smtp-Source: APXvYqxY72xEBRVS89mBErI1mAprdvEV9KhovYroU0JluOTrl1dAMhVk3vobs8tqeT4U3WOuQbG1TUtXWdRhP+UKDn4= X-Received: by 2002:a05:620a:15b3:: with SMTP id f19mr57674190qkk.314.1564069527465; Thu, 25 Jul 2019 08:45:27 -0700 (PDT) MIME-Version: 1.0 References: <20190722151154.8344568BFE@verein.lst.de> In-Reply-To: From: Enric Balletbo Serra Date: Thu, 25 Jul 2019 17:45:15 +0200 Message-ID: Subject: Re: [PATCH v3 5/7] drm/bridge: Add Analogix anx6345 support To: Vasily Khoruzhick X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190725_084529_182413_E3DE3178 X-CRM114-Status: GOOD ( 24.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Sean Paul , Maxime Ripard , Greg Kroah-Hartman , linux-kernel , dri-devel , David Airlie , Chen-Yu Tsai , Rob Herring , Torsten Duwe , Laurent Pinchart , Harald Geyer , Thierry Reding , Thomas Gleixner , arm-linux , Icenowy Zheng Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Missatge de Vasily Khoruzhick del dia dl., 22 de jul. 2019 a les 20:50: > > On Mon, Jul 22, 2019 at 8:11 AM Torsten Duwe wrote: > > > > From: Icenowy Zheng > > > > The ANX6345 is an ultra-low power DisplayPower/eDP transmitter designed > > for portable devices. This driver adds initial support for RGB to eDP > > mode, without HPD and interrupts. > > > > This is a configuration usually seen in eDP applications. > > > > Signed-off-by: Icenowy Zheng > > Signed-off-by: Vasily Khoruzhick > > Signed-off-by: Torsten Duwe > > --- > > drivers/gpu/drm/bridge/analogix/Kconfig | 12 + > > drivers/gpu/drm/bridge/analogix/Makefile | 1 + > > drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 797 +++++++++++++++++++++ > > 3 files changed, 810 insertions(+) > > create mode 100644 drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > > > > --- a/drivers/gpu/drm/bridge/analogix/Kconfig > > +++ b/drivers/gpu/drm/bridge/analogix/Kconfig > > @@ -1,6 +1,18 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > +config DRM_ANALOGIX_ANX6345 > > + tristate "Analogix ANX6345 bridge" > > + select DRM_ANALOGIX_DP > > + select DRM_KMS_HELPER > > + select REGMAP_I2C > > + help > > + ANX6345 is an ultra-low Full-HD DisplayPort/eDP > > + transmitter designed for portable devices. The > > + ANX6345 transforms the LVTTL RGB output of an > > + application processor to eDP or DisplayPort. > > + > > config DRM_ANALOGIX_ANX78XX > > tristate "Analogix ANX78XX bridge" > > + select DRM_ANALOGIX_DP > > select DRM_KMS_HELPER > > select REGMAP_I2C > > help > > --- a/drivers/gpu/drm/bridge/analogix/Makefile > > +++ b/drivers/gpu/drm/bridge/analogix/Makefile > > @@ -1,4 +1,5 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > analogix_dp-objs := analogix_dp_core.o analogix_dp_reg.o analogix-i2c-dptx.o > > +obj-$(CONFIG_DRM_ANALOGIX_ANX6345) += analogix-anx6345.o > > obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o > > obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix_dp.o > > --- /dev/null > > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > > @@ -0,0 +1,793 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +/* > > + * Copyright(c) 2016, Analogix Semiconductor. > > + * Copyright(c) 2017, Icenowy Zheng > > + * > > + * Based on anx7808 driver obtained from chromeos with copyright: > > + * Copyright(c) 2013, Google Inc. > > + */ > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "analogix-i2c-dptx.h" > > +#include "analogix-i2c-txcommon.h" > > + > > +#define POLL_DELAY 50000 /* us */ > > +#define POLL_TIMEOUT 5000000 /* us */ > > + > > +#define I2C_IDX_DPTX 0 > > +#define I2C_IDX_TXCOM 1 > > + > > +static const u8 anx6345_i2c_addresses[] = { > > + [I2C_IDX_DPTX] = ANALOGIX_I2C_DPTX, > > + [I2C_IDX_TXCOM] = ANALOGIX_I2C_TXCOMMON, > > +}; > > +#define I2C_NUM_ADDRESSES ARRAY_SIZE(anx6345_i2c_addresses) > > + > > +struct anx6345 { > > + struct drm_dp_aux aux; > > + struct drm_bridge bridge; > > + struct i2c_client *client; > > + struct edid *edid; > > + struct drm_connector connector; > > + struct drm_dp_link link; > > + struct drm_panel *panel; > > + struct regulator *dvdd12; > > + struct regulator *dvdd25; > > + struct gpio_desc *gpiod_reset; > > + struct mutex lock; /* protect EDID access */ > > + > > + /* I2C Slave addresses of ANX6345 are mapped as DPTX and SYS */ > > + struct i2c_client *i2c_clients[I2C_NUM_ADDRESSES]; > > + struct regmap *map[I2C_NUM_ADDRESSES]; > > + > > + u16 chipid; > > + u8 dpcd[DP_RECEIVER_CAP_SIZE]; > > + > > + bool powered; > > +}; > > + > > +static inline struct anx6345 *connector_to_anx6345(struct drm_connector *c) > > +{ > > + return container_of(c, struct anx6345, connector); > > +} > > + > > +static inline struct anx6345 *bridge_to_anx6345(struct drm_bridge *bridge) > > +{ > > + return container_of(bridge, struct anx6345, bridge); > > +} > > + > > +static int anx6345_set_bits(struct regmap *map, u8 reg, u8 mask) > > +{ > > + return regmap_update_bits(map, reg, mask, mask); > > +} > > + > > +static int anx6345_clear_bits(struct regmap *map, u8 reg, u8 mask) > > +{ > > + return regmap_update_bits(map, reg, mask, 0); > > +} > > + > > +static ssize_t anx6345_aux_transfer(struct drm_dp_aux *aux, > > + struct drm_dp_aux_msg *msg) > > +{ > > + struct anx6345 *anx6345 = container_of(aux, struct anx6345, aux); > > + > > + return anx_dp_aux_transfer(anx6345->map[I2C_IDX_DPTX], msg); > > +} > > + > > +static int anx6345_dp_link_training(struct anx6345 *anx6345) > > +{ > > + unsigned int value; > > + u8 dp_bw; > > + int err; > > + > > + err = anx6345_clear_bits(anx6345->map[I2C_IDX_TXCOM], > > + SP_POWERDOWN_CTRL_REG, > > + SP_TOTAL_PD); > > + if (err) > > + return err; > > + > > + err = drm_dp_dpcd_readb(&anx6345->aux, DP_MAX_LINK_RATE, &dp_bw); > > + if (err < 0) > > + return err; > > + > > + switch (dp_bw) { > > + case DP_LINK_BW_1_62: > > + case DP_LINK_BW_2_7: > > + break; > > + > > + default: > > + DRM_DEBUG_KMS("DP bandwidth (%#02x) not supported\n", dp_bw); > > + return -EINVAL; > > + } > > + > > + err = anx6345_set_bits(anx6345->map[I2C_IDX_TXCOM], SP_VID_CTRL1_REG, > > + SP_VIDEO_MUTE); > > + if (err) > > + return err; > > + > > + err = anx6345_clear_bits(anx6345->map[I2C_IDX_TXCOM], > > + SP_VID_CTRL1_REG, SP_VIDEO_EN); > > + if (err) > > + return err; > > + > > + /* Get DPCD info */ > > + err = drm_dp_dpcd_read(&anx6345->aux, DP_DPCD_REV, > > + &anx6345->dpcd, DP_RECEIVER_CAP_SIZE); > > + if (err < 0) { > > + DRM_ERROR("Failed to read DPCD: %d\n", err); > > + return err; > > + } > > + > > + /* Clear channel x SERDES power down */ > > + err = anx6345_clear_bits(anx6345->map[I2C_IDX_DPTX], > > + SP_DP_ANALOG_POWER_DOWN_REG, SP_CH0_PD); > > + if (err) > > + return err; > > + > > + /* Check link capabilities */ > > + err = drm_dp_link_probe(&anx6345->aux, &anx6345->link); > > + if (err < 0) { > > + DRM_ERROR("Failed to probe link capabilities: %d\n", err); > > + return err; > > + } > > + > > + /* Power up the sink */ > > + err = drm_dp_link_power_up(&anx6345->aux, &anx6345->link); > > + if (err < 0) { > > + DRM_ERROR("Failed to power up DisplayPort link: %d\n", err); > > + return err; > > + } > > + > > + /* Possibly enable downspread on the sink */ > > + err = regmap_write(anx6345->map[I2C_IDX_DPTX], > > + SP_DP_DOWNSPREAD_CTRL1_REG, 0); > > + if (err) > > + return err; > > + > > + if (anx6345->dpcd[DP_MAX_DOWNSPREAD] & DP_MAX_DOWNSPREAD_0_5) { > > + DRM_DEBUG("Enable downspread on the sink\n"); > > + /* 4000PPM */ > > + err = regmap_write(anx6345->map[I2C_IDX_DPTX], > > + SP_DP_DOWNSPREAD_CTRL1_REG, 8); > > + if (err) > > + return err; > > + > > + err = drm_dp_dpcd_writeb(&anx6345->aux, DP_DOWNSPREAD_CTRL, > > + DP_SPREAD_AMP_0_5); > > + if (err < 0) > > + return err; > > + } else { > > + err = drm_dp_dpcd_writeb(&anx6345->aux, DP_DOWNSPREAD_CTRL, 0); > > + if (err < 0) > > + return err; > > + } > > + > > + /* Set the lane count and the link rate on the sink */ > > + if (drm_dp_enhanced_frame_cap(anx6345->dpcd)) > > + err = anx6345_set_bits(anx6345->map[I2C_IDX_DPTX], > > + SP_DP_SYSTEM_CTRL_BASE + 4, > > + SP_ENHANCED_MODE); > > + else > > + err = anx6345_clear_bits(anx6345->map[I2C_IDX_DPTX], > > + SP_DP_SYSTEM_CTRL_BASE + 4, > > + SP_ENHANCED_MODE); > > + if (err) > > + return err; > > + > > + value = drm_dp_link_rate_to_bw_code(anx6345->link.rate); > > + err = regmap_write(anx6345->map[I2C_IDX_DPTX], > > + SP_DP_MAIN_LINK_BW_SET_REG, value); > > + if (err) > > + return err; > > + > > + err = regmap_write(anx6345->map[I2C_IDX_DPTX], > > + SP_DP_LANE_COUNT_SET_REG, anx6345->link.num_lanes); > > + if (err) > > + return err; > > + > > + err = drm_dp_link_configure(&anx6345->aux, &anx6345->link); > > + if (err < 0) { > > + DRM_ERROR("Failed to configure DisplayPort link: %d\n", err); > > + return err; > > + } > > + > > + /* Start training on the source */ > > + err = regmap_write(anx6345->map[I2C_IDX_DPTX], SP_DP_LT_CTRL_REG, > > + SP_LT_EN); > > + if (err) > > + return err; > > + > > + return regmap_read_poll_timeout(anx6345->map[I2C_IDX_DPTX], > > + SP_DP_LT_CTRL_REG, > > + value, !(value & SP_DP_LT_INPROGRESS), > > + POLL_DELAY, POLL_TIMEOUT); > > +} > > + > > +static int anx6345_tx_initialization(struct anx6345 *anx6345) > > +{ > > + int err, i; > > + > > + /* FIXME: colordepth is hardcoded for now */ > > + err = regmap_write(anx6345->map[I2C_IDX_TXCOM], SP_VID_CTRL2_REG, > > + SP_IN_BPC_6BIT << SP_IN_BPC_SHIFT); > > + if (err) > > + return err; > > + > > + err = regmap_write(anx6345->map[I2C_IDX_DPTX], SP_DP_PLL_CTRL_REG, 0); > > + if (err) > > + return err; > > + > > + err = regmap_write(anx6345->map[I2C_IDX_TXCOM], > > + SP_ANALOG_DEBUG1_REG, 0); > > + if (err) > > + return err; > > + > > + err = regmap_write(anx6345->map[I2C_IDX_DPTX], > > + SP_DP_LINK_DEBUG_CTRL_REG, > > + SP_NEW_PRBS7 | SP_M_VID_DEBUG); > > + if (err) > > + return err; > > + > > + err = regmap_write(anx6345->map[I2C_IDX_DPTX], > > + SP_DP_ANALOG_POWER_DOWN_REG, 0); > > + if (err) > > + return err; > > + > > + /* Force HPD */ > > + err = anx6345_set_bits(anx6345->map[I2C_IDX_DPTX], > > + SP_DP_SYSTEM_CTRL_BASE + 3, > > + SP_HPD_FORCE | SP_HPD_CTRL); > > + if (err) > > + return err; > > + > > + for (i = 0; i < 4; i++) { > > + /* 4 lanes */ > > + err = regmap_write(anx6345->map[I2C_IDX_DPTX], > > + SP_DP_LANE0_LT_CTRL_REG + i, 0); > > + if (err) > > + return err; > > + } > > + > > + /* Reset AUX */ > > + err = anx6345_set_bits(anx6345->map[I2C_IDX_TXCOM], > > + SP_RESET_CTRL2_REG, SP_AUX_RST); > > + if (err) > > + return err; > > + > > + return anx6345_clear_bits(anx6345->map[I2C_IDX_TXCOM], > > + SP_RESET_CTRL2_REG, SP_AUX_RST); > > +} > > + > > +static void anx6345_poweron(struct anx6345 *anx6345) > > +{ > > + int err; > > + > > + /* Ensure reset is asserted before starting power on sequence */ > > + gpiod_set_value_cansleep(anx6345->gpiod_reset, 1); > > + usleep_range(1000, 2000); > > + > > + err = regulator_enable(anx6345->dvdd12); > > + if (err) { > > + DRM_ERROR("Failed to enable dvdd12 regulator: %d\n", > > + err); > > + return; > > + } > > + > > + /* T1 - delay between VDD12 and VDD25 should be 0-2ms */ > > + usleep_range(1000, 2000); > > + > > + err = regulator_enable(anx6345->dvdd25); > > + if (err) { > > + DRM_ERROR("Failed to enable dvdd25 regulator: %d\n", > > + err); > > + return; > > + } > > + > > + /* T2 - delay between RESETN and all power rail stable, > > + * should be 2-5ms > > + */ > > + usleep_range(2000, 5000); > > + > > + gpiod_set_value_cansleep(anx6345->gpiod_reset, 0); > > + > > + /* Power on registers module */ > > + anx6345_set_bits(anx6345->map[I2C_IDX_TXCOM], SP_POWERDOWN_CTRL_REG, > > + SP_HDCP_PD | SP_AUDIO_PD | SP_VIDEO_PD | SP_LINK_PD); > > + anx6345_clear_bits(anx6345->map[I2C_IDX_TXCOM], SP_POWERDOWN_CTRL_REG, > > + SP_REGISTER_PD | SP_TOTAL_PD); > > + > > + if (anx6345->panel) > > + drm_panel_prepare(anx6345->panel); > > + > > + anx6345->powered = true; > > +} > > + > > +static void anx6345_poweroff(struct anx6345 *anx6345) > > +{ > > + int err; > > + > > + gpiod_set_value_cansleep(anx6345->gpiod_reset, 1); > > + usleep_range(1000, 2000); > > + > > + if (anx6345->panel) > > + drm_panel_unprepare(anx6345->panel); > > + > > + err = regulator_disable(anx6345->dvdd25); > > + if (err) { > > + DRM_ERROR("Failed to disable dvdd25 regulator: %d\n", > > + err); > > + return; > > + } > > + > > + usleep_range(5000, 10000); > > + > > + err = regulator_disable(anx6345->dvdd12); > > + if (err) { > > + DRM_ERROR("Failed to disable dvdd12 regulator: %d\n", > > + err); > > + return; > > + } > > + > > + usleep_range(1000, 2000); > > + > > + anx6345->powered = false; > > +} > > + > > +static int anx6345_start(struct anx6345 *anx6345) > > +{ > > + int err; > > + > > + if (!anx6345->powered) > > + anx6345_poweron(anx6345); > > + > > + /* Power on needed modules */ > > + err = anx6345_clear_bits(anx6345->map[I2C_IDX_TXCOM], > > + SP_POWERDOWN_CTRL_REG, > > + SP_VIDEO_PD | SP_LINK_PD); > > + > > + err = anx6345_tx_initialization(anx6345); > > + if (err) { > > + DRM_ERROR("Failed eDP transmitter initialization: %d\n", err); > > + anx6345_poweroff(anx6345); > > + return err; > > + } > > + > > + err = anx6345_dp_link_training(anx6345); > > + if (err) { > > + DRM_ERROR("Failed link training: %d\n", err); > > + anx6345_poweroff(anx6345); > > + return err; > > + } > > + > > + /* > > + * This delay seems to help keep the hardware in a good state. Without > > + * it, there are times where it fails silently. > > + */ > > + usleep_range(10000, 15000); > > + > > + return 0; > > +} > > + > > +static int anx6345_config_dp_output(struct anx6345 *anx6345) > > +{ > > + int err; > > + > > + err = anx6345_clear_bits(anx6345->map[I2C_IDX_TXCOM], SP_VID_CTRL1_REG, > > + SP_VIDEO_MUTE); > > + if (err) > > + return err; > > + > > + /* Enable DP output */ > > + err = anx6345_set_bits(anx6345->map[I2C_IDX_TXCOM], SP_VID_CTRL1_REG, > > + SP_VIDEO_EN); > > + if (err) > > + return err; > > + > > + /* Force stream valid */ > > + return anx6345_set_bits(anx6345->map[I2C_IDX_DPTX], > > + SP_DP_SYSTEM_CTRL_BASE + 3, > > + SP_STRM_FORCE | SP_STRM_CTRL); > > +} > > + > > +static int anx6345_get_downstream_info(struct anx6345 *anx6345) > > +{ > > + u8 value; > > + int err; > > + > > + err = drm_dp_dpcd_readb(&anx6345->aux, DP_SINK_COUNT, &value); > > + if (err < 0) { > > + DRM_ERROR("Get sink count failed %d\n", err); > > + return err; > > + } > > + > > + if (!DP_GET_SINK_COUNT(value)) { > > + DRM_ERROR("Downstream disconnected\n"); > > + return -EIO; > > + } > > + > > + return 0; > > +} > > + > > +static int anx6345_get_modes(struct drm_connector *connector) > > +{ > > + struct anx6345 *anx6345 = connector_to_anx6345(connector); > > + int err, num_modes = 0; > > + bool power_off = false; > > + > > + mutex_lock(&anx6345->lock); > > + > > + if (!anx6345->edid) { > > + if (!anx6345->powered) { > > + anx6345_poweron(anx6345); > > + power_off = true; > > + } > > + > > + err = anx6345_get_downstream_info(anx6345); > > + if (err) { > > + DRM_ERROR("Failed to get downstream info: %d\n", err); > > + goto unlock; > > + } > > + > > + anx6345->edid = drm_get_edid(connector, &anx6345->aux.ddc); > > + if (!anx6345->edid) > > + DRM_ERROR("Failed to read EDID from panel\n"); > > + > > + err = drm_connector_update_edid_property(connector, > > + anx6345->edid); > > + if (err) { > > + DRM_ERROR("Failed to update EDID property: %d\n", err); > > + goto unlock; > > + } > > + } > > + > > + num_modes += drm_add_edid_modes(connector, anx6345->edid); > > + > > +unlock: > > + if (power_off) > > + anx6345_poweroff(anx6345); > > + > > + mutex_unlock(&anx6345->lock); > > + > > + if (!num_modes && anx6345->panel) > > + num_modes += drm_panel_get_modes(anx6345->panel); > > + > > + return num_modes; > > +} > > + > > +static const struct drm_connector_helper_funcs anx6345_connector_helper_funcs = { > > + .get_modes = anx6345_get_modes, > > +}; > > + > > +static void > > +anx6345_connector_destroy(struct drm_connector *connector) > > +{ > > + struct anx6345 *anx6345 = connector_to_anx6345(connector); > > + > > + if (anx6345->panel) > > + drm_panel_detach(anx6345->panel); > > + drm_connector_cleanup(connector); > > +} > > + > > +static const struct drm_connector_funcs anx6345_connector_funcs = { > > + .fill_modes = drm_helper_probe_single_connector_modes, > > + .destroy = anx6345_connector_destroy, > > + .reset = drm_atomic_helper_connector_reset, > > + .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, > > + .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, > > +}; > > + > > +static int anx6345_bridge_attach(struct drm_bridge *bridge) > > +{ > > + struct anx6345 *anx6345 = bridge_to_anx6345(bridge); > > + int err; > > + > > + if (!bridge->encoder) { > > + DRM_ERROR("Parent encoder object not found"); > > + return -ENODEV; > > + } > > + > > + /* Register aux channel */ > > + anx6345->aux.name = "DP-AUX"; > > + anx6345->aux.dev = &anx6345->client->dev; > > + anx6345->aux.transfer = anx6345_aux_transfer; > > + > > + err = drm_dp_aux_register(&anx6345->aux); > > + if (err < 0) { > > + DRM_ERROR("Failed to register aux channel: %d\n", err); > > + return err; > > + } > > + > > + err = drm_connector_init(bridge->dev, &anx6345->connector, > > + &anx6345_connector_funcs, > > + DRM_MODE_CONNECTOR_eDP); > > + if (err) { > > + DRM_ERROR("Failed to initialize connector: %d\n", err); > > + return err; > > + } > > + > > + drm_connector_helper_add(&anx6345->connector, > > + &anx6345_connector_helper_funcs); > > + > > + err = drm_connector_register(&anx6345->connector); > > + if (err) { > > + DRM_ERROR("Failed to register connector: %d\n", err); > > + return err; > > + } > > + > > + anx6345->connector.polled = DRM_CONNECTOR_POLL_HPD; > > + > > + err = drm_connector_attach_encoder(&anx6345->connector, > > + bridge->encoder); > > + if (err) { > > + DRM_ERROR("Failed to link up connector to encoder: %d\n", err); > > + return err; > > + } > > + > > + if (anx6345->panel) { > > + err = drm_panel_attach(anx6345->panel, &anx6345->connector); > > + if (err) { > > + DRM_ERROR("Failed to attach panel: %d\n", err); > > + return err; > > + } > > + } > > + > > + return 0; > > +} > > + > > +static enum drm_mode_status > > +anx6345_bridge_mode_valid(struct drm_bridge *bridge, > > + const struct drm_display_mode *mode) > > +{ > > + if (mode->flags & DRM_MODE_FLAG_INTERLACE) > > + return MODE_NO_INTERLACE; > > + > > + /* Max 1200p at 5.4 Ghz, one lane */ > > + if (mode->clock > 154000) > > + return MODE_CLOCK_HIGH; > > + > > + return MODE_OK; > > +} > > + > > +static void anx6345_bridge_disable(struct drm_bridge *bridge) > > +{ > > + struct anx6345 *anx6345 = bridge_to_anx6345(bridge); > > + > > + /* Power off all modules except configuration registers access */ > > + anx6345_set_bits(anx6345->map[I2C_IDX_TXCOM], SP_POWERDOWN_CTRL_REG, > > + SP_HDCP_PD | SP_AUDIO_PD | SP_VIDEO_PD | SP_LINK_PD); > > + if (anx6345->panel) > > + drm_panel_disable(anx6345->panel); > > + > > + if (anx6345->powered) > > + anx6345_poweroff(anx6345); > > +} > > + > > +static void anx6345_bridge_enable(struct drm_bridge *bridge) > > +{ > > + struct anx6345 *anx6345 = bridge_to_anx6345(bridge); > > + int err; > > + > > + if (anx6345->panel) > > + drm_panel_enable(anx6345->panel); > > + > > + err = anx6345_start(anx6345); > > + if (err) { > > + DRM_ERROR("Failed to initialize: %d\n", err); > > + return; > > + } > > + > > + err = anx6345_config_dp_output(anx6345); > > + if (err) > > + DRM_ERROR("Failed to enable DP output: %d\n", err); > > +} > > + > > +static const struct drm_bridge_funcs anx6345_bridge_funcs = { > > + .attach = anx6345_bridge_attach, > > + .mode_valid = anx6345_bridge_mode_valid, > > + .disable = anx6345_bridge_disable, > > + .enable = anx6345_bridge_enable, > > +}; > > + > > +static void unregister_i2c_dummy_clients(struct anx6345 *anx6345) > > +{ > > + unsigned int i; > > + > > + for (i = 1; i < ARRAY_SIZE(anx6345->i2c_clients); i++) > > + if (anx6345->i2c_clients[i] && > > + anx6345->i2c_clients[i]->addr != anx6345->client->addr) > > + i2c_unregister_device(anx6345->i2c_clients[i]); > > +} > > + > > +static const struct regmap_config anx6345_regmap_config = { > > + .reg_bits = 8, > > + .val_bits = 8, > > + .max_register = 0xff, > > + .cache_type = REGCACHE_NONE, > > +}; > > + > > +static const u16 anx6345_chipid_list[] = { > > + 0x6345, > > +}; > > + > > +static bool anx6345_get_chip_id(struct anx6345 *anx6345) > > +{ > > + unsigned int i, idl, idh, version; > > + > > + if (regmap_read(anx6345->map[I2C_IDX_TXCOM], SP_DEVICE_IDL_REG, &idl)) > > + return false; > > + > > + if (regmap_read(anx6345->map[I2C_IDX_TXCOM], SP_DEVICE_IDH_REG, &idh)) > > + return false; > > + > > + anx6345->chipid = (u8)idl | ((u8)idh << 8); > > + > > + if (regmap_read(anx6345->map[I2C_IDX_TXCOM], SP_DEVICE_VERSION_REG, > > + &version)) > > + return false; > > + > > + for (i = 0; i < ARRAY_SIZE(anx6345_chipid_list); i++) { > > + if (anx6345->chipid == anx6345_chipid_list[i]) { > > + DRM_INFO("Found ANX%x (ver. %d) eDP Transmitter\n", > > + anx6345->chipid, version); > > + return true; > > + } > > + } > > + > > + DRM_ERROR("ANX%x (ver. %d) not supported by this driver\n", > > + anx6345->chipid, version); > > + > > + return false; > > +} > > + > > +static int anx6345_i2c_probe(struct i2c_client *client, > > + const struct i2c_device_id *id) > > +{ > > + struct anx6345 *anx6345; > > + struct device *dev; > > + int i, err; > > + > > + anx6345 = devm_kzalloc(&client->dev, sizeof(*anx6345), GFP_KERNEL); > > + if (!anx6345) > > + return -ENOMEM; > > + > > + mutex_init(&anx6345->lock); > > + > > + anx6345->bridge.of_node = client->dev.of_node; > > + > > + anx6345->client = client; > > + i2c_set_clientdata(client, anx6345); > > + > > + dev = &anx6345->client->dev; > > + > > + err = drm_of_find_panel_or_bridge(client->dev.of_node, 1, 0, > > + &anx6345->panel, NULL); > > + if (err == -EPROBE_DEFER) > > + return err; > > + > > + if (err) > > + DRM_DEBUG("No panel found\n"); > > + > > + /* 1.2V digital core power regulator */ > > + anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12-supply"); > > + if (IS_ERR(anx6345->dvdd12)) { > > + DRM_ERROR("dvdd12-supply not found\n"); > > + return PTR_ERR(anx6345->dvdd12); > > + } > > + > > + /* 2.5V digital core power regulator */ > > + anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25-supply"); > > + if (IS_ERR(anx6345->dvdd25)) { > > + DRM_ERROR("dvdd25-supply not found\n"); > > + return PTR_ERR(anx6345->dvdd25); > > + } > > + > > + /* GPIO for chip reset */ > > + anx6345->gpiod_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); > > + if (IS_ERR(anx6345->gpiod_reset)) { > > + DRM_ERROR("Reset gpio not found\n"); > > + return PTR_ERR(anx6345->gpiod_reset); > > + } > > + > > + /* Map slave addresses of ANX6345 */ > > + for (i = 0; i < I2C_NUM_ADDRESSES; i++) { > > + if (anx6345_i2c_addresses[i] >> 1 != client->addr) > > + anx6345->i2c_clients[i] = i2c_new_dummy(client->adapter, > > + anx6345_i2c_addresses[i] >> 1); > > + else > > + anx6345->i2c_clients[i] = client; > > + > > + if (!anx6345->i2c_clients[i]) { > > + err = -ENOMEM; > > + DRM_ERROR("Failed to reserve I2C bus %02x\n", > > + anx6345_i2c_addresses[i]); > > + goto err_unregister_i2c; > > + } > > + > > + anx6345->map[i] = devm_regmap_init_i2c(anx6345->i2c_clients[i], > > + &anx6345_regmap_config); > > + if (IS_ERR(anx6345->map[i])) { > > + err = PTR_ERR(anx6345->map[i]); > > + DRM_ERROR("Failed regmap initialization %02x\n", > > + anx6345_i2c_addresses[i]); > > + goto err_unregister_i2c; > > + } > > + } > > + > > + /* Look for supported chip ID */ > > + anx6345_poweron(anx6345); > > + if (anx6345_get_chip_id(anx6345)) { > > + anx6345->bridge.funcs = &anx6345_bridge_funcs; > > + drm_bridge_add(&anx6345->bridge); > > + > > + return 0; > > + } else { > > + anx6345_poweroff(anx6345); > > + err = -ENODEV; > > + } > > + > > +err_unregister_i2c: > > + unregister_i2c_dummy_clients(anx6345); > > + return err; > > +} > > + > > +static int anx6345_i2c_remove(struct i2c_client *client) > > +{ > > + struct anx6345 *anx6345 = i2c_get_clientdata(client); > > + > > + drm_bridge_remove(&anx6345->bridge); > > + > > + unregister_i2c_dummy_clients(anx6345); > > + > > + kfree(anx6345->edid); > > + > > + mutex_destroy(&anx6345->lock); > > + > > + return 0; > > +} > > + > > +static const struct i2c_device_id anx6345_id[] = { > > + { "anx6345", 0 }, > > + { /* sentinel */ } > > +}; > > +MODULE_DEVICE_TABLE(i2c, anx6345_id); > > + > > +static const struct of_device_id anx6345_match_table[] = { > > + { .compatible = "analogix,anx6345", }, > > + { /* sentinel */ }, > > +}; > > +MODULE_DEVICE_TABLE(of, anx6345_match_table); > > + > > +static struct i2c_driver anx6345_driver = { > > + .driver = { > > + .name = "anx6345", > > + .of_match_table = of_match_ptr(anx6345_match_table), > > + }, > > + .probe = anx6345_i2c_probe, > > + .remove = anx6345_i2c_remove, > > + .id_table = anx6345_id, > > +}; > > +module_i2c_driver(anx6345_driver); > > + > > +MODULE_DESCRIPTION("ANX6345 eDP Transmitter driver"); > > +MODULE_AUTHOR("Enric Balletbo i Serra "); > > I believe Icenowy is the author of this driver. If you think otherwise > please add Enric to CC and get his Signed-off-by. > I think that the only reason my name appears here is because is a copy/paste from analogix-anx78xx.c (probably this driver took that file as a reference?). Indeed I am not the author of this driver, so Icenowy should be here, not me. Thanks, Enric > > +MODULE_LICENSE("GPL v2"); > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel