From: Enric Balletbo Serra <eballetbo@gmail.com>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
chun-jie.chen@mediatek.corp-partner.google.com,
Yong Wu <yong.wu@mediatek.com>
Subject: Re: [PATCH 3/3] arm64: dts: mt8183: remove syscon from smi_common node
Date: Mon, 31 May 2021 23:39:35 +0200 [thread overview]
Message-ID: <CAFqH_53DWQVRVHVr8EVSR6A2oVqC4_4VjkE6n77g5kfBaa2+4A@mail.gmail.com> (raw)
In-Reply-To: <20210531043502.2702645-3-hsinyi@chromium.org>
Hi Hsin-Yi,
(again without html, sorry for the noise)
Thank you for the patch.
Missatge de Hsin-Yi Wang <hsinyi@chromium.org> del dia dl., 31 de maig
2021 a les 6:36:
>
> We don't need to register smi_common as syscon. Also add required
> property power-domains for this node.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index c5e822b6b77a..e074c0d402ff 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -1263,13 +1263,14 @@ larb0: larb@14017000 {
> };
>
> smi_common: smi@14019000 {
> - compatible = "mediatek,mt8183-smi-common", "syscon";
> + compatible = "mediatek,mt8183-smi-common";
> reg = <0 0x14019000 0 0x1000>;
> clocks = <&mmsys CLK_MM_SMI_COMMON>,
> <&mmsys CLK_MM_SMI_COMMON>,
> <&mmsys CLK_MM_GALS_COMM0>,
> <&mmsys CLK_MM_GALS_COMM1>;
> clock-names = "apb", "smi", "gals0", "gals1";
> + power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
> };
>
> imgsys: syscon@15020000 {
> --
> 2.32.0.rc0.204.g9fa02ecfa5-goog
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-31 21:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 4:35 [PATCH 1/3] soc: mtk-pm-domains: Fix the clock prepared issue Hsin-Yi Wang
2021-05-31 4:35 ` [PATCH 2/3] soc: mtk-pm-domains: do not register smi node as syscon Hsin-Yi Wang
2021-05-31 11:36 ` Chun-Jie Chen
2021-05-31 21:36 ` Enric Balletbo Serra
2021-05-31 4:35 ` [PATCH 3/3] arm64: dts: mt8183: remove syscon from smi_common node Hsin-Yi Wang
2021-05-31 21:39 ` Enric Balletbo Serra [this message]
2021-05-31 10:42 ` [PATCH 1/3] soc: mtk-pm-domains: Fix the clock prepared issue Chun-Jie Chen
2021-05-31 21:38 ` Enric Balletbo Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFqH_53DWQVRVHVr8EVSR6A2oVqC4_4VjkE6n77g5kfBaa2+4A@mail.gmail.com \
--to=eballetbo@gmail.com \
--cc=chun-jie.chen@mediatek.corp-partner.google.com \
--cc=enric.balletbo@collabora.com \
--cc=hsinyi@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).