From: Souptick Joarder <jrdr.linux@gmail.com> To: Heiko Stuebner <heiko@sntech.de> Cc: Michal Hocko <mhocko@suse.com>, Peter Zijlstra <peterz@infradead.org>, dri-devel@lists.freedesktop.org, hjc@rock-chips.com, Linux-MM <linux-mm@kvack.org>, linux1394-devel@lists.sourceforge.net, Stephen Rothwell <sfr@canb.auug.org.au>, oleksandr_andrushchenko@epam.com, joro@8bytes.org, Russell King - ARM Linux <linux@armlinux.org.uk>, Matthew Wilcox <willy@infradead.org>, airlied@linux.ie, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-media@vger.kernel.org, pawel@osciak.com, Rik van Riel <riel@surriel.com>, iommu@lists.linux-foundation.org, rppt@linux.vnet.ibm.com, Boris Ostrovsky <boris.ostrovsky@oracle.com>, mchehab@kernel.org, vbabka@suse.cz, Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org, xen-devel@lists.xen.org, Kyungmin Park <kyungmin.park@samsung.com>, Andrew Morton <akpm@linux-foundation.org>, robin.murphy@arm.com, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> Subject: Re: [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API Date: Fri, 1 Feb 2019 18:08:04 +0530 Message-ID: <CAFqt6zbMHG3htSsOwV3SaEEp1rMbFCoDD_3EacDk1hw_a1HJeQ@mail.gmail.com> (raw) In-Reply-To: <1572595.mVW1PIlZyR@phil> On Thu, Jan 31, 2019 at 6:04 PM Heiko Stuebner <heiko@sntech.de> wrote: > > Am Donnerstag, 31. Januar 2019, 13:31:52 CET schrieb Souptick Joarder: > > On Thu, Jan 31, 2019 at 5:37 PM Heiko Stuebner <heiko@sntech.de> wrote: > > > > > > Am Donnerstag, 31. Januar 2019, 04:08:12 CET schrieb Souptick Joarder: > > > > Previouly drivers have their own way of mapping range of > > > > kernel pages/memory into user vma and this was done by > > > > invoking vm_insert_page() within a loop. > > > > > > > > As this pattern is common across different drivers, it can > > > > be generalized by creating new functions and use it across > > > > the drivers. > > > > > > > > vm_insert_range() is the API which could be used to mapped > > > > kernel memory/pages in drivers which has considered vm_pgoff > > > > > > > > vm_insert_range_buggy() is the API which could be used to map > > > > range of kernel memory/pages in drivers which has not considered > > > > vm_pgoff. vm_pgoff is passed default as 0 for those drivers. > > > > > > > > We _could_ then at a later "fix" these drivers which are using > > > > vm_insert_range_buggy() to behave according to the normal vm_pgoff > > > > offsetting simply by removing the _buggy suffix on the function > > > > name and if that causes regressions, it gives us an easy way to revert. > > > > > > > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > > > > Suggested-by: Russell King <linux@armlinux.org.uk> > > > > Suggested-by: Matthew Wilcox <willy@infradead.org> > > > > > > hmm, I'm missing a changelog here between v1 and v2. > > > Nevertheless I managed to test v1 on Rockchip hardware > > > and display is still working, including talking to Lima via prime. > > > > > > So if there aren't any big changes for v2, on Rockchip > > > Tested-by: Heiko Stuebner <heiko@sntech.de> > > > > Change log is available in [0/9]. > > Patch [1/9] & [4/9] have no changes between v1 -> v2. > > I never seem to get your cover-letters, so didn't see that, sorry. I added you in sender list for all cover-letters but it didn't reach your inbox :-) Thanks for reviewing and validating the patch. > > But great that there weren't changes then :-) > > Heiko > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply index Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-31 3:08 Souptick Joarder 2019-01-31 8:38 ` Mike Rapoport 2019-01-31 10:13 ` Souptick Joarder 2019-01-31 11:06 ` Mike Rapoport 2019-02-07 15:49 ` Souptick Joarder 2019-02-07 15:57 ` Mike Rapoport 2019-02-07 16:07 ` Souptick Joarder 2019-02-07 16:04 ` Mike Rapoport 2019-02-07 16:47 ` Matthew Wilcox 2019-02-08 5:22 ` Souptick Joarder 2019-02-11 17:06 ` Souptick Joarder 2019-01-31 12:06 ` Heiko Stuebner 2019-01-31 12:31 ` Souptick Joarder 2019-01-31 12:34 ` Heiko Stuebner 2019-02-01 12:38 ` Souptick Joarder [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAFqt6zbMHG3htSsOwV3SaEEp1rMbFCoDD_3EacDk1hw_a1HJeQ@mail.gmail.com \ --to=jrdr.linux@gmail.com \ --cc=airlied@linux.ie \ --cc=akpm@linux-foundation.org \ --cc=boris.ostrovsky@oracle.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=heiko@sntech.de \ --cc=hjc@rock-chips.com \ --cc=iommu@lists.linux-foundation.org \ --cc=jgross@suse.com \ --cc=joro@8bytes.org \ --cc=kirill.shutemov@linux.intel.com \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=linux1394-devel@lists.sourceforge.net \ --cc=linux@armlinux.org.uk \ --cc=mchehab@kernel.org \ --cc=mhocko@suse.com \ --cc=oleksandr_andrushchenko@epam.com \ --cc=pawel@osciak.com \ --cc=peterz@infradead.org \ --cc=riel@surriel.com \ --cc=robin.murphy@arm.com \ --cc=rppt@linux.vnet.ibm.com \ --cc=sfr@canb.auug.org.au \ --cc=vbabka@suse.cz \ --cc=willy@infradead.org \ --cc=xen-devel@lists.xen.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ARM-Kernel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \ linux-arm-kernel@lists.infradead.org public-inbox-index linux-arm-kernel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git