From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D319C433DF for ; Thu, 6 Aug 2020 14:59:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23EBB204FD for ; Thu, 6 Aug 2020 14:59:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XBaRvAtb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=0x0f.com header.i=@0x0f.com header.b="RU0tPU8b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23EBB204FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=0x0f.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DJmMGqFTiBnkcidXfkMGYS13WjU+ZQHRujY6+dL7Xi4=; b=XBaRvAtbV4//8r9JfRUxCiJvb r/49krjlfMbpC/847HG2KxZVl3Eo2IueWaG0BBIySLQk2V59fdvI5ePkQHqBPhLXBXtkpuSW0yM4u LNucpVK3dVi/pmbwMBHFElh9y70MvpkSFuBHMwOpfSp9rgnlVaAhNdm5dB/Ip97f4Uuckyab6XlrP 0yUadTbwTKpisBp6BwCS7zOgE7fIPct2RXt0sZa4ylHzbIW/vTGamnxR2o3ygTqtW3VGmovhmNY2Q XnIm5GeC0Jy3O9MAszNGDL/+JU2ljbDgNM+ghhU0x534YyPCFig3/ZDB+VXXCUcLAMqoHF2U5rCvz iZJVU6HlQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3hLj-0007F0-Fn; Thu, 06 Aug 2020 14:58:31 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3hLh-0007E2-J5 for linux-arm-kernel@lists.infradead.org; Thu, 06 Aug 2020 14:58:30 +0000 Received: by mail-wr1-x443.google.com with SMTP id a5so34341132wrm.6 for ; Thu, 06 Aug 2020 07:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0x0f.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I2QgUmIlO6maUIvLNmFMIgB6tFghLiGYEgxkf43Wx9U=; b=RU0tPU8bAxRiOuvHY7DJRlCCP2+QRbiYTaM0EYG5OIICce80n/byLWVwV7uLOp8vjb zWbCdW/3rPa2b9W3bVCAqFeyee6Kk5YIEQGfReqtSa12vcltpB6yZj0yIp6dXYe+ZXTA uj1D2Zs5Yu49k1Pzvv5W7vUodcbxEQk3yvggE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I2QgUmIlO6maUIvLNmFMIgB6tFghLiGYEgxkf43Wx9U=; b=BQZjmJpsinCaBHIwf3Zms9RnilMKCimgJMjP3rMAB7HjIF22cOKXSr8Xq7jtqKb2lx H6XuVPwIX0I/RG5JHsJqwntHHufniJjYVDZSZLqVDhMKVyJF4gedCf1IeVzry4EegNxu vEkscJ839qkuNEPbrciJUjMTtt4I9CVO0XkH6WUjqsNqTcqdYFe9ugXmjDFpau7HYEfc wPj0UB28nS+nOhiA88+mh6kbHMAkT3VYs4sSiAD/hyWKll3W5GqWX7rko7ikMgyX8ze7 gwbLO0vXF2L9kwbKrmlZHoxiNbZiOel1sIkaVu6dxQbVpQ9iZYwYrM1uRXSWpPqwDeVc ubWA== X-Gm-Message-State: AOAM533ArCPCBjWmNkxH5kBbuwFCFOZCben3CAKWkOssU6MSIK45/1/A b+1OCMtwoLgCrcrkbocsKKKQTd8XHpm93aTgHBWpug== X-Google-Smtp-Source: ABdhPJxei3fOQSc5RtFiRdeqUA8wYj3HA5L3OtFNsjWOwMSmZXT0JK+Zw+6cm6ro6Yk62WFzA6yS7yy5PVLA37ZNW0U= X-Received: by 2002:adf:ed85:: with SMTP id c5mr7800963wro.307.1596725908629; Thu, 06 Aug 2020 07:58:28 -0700 (PDT) MIME-Version: 1.0 References: <20200806140739.31501-1-mark-pk.tsai@mediatek.com> In-Reply-To: <20200806140739.31501-1-mark-pk.tsai@mediatek.com> From: Daniel Palmer Date: Thu, 6 Aug 2020 23:58:33 +0900 Message-ID: Subject: Re: [PATCH 0/2] irqchip: irq-mt58xx: Add mt58xx series interrupt To: Mark-PK Tsai X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200806_105829_668335_734D4132 X-CRM114-Status: GOOD ( 26.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DTML , alix.wu@mediatek.com, Jason Cooper , Marc Zyngier , yj.chiang@mediatek.com, linux-kernel@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Thomas Gleixner , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mark-PK, On Thu, 6 Aug 2020 at 23:08, Mark-PK Tsai wrote: > > Do you know if it would be possible to confirm if they are > > the > > same thing? MediaTek bought MStar a few years ago so it seems likely > > but I have no hard information. > > > > Yes, it's for the same interrupt controller IP. That's good news. :) > > If they are the same thing could we work on making one series that > > supports both use cases? > > Sure, and I think the irq controller driver should support both use cases. > So how about keep the MTK version driver? I'm fine with that. Maybe you can push the MTK version and I can send a small patch after that to add the small bits I need? > I'll send patch v2 after -rc1 as I mentioned in the previous mail, > and keep you posted. > And any suggestion is welcome. :) I think Marc's comments on my series apply to your driver and I think maybe answer some of the questions you had. For example what to do about the read-modify-write sequence for updating the registers. > > It's also possible that if the interrupt controller is the same some > > other things like the SPI NOR controller etc are also common and > > working > > on a single driver for those would save us both time. > > I'm not sure about that. > I'll check the patches you contributed and confirm with our driver owners. I have a very messy tree with support for the SPI NOR controller, SPI, i2c etc that were used in MStar chips. If any of those are shared it'd be great to know. Thanks, Daniel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel