From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D997C433F5 for ; Tue, 21 Sep 2021 06:13:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2BB6E61107 for ; Tue, 21 Sep 2021 06:13:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2BB6E61107 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=0x0f.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8phklWOBpRy8AxRXB1bg5XQN+bvcaG5PO3EIF9a7spo=; b=kPNJi22YW7kmy+ JxOlEWWU3QROZGe/e7zX2USTUJfSLIY0T8I9QNrlhF3GiMDOMjxyJYpCNRHxWPkSU+l21JX75XoJ3 DmNGBJMy3XGQOTPpAMs/viiBRjKWRZQ9Mjg3ivy/i++5RKp/3XjjF3fABJj0rzoKYmVi6AkgNRt8E R3olobQ4Vs3cCbiTBN4X8PivSXyCWCx2JkJMQ45hXUnTZ8uZ8SQCAZuEB2nv8hdB1nY3bDTb5XD9z OFtLMU+MkHCflFzrIoh+feJ5pLXJF8DTWadIzzjgb03oXypQAy3I22jEFwhEoH7//osuYEIWvHZf6 0O0C8TCFUai/z6xuvXUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSZ0T-003gYN-D6; Tue, 21 Sep 2021 06:11:53 +0000 Received: from mail-vk1-xa35.google.com ([2607:f8b0:4864:20::a35]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSZ0N-003gWe-Oc for linux-arm-kernel@lists.infradead.org; Tue, 21 Sep 2021 06:11:51 +0000 Received: by mail-vk1-xa35.google.com with SMTP id s137so3049733vke.11 for ; Mon, 20 Sep 2021 23:11:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0x0f.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OF6AOba2o4jFsvu9MeKiI7Ggmm85qvKBExZTEUMcveM=; b=VuguOngjzz4WH8sPWcj67TGgfLZBK40/vQ5FUMQzYS1OEEsUtS2GNpTylVQ91r9jyN MVC/elImEADbG8CSGAPmGikgihQJGX30R9jMnnwQlsAL2dIBz+Qc3Z2Vck9zKR+RIztt 8bSjxTDkUPUQwtggriF9s4Mop370EB237tpaw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OF6AOba2o4jFsvu9MeKiI7Ggmm85qvKBExZTEUMcveM=; b=lhgEjjaqX1AsFiuL5sTHJW4I77eXBkJ2j7KmFnK6Bt1KI/CvIAsWelyb52ucAatuhW B2UjHsFN7olewlGscl0GWSYAZn6i0zUP+aQ0H52WRd5I4XM1z+UYhlAXB1tVabX3pyM2 NRSD5yOlBXw5MQH1FMqwWeTuX9qloH7dJBq2tKW2dHE2UCOxuko0vXcpXWbZc1XrPf7X 694zLoqkZTbRhFqodn9iTssNks+YOxSkSFqG2qXnfkGnUnYkF1ND2R1EbEQKlTeIcBha fVSo2yswALNoRRVFOIv2+CtaHI3NGElftbJ9w+QJpyAv/iO+iBTlCxKoqMstQ/8S+8Mr FVag== X-Gm-Message-State: AOAM531HmH4MiCIidXy5RJ3vByGnyIYezdtvaE914Nx7efBSxpOE3J7w 7+Wst2UkNIaEQEzdjVrdDp0BvtZZGa8QSGkb5LZeQw== X-Google-Smtp-Source: ABdhPJzrNTe66lD5hcAQj/G8thxbFqN5NwIXMxbAq0yZGq+5J4cryNMgQKrIwr4sc4PMD4ny5qa98PY1d/RaYdHc7Fg= X-Received: by 2002:a1f:9f10:: with SMTP id i16mr10188784vke.0.1632204705849; Mon, 20 Sep 2021 23:11:45 -0700 (PDT) MIME-Version: 1.0 References: <20210914100415.1549208-1-daniel@0x0f.com> <20210914100415.1549208-3-daniel@0x0f.com> <87zgs7vavl.wl-maz@kernel.org> <87wnnbv6ac.wl-maz@kernel.org> In-Reply-To: <87wnnbv6ac.wl-maz@kernel.org> From: Daniel Palmer Date: Tue, 21 Sep 2021 15:11:35 +0900 Message-ID: Subject: Re: [PATCH 2/3] irqchip: SigmaStar SSD20xD gpi To: Marc Zyngier Cc: DTML , Rob Herring , Thomas Gleixner , linux-arm-kernel , Romain Perier X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_231148_080184_B0D8927D X-CRM114-Status: GOOD ( 20.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc, Sorry for the constant email. On Mon, 20 Sept 2021 at 20:24, Marc Zyngier wrote: > > On Mon, 20 Sep 2021 11:05:26 +0100, > Daniel Palmer wrote: > > > > Hi Marc, > > > > On Mon, 20 Sept 2021 at 18:45, Marc Zyngier wrote: > > > > +static void ssd20xd_gpi_unmask_irq(struct irq_data *data) > > > > +{ > > > > + irq_hw_number_t hwirq = irqd_to_hwirq(data); > > > > + struct ssd20xd_gpi *gpi = irq_data_get_irq_chip_data(data); > > > > + int offset_reg = REG_OFFSET(hwirq); > > > > + int offset_bit = BIT_OFFSET(hwirq); > > > > + > > > > + regmap_update_bits(gpi->regmap, REG_MASK + offset_reg, offset_bit, 0); > > > > > > Is this regmap call atomic? When running this, you are holding a > > > raw_spinlock already. From what I can see, this is unlikely to work > > > correctly with the current state of regmap. > > > > I didn't even think about it. I will check. > > You may want to enable lockdep to verify that. After some research I think this can be solved by adding ".use_raw_spinlock = true" to the regmap config to force using a raw_spinlock instead of the default spinlock. This avoids having a spinlock inside of a raw_spinlock. lockdep doesn't actually complain about this currently but another interrupt controller driver I have uses a syscon because the interrupt registers are mixed in with unrelated stuff. lockdep is complaining about the spinlock inside of a raw_spinlock there. So I guess I'll need to add a new DT property for syscon to use raw_spinlocks for that driver. Cheers, Daniel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel