From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E40DFC433EF for ; Mon, 27 Sep 2021 22:52:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA24C610E8 for ; Mon, 27 Sep 2021 22:52:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AA24C610E8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=0x0f.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CKoFjD6eC6OdLGD1LFyy+aAR0iC15doPn/Ao8uMtVG8=; b=DSs4APdNvY4EtX fuyqwpeSas1JLx4K4Xda8IoZV850zZGENk0Op1KwWr6Vp6URFx0XsguX2dhoT2CjG+LfzmUVGEh67 9PQxhzM4lVzcCKDkswOrl5nO5gL4JaGihMnlRWA7zE9BA8m1gajr812Ndi3b7jkEH7q77BAZWnuEL aY7dvmHki9OPk8yg70hBAc5ie9z9zkgy/6h4FEU6WvP2rwTu4ukqZcvn0/8Sa4TA0cHj2SOGxwG/+ U6lfS5W6bjAnox5pamSI3KF0UjjCUMsyFBGnzm3zcZacmHF8dzcfI18cjtCPkutRwmEyaDmgOHFaH Aa50iegshuox9lAwVkrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUzRT-004knk-9d; Mon, 27 Sep 2021 22:49:47 +0000 Received: from mail-ua1-x92a.google.com ([2607:f8b0:4864:20::92a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUzRL-004kkS-Fh for linux-arm-kernel@lists.infradead.org; Mon, 27 Sep 2021 22:49:41 +0000 Received: by mail-ua1-x92a.google.com with SMTP id k32so5373450uae.2 for ; Mon, 27 Sep 2021 15:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0x0f.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l3Govj1Ggv6fnK3dXfFXh4R4w4mAAKZUo/5Lt6qGfhI=; b=Iq5vAXCv2EMz7F+Lo3dTfVrteNUNq7v81PHVhbhOsX5XpUjjgXfRLR72Oozo+4Rd28 avv9yUHE6tuOtdTZvzc9WXaYi+m9yRhkz0esk2t4hBvj2j9/iNMEYnDKiLQv27KlzGnU KNtCEtConX/KW5Z8fpL4XbTssq9e8C35PemeE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l3Govj1Ggv6fnK3dXfFXh4R4w4mAAKZUo/5Lt6qGfhI=; b=UCkbVs6kmT8RxiJqKRRCiuQ0NVasY/FkWx4Sow1JT6uEdCQC/Qlsf52/8IaAjgzanS Jc/CzHUjacrAYDL9is6F45iuuXpP7WIh1m6bLz/gIFvuASUx3Z2I/MGcjNOlDLqXVNz8 lNt7JDKCu/8c02+kMTuzyNYLUSZP8hg1Cl+UAT2ikt8JBO5hjCWXjYfQ+2l5jWA3YB/O 93PQVzkBff9R2jt2XIOOB5p7X1ioe3XRjAbTYQnXNTf2PX83NufVHmK4Ww67MsN3OFT0 OCWYTBz73e7Mbcpxv9tE7bAp0YvZvnKbGAqj8A+/ET7uww0+PGWZUdD8LbAKg6crPgO+ uyhQ== X-Gm-Message-State: AOAM533dh0m4FDpfnzYCxVtUdMQ3XzDbEC671jasoFuzLiNUXwaA8XJW pYVIbft+CASBSxhzc+7tWKabH9+lpQqeV8jPV+X5cw== X-Google-Smtp-Source: ABdhPJw93xHWEfPQbedVUspaJQ+Kpz4lDjxMsiLCz9VQF0pLxWLXngzwY9I3WjVpCLk0lSx8d9/HMX6++hBMj4ge2eY= X-Received: by 2002:ab0:8c1:: with SMTP id o1mr2454160uaf.113.1632782977502; Mon, 27 Sep 2021 15:49:37 -0700 (PDT) MIME-Version: 1.0 References: <20210923065500.2284347-1-daniel@0x0f.com> <20210923065500.2284347-4-daniel@0x0f.com> In-Reply-To: From: Daniel Palmer Date: Tue, 28 Sep 2021 07:51:40 +0900 Message-ID: Subject: Re: [PATCH v2 03/11] dt-bindings: leds: Document "activity" trigger To: Rob Herring Cc: DTML , "open list:GPIO SUBSYSTEM" , linux-leds@vger.kernel.org, Linus Walleij , Bartosz Golaszewski , pavel@ucw.cz, linux-arm-kernel , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210927_154939_678529_170414B9 X-CRM114-Status: GOOD ( 14.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On Tue, 28 Sept 2021 at 04:52, Rob Herring wrote: > > On Thu, Sep 23, 2021 at 03:54:52PM +0900, Daniel Palmer wrote: > > The "activity" trigger can be used as the default but it's currently > > undocumented so validating a devicetree that uses it causes a warning. > > It is preferred to use 'function' and LED_FUNCTION_CPU. Is there some > reason that can't be used? LED_FUNCTION_CPU seems to be tied to drivers/leds/trigger/ledtrig-cpu.c which I think serves the same purpose but does it a slightly different way. Would adding LED_FUNCTION_ACTIVITY work? Thanks, Daniel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel