From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92332C76186 for ; Wed, 17 Jul 2019 08:14:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A4B12077C for ; Wed, 17 Jul 2019 08:14:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GeY7z9Yf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="G9skQ3aR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A4B12077C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gn/Wd4HSfrATR482d01KMIBMPsANhnmzRNKShmK5eoA=; b=GeY7z9YfG+4klv WO/M9cLbeuVCEbRbZ88BOF7ChhKhlWNNDlGkaM7pZUZpXeva3sGzFY9wK45OT4svivayugp8kFO46 ZSzbgFIxj5PwbAB9E9naEWXrdvZ200bu3lEI+UJZOXfwtiy3onQXi45jx7ehF6AGDuIuJo7oUoFkj pIR/cDPfs6xftE1Pzkv41nw72Z99XGNlRJuWHaMYN2Szyt33IaYyAVQEEByykhoIBIzhVpNOfEYdC Z0dVBTTJ5W7m/C4U3Z0EYehQXHwLY5ArI4c9uZRcx4pPLUperhJgjPeWGO1qiNNDhjuPQEcwmBdI+ JeNXzdRbYL/hHyovM5aQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hnf4g-0000hn-16; Wed, 17 Jul 2019 08:14:06 +0000 Received: from mail-vs1-xe44.google.com ([2607:f8b0:4864:20::e44]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hnf4d-0000h5-AB for linux-arm-kernel@lists.infradead.org; Wed, 17 Jul 2019 08:14:04 +0000 Received: by mail-vs1-xe44.google.com with SMTP id v129so15822066vsb.11 for ; Wed, 17 Jul 2019 01:14:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mOxb5tg5seSjtQqIorgKM+Di7ixuS6uqfAgdFu5RpzA=; b=G9skQ3aRbgwXpozrH+1DO97KndwvPNLHeERqMmQDZWWaONNCADEoaOMvPkA0sFj53o phoK8JUmNVcvN1zKr+0kawyF+mSilxU7i4gtAoMto3xyO9TQG5uMPuI/UfH3wukUoDOc j6XhR7QyCsO7y931Q57UTyK2rbsj1P5my0hS0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mOxb5tg5seSjtQqIorgKM+Di7ixuS6uqfAgdFu5RpzA=; b=Adu4zA1D5R4/TjN19fX6odKjAqv0jD04atE90YnyL3Q15sPFu/catrfjTIScIiGHKP V8KPLzRLyq4MTmmEAolDvyYxqQbGijsm5gt6Oi5WIU+Kn1mqCyif5IoRRid3xqFi+xHx fwP7daZF+BNj2yTQWQKxUhDkZjmYD1BYt/icVlosLH5LlQVI/1U7q/OGVAtBvnNfqa79 hglnj5D9L28hQkJA5qhp1zSZfb/ozc7tlU8vPgaU0aMD/PEooQqteuMpdbazLIxOr+UU z60cm77RWAl914WlJP8Oxdq6VyVEsE9ogQYnH0+L043WOM+5k2j1oXEbBJb+pk63swq3 mPjg== X-Gm-Message-State: APjAAAUdm4Hd5nyf82WFsH9AR2jePXejh2Z2RwtccTvsfCtHdIpNd2pn ZQzw+1cFKodhGwxFK5MXUV1dhxd6MpVArA59bqmkIQ== X-Google-Smtp-Source: APXvYqwumLX15i5KhdhsUxIfW0Chce/ceicYE3QuO3Xntx39jQED40S5LxMsWwDhbGTmvCiWV49cMhif6dAhO+pZRnI= X-Received: by 2002:a67:eb12:: with SMTP id a18mr1522512vso.119.1563351241789; Wed, 17 Jul 2019 01:14:01 -0700 (PDT) MIME-Version: 1.0 References: <20190716115725.66558-1-cychiang@chromium.org> <20190716115725.66558-6-cychiang@chromium.org> In-Reply-To: From: Cheng-yi Chiang Date: Wed, 17 Jul 2019 16:13:35 +0800 Message-ID: Subject: Re: [PATCH v4 5/5] ASoC: rockchip_max98090: Add HDMI jack support To: Tzung-Bi Shih X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190717_011403_356027_531DF27B X-CRM114-Status: GOOD ( 12.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ALSA development , Douglas Anderson , Heiko Stuebner , Liam Girdwood , David Airlie , dri-devel@lists.freedesktop.org, Takashi Iwai , tzungbi@chromium.org, Linux Kernel Mailing List , Hans Verkuil , Andrzej Hajda , Russell King , Mark Brown , Laurent Pinchart , Daniel Vetter , linux-rockchip@lists.infradead.org, Dylan Reid , Jaroslav Kysela , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 16, 2019 at 10:16 PM Tzung-Bi Shih wrote: > > On Tue, Jul 16, 2019 at 7:58 PM Cheng-Yi Chiang wrote: > > > > diff --git a/sound/soc/rockchip/rockchip_max98090.c b/sound/soc/rockchip/rockchip_max98090.c > > index c82948e383da..c81c4acda917 100644 > > --- a/sound/soc/rockchip/rockchip_max98090.c > > +++ b/sound/soc/rockchip/rockchip_max98090.c > > +static struct snd_soc_jack rk_hdmi_jack; > > + > > +static int rk_hdmi_init(struct snd_soc_pcm_runtime *runtime) > > +{ > > + struct snd_soc_card *card = runtime->card; > > + struct snd_soc_component *component = runtime->codec_dai->component; > > + int ret; > > + > > + /* enable jack detection */ > > + ret = snd_soc_card_jack_new(card, "HDMI Jack", SND_JACK_LINEOUT, > > + &rk_hdmi_jack, NULL, 0); > > + if (ret) { > > + dev_err(card->dev, "Can't new HDMI Jack %d\n", ret); > > + return ret; > > + } > > + > > + return hdmi_codec_set_jack_detect(component, &rk_hdmi_jack); > > +} > In the patch, you should select SND_SOC_HDMI_CODEC, because the patch > uses hdmi_codec_set_jack_detect which depends on hdmi-codec.c. Thanks! I'll fix in v5. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel