From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2B05C76192 for ; Wed, 17 Jul 2019 02:18:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 931BA2173E for ; Wed, 17 Jul 2019 02:18:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fxnG1MsS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="nUiqNxzK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 931BA2173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nvK2u9wZr3+DweATSp8O+615QOKwW/t2ummG5d4y+oQ=; b=fxnG1MsSfyB66g zcMzx1YI/DsH8YDy2tdanKTtu1Lw1p+qqx9SGteuTcWTqN2QMYzvOywtHFJtifnZkDA5fj9Jbaq/5 NZMbwc86aNm1W46ATDl5VrOAGW/e84K9gPViOwDR3G6ncq3kpojlIdBrXXUTo8pZuptMEZm8u/mtd asK6qEW7cAB+DZAqFlk+uZ6zM8zvtqiI4ZnQci8G9BkKN77bv2gASF9+DQzRKqKcSSBg1qfpE4G3l GXPiU6jDJp/IhlXxdplSw4SyeUanlhR5WPgpfTA5inMRxuV3toiIU6XKHMVP1yzvhHaaZ60TgJbSC EbzuphpU4BbF91pDzHgQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hnZW1-0005PX-8z; Wed, 17 Jul 2019 02:17:57 +0000 Received: from mail-vs1-xe44.google.com ([2607:f8b0:4864:20::e44]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hnZVy-0005OF-1f for linux-arm-kernel@lists.infradead.org; Wed, 17 Jul 2019 02:17:55 +0000 Received: by mail-vs1-xe44.google.com with SMTP id k9so15369384vso.5 for ; Tue, 16 Jul 2019 19:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Yeo9/78yIZ/9VC2V6OzC4jD48Q2tlshLhO2xlpzyNJY=; b=nUiqNxzKLCH4uh7Rdk28OYJeCqZg+QKn/Ua3o40RM8WpdDaG3iflhnr8M/qkqbKcgw MB6O6mEn6WPNEgokSircT8LHVL2pkHwIAhiObF6mtO0l5foVBQDuDCYQgfQ/yKy2vod1 EiRO1lNXlRxUc2xtXifWRV0NCnbRPoBSHfW0o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Yeo9/78yIZ/9VC2V6OzC4jD48Q2tlshLhO2xlpzyNJY=; b=C61LvaKkgQ58V9jBLryvRE7wNtrujgjm04+KA7AIeEb1gGgRLw++BCWJiU8ZcuNDYY 31b3TSEodAje2EG6Hjn9fhoH4Yct6rolhwQJxFOMxI2MTO6WKhmYQ8eHhKJ65f1Wt8ub xUKRONkFgAypPqeP5jREPSamPsbPCs/1e/x+5OpesKHx/+L4nzhg/s4T+XLkmSUiS3lg 8ibsCFGYDxynkOHspGqC4FYjRDzRRTdqG4lE/KPuma6mrydl/9aNa8fGE6sG1NctzxvZ qaDe829QDft7LHVGulHcWCuvkAh+0cwNIxHF7hVkOzUA5VNl4vRBYA8rLtG+kObe/5z4 cfmA== X-Gm-Message-State: APjAAAV1ustLX/DWkf3KD4bOjWRfTmPNHZ7S9bbLqr4u5sgNKlb7Q3C4 0UDQ5aFmg7yxfmwOpgc2Vylp7XvfP9R3m29bTqiQvw== X-Google-Smtp-Source: APXvYqxWnVBbK8jRKVsd6t2y7gQJuZMs4DlVLf7zXq9OOaLMsZSZoBF8H9LF78AxDMSny/dXL5TfEDzdnilbzMthY7M= X-Received: by 2002:a67:ebcb:: with SMTP id y11mr13049180vso.138.1563329872293; Tue, 16 Jul 2019 19:17:52 -0700 (PDT) MIME-Version: 1.0 References: <20190716115725.66558-1-cychiang@chromium.org> <20190716115725.66558-3-cychiang@chromium.org> In-Reply-To: From: Cheng-yi Chiang Date: Wed, 17 Jul 2019 10:17:25 +0800 Message-ID: Subject: Re: [PATCH v4 2/5] drm: bridge: dw-hdmi: Report connector status using callback To: Tzung-Bi Shih X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190716_191754_242352_76F9E42F X-CRM114-Status: GOOD ( 15.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ALSA development , Douglas Anderson , Heiko Stuebner , Liam Girdwood , David Airlie , dri-devel@lists.freedesktop.org, Takashi Iwai , tzungbi@chromium.org, Linux Kernel Mailing List , Hans Verkuil , Andrzej Hajda , Russell King , Mark Brown , Laurent Pinchart , Daniel Vetter , linux-rockchip@lists.infradead.org, Dylan Reid , Jaroslav Kysela , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 16, 2019 at 10:13 PM Tzung-Bi Shih wrote: > > On Tue, Jul 16, 2019 at 7:57 PM Cheng-Yi Chiang wrote: > > > > Change the Kconfig of DRM_DW_HDMI so it selects SND_SOC_HDMI_CODEC. > > This is for the typedef of hdmi_codec_plugged_cb to be used in dw-hdmi.c. > Not sure why you select SND_SOC_HDMI_CODEC in this patch. To have > definition of hdmi_codec_plugged_cb, include hdmi-codec.h should be > sufficient. > Thank you for the review! I misunderstood when to change Kconfig. Will fix in v5. > > > > diff --git a/drivers/gpu/drm/bridge/synopsys/Kconfig b/drivers/gpu/drm/bridge/synopsys/Kconfig > > index 21a1be3ced0f..309da052db97 100644 > > --- a/drivers/gpu/drm/bridge/synopsys/Kconfig > > +++ b/drivers/gpu/drm/bridge/synopsys/Kconfig > > @@ -4,6 +4,7 @@ config DRM_DW_HDMI > > select DRM_KMS_HELPER > > select REGMAP_MMIO > > select CEC_CORE if CEC_NOTIFIER > > + select SND_SOC_HDMI_CODEC > So that it is weird to select this option. > Will be removed in v5. Thanks! > > > > config DRM_DW_HDMI_AHB_AUDIO > > tristate "Synopsys Designware AHB Audio interface" > > @@ -20,7 +21,6 @@ config DRM_DW_HDMI_I2S_AUDIO > > tristate "Synopsys Designware I2S Audio interface" > > depends on SND_SOC > > depends on DRM_DW_HDMI > > - select SND_SOC_HDMI_CODEC > Also strange for deselecting the option. Should be in another commit > for another reason? Will be removed in v5. Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel